From patchwork Tue Dec 26 19:21:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 183352 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1057026dyb; Tue, 26 Dec 2023 11:26:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzwLN2nJY6/iJomBydMCxiBS7nsTto7VEn7hbRjDaWCN8uIHiGDbkCoaDOVjC86F2zzNIM X-Received: by 2002:a05:6808:2083:b0:3b8:3e9c:af97 with SMTP id s3-20020a056808208300b003b83e9caf97mr6910696oiw.48.1703618799902; Tue, 26 Dec 2023 11:26:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703618799; cv=none; d=google.com; s=arc-20160816; b=M3VrwxyequhNuqp6DJBchqFHtrv7LRVzVL/rLX+Z3glM/uptrIUpSBME9x05JEaJHx AAyv18BKjWzMFJT9Xlr4wNFKZHeli6SJ3xelAT9EKDO0BeheANvMclsMgKVaI8StYTHy iJEd6R05PSGmiRYDoCwDWVaVxNcdYEjikxQFp/Yc7rAhZq1jP+kvPS8lVzgFwKlzKHdR /jOa6nv1tO37NqoizfpuMGziatN5Yk+Kj57vKtx787oTZ8sZjWLbprBBpWkI8czZoluU on3SlVl5IDXKMPWWyQie06p99P/zD3cEMIuYZAiIXlMui/hITYSPGV36LNumznNI4qhR SGGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=jqUYIaw9tUo9kdqHB2Dv3IsUt9S6YDu3MfPzCVXpIHY=; fh=fHIDBBK46XC8s8gRlw6dvsExPUD8b1xG47W3mSw0mu4=; b=sfj+KfNV8rJ04A5cRD7brSBNcjFXL3kV4pcFKTkMI6EHsdAE/B36W1dsHIt/WKDhhY zOvqb2SHJgwj4d3SflZ3cdVMl0B5e5Fb52wkJ2JypuXzFB3AieV9fg7+OUWcfawIv1PA 1wVxIzodxdZDEqDXRaFxd7cWX6IUzrw3c3h3/6M73RDDAxpLFxcQTTAz6U5dxnA6e0Tt ussE7hGavyEU/deoDWPdYvZsxpMy0vy8+eX+cD09xY1Z1DghGVmWP+3M4727VQnhl7hi tXUsFzqTlah1OzYQTKHC/AevQTzSwxQLjOqkcYgHZZXrhmkLIQ5+UJNLpT691HnDl5Vl K/Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MS6sJGkx; spf=pass (google.com: domain of linux-kernel+bounces-11644-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11644-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bq16-20020a05620a469000b00780fbb0f4f1si13824574qkb.361.2023.12.26.11.26.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11644-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MS6sJGkx; spf=pass (google.com: domain of linux-kernel+bounces-11644-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11644-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AB9301C21F12 for ; Tue, 26 Dec 2023 19:26:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DAC119452; Tue, 26 Dec 2023 19:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MS6sJGkx" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA52A1798E for ; Tue, 26 Dec 2023 19:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-7b3708b3eacso211668339f.2 for ; Tue, 26 Dec 2023 11:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618536; x=1704223336; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jqUYIaw9tUo9kdqHB2Dv3IsUt9S6YDu3MfPzCVXpIHY=; b=MS6sJGkxdkX0z7x2nxw0xkPNbqiOWCdIBhd26tonRLpr/51eXdzUTj/bhZu2e27vof o2T7mvqG1fV1Ca2kVvHIxLSdzUA/oABGzAXyyA1fMOcY32bHgVt5BwVo6lHbyCHeXelM ZyTij5OUkYf0Hp2bal67qE+yxghYTbSwmnAoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618536; x=1704223336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jqUYIaw9tUo9kdqHB2Dv3IsUt9S6YDu3MfPzCVXpIHY=; b=X4yoR2SYiaNxixFzqIOVVao2rQwEfv40OAwg4+L8dp/ZtwEHBkMLxbzI+tJvxjpaGn a3/CK5BXJWhWWTqrzaAeyQCbd88G4/c2Pkl7YHFRGI91H1mfP0kXbGi7okj60jvngc2w fSmweUaDGuSmt7nAu246HQNW6a3iUiU39fjan1zs75aePQERF8Y7Jon9c9VcAFgtt0Ow Yw5zFFj0bICXgv3IX1LCql3pl1Hbb7PNg2oqwlnaS9WCTCXRWerFaGM+UglBy4gbesMk 8GYHVvBUejUvmEi4qoiKHNNUvtVa8wF5xmRTceA5zRPVTXyDNKw6PnCjmSE90gWjl6g6 WmNA== X-Gm-Message-State: AOJu0YwY/WQAiKqjIs/MBB/9Lbpn+XLTQAwVbEpYzVHQx8Sdh1uufDHi W6oM2NVNGvHWjrM371yEqxiP2lqVL56LaGSWSVuPiYxfPaZ6 X-Received: by 2002:a5d:9557:0:b0:7ba:f96f:8c76 with SMTP id a23-20020a5d9557000000b007baf96f8c76mr1245177ios.35.1703618535947; Tue, 26 Dec 2023 11:22:15 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:15 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Bjorn Andersson , Conor Dooley , Krzysztof Kozlowski , Rob Herring , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 16/24] arm64: dts: qcom: sdm845: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:20 -0700 Message-ID: <20231226122113.v3.16.I870e2c3490e7fc27a8f6bc41dba23b3dfacd2d13@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786373786742147962 X-GMAIL-MSGID: 1786373786742147962 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi index 0ab5e8f53ac9f..e8276db9eabb2 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi @@ -852,6 +852,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&ec_ap_int_l>; spi-max-frequency = <3000000>; + wakeup-source; cros_ec_pwm: pwm { compatible = "google,cros-ec-pwm";