From patchwork Tue Dec 26 19:21:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 183349 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1056849dyb; Tue, 26 Dec 2023 11:26:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQJTbl/Fnbf+hlRlMLn3k8r8HewwytEGhrs+V9IPPs3CLBnx8RWK0p7p2tdUXP6T5XWb5X X-Received: by 2002:a05:6870:96ac:b0:203:90ab:c17 with SMTP id o44-20020a05687096ac00b0020390ab0c17mr8050570oaq.95.1703618773006; Tue, 26 Dec 2023 11:26:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703618772; cv=none; d=google.com; s=arc-20160816; b=XryszevIoYFNIRbl9KLabRG3seIv5c6SrXlibXC//bAqrVzCq/PAa2vTmX/jUaYqBJ g9PnbgDq14GTS6I7k+i505i5giiJofWeM2tipkLDAd3TU4sW83HTdS3dbj6qY+dpdusM N31nAdxCVpCmIm6y+X44bZLQjsti/qriZizMsh0c/ldRgSDQ//Tez0BQNbX4sIrWonJC AcCmtFE0Ns0NPjt+JlqTIuWuASjLdAI5MWYEMfVURpqoNAszKshHON7oAXpXI7uFGLMK 5jOHdrdUe89gXtVKi/UyzskAVyef/n8n2RStJqMrZnD8NMwaMUBaVgEz6D0lb5sN3SWx gZ2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=fJeII5b51gSKYdx0OFHNNgnpr2euSDHg7QynlWWpDkw=; fh=fHIDBBK46XC8s8gRlw6dvsExPUD8b1xG47W3mSw0mu4=; b=IvK+w/nh2Xqdbzs5HGOdU8RxdtjORcX4abBVZTVIYRE+asr0O/PKf0m7Hheq3i42+q 5NeFbxjh4PMbRb+W1WAK+1fISHJQ9KcLtZkIHFYuo1Z/fPFqe/N/1bgi8BogKGGe4z1/ LI5xMTM8d50UedrIzF/CC+DArl2IzD2aSCOe72fBRos3DsSTsXBdYqYPD/a+qVCpV934 MaDBa7YntYKLhdwaIOg+qISXvQOn1rscD4JVdm/SgXiRfHDl3Gv+cz8hkCgJwDnpVFK9 ydw6CwUMYarGh+bIGh27MRyyymTPnez5K+NIpfSIUIgJ9bzyLepVjCDP5OST844pB2wu iLTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lwH5ozb3; spf=pass (google.com: domain of linux-kernel+bounces-11642-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11642-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c26-20020a631c1a000000b005c6b4091c32si10011455pgc.385.2023.12.26.11.26.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:26:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11642-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lwH5ozb3; spf=pass (google.com: domain of linux-kernel+bounces-11642-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11642-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BD955282C36 for ; Tue, 26 Dec 2023 19:26:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26159186A; Tue, 26 Dec 2023 19:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lwH5ozb3" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36001156C1 for ; Tue, 26 Dec 2023 19:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-7bade847536so84621239f.0 for ; Tue, 26 Dec 2023 11:22:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618534; x=1704223334; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fJeII5b51gSKYdx0OFHNNgnpr2euSDHg7QynlWWpDkw=; b=lwH5ozb3yLiy84322iyB6vejF0bjEUAPClt0LjlK6D6YdaOZrGoKWVHUMzvDHKr9kl SEhhJjGRTK+9DBvFoc7Isvpqi9dBtkN7aNTJzJteuu9H5/tSKRCAXheBHY6zwcNDbKRB FurQCAX0Nfbhc8OpEPUMpj4s9W/ATfdVSeNjs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618534; x=1704223334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fJeII5b51gSKYdx0OFHNNgnpr2euSDHg7QynlWWpDkw=; b=wG0WE2fiFI1uEFQOUUvUYaw4VL2GmieOAjU4/qY3KlZh1BRjnerKqJW63beSLx8csz 0MsL/UO85zkHRJi8bwaHyXH3JIfiVnEnJjTHX8tK31lA7DaYJRpYe8rUcSSffgXEs7lc 4rm3eqBCE74j5Mdhp93WWM4QLi8GCdsiTNTPZ0cKq/KgLS7SPnnfn/CzRyTFR0pek303 kV2oEotXHkmQVBvVzU2hfrB9I3nHwRcEbV+Vtrw/bGqn/KJ99vnFk0OafSqCNt0eIyYQ avA3d1ygY3wQy1meHYljwO0RQSmqQrn7S6w2RuW/R0E0N0F+7nTuBR5rk6DMSJPDVRxH NuOA== X-Gm-Message-State: AOJu0Yy+VSw2zm1yJQVJzrQJwybYphfEnoai0D/87vsDXcKwumFf4pAH xBNzOuZ919w1QWyZStQtsWN+Xhn1sqcDoQBOk1Hav7TC9FJG X-Received: by 2002:a5d:974b:0:b0:7b7:4b32:7986 with SMTP id c11-20020a5d974b000000b007b74b327986mr10235601ioo.27.1703618534234; Tue, 26 Dec 2023 11:22:14 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:14 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Bjorn Andersson , Conor Dooley , Krzysztof Kozlowski , Rob Herring , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 14/24] arm64: dts: qcom: sc7180: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:18 -0700 Message-ID: <20231226122113.v3.14.I2ee94aede9e25932f656c2bdb832be3199fa1291@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786373758050905739 X-GMAIL-MSGID: 1786373758050905739 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 46aaeba286047..f3a6da8b28901 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -649,6 +649,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&ap_ec_int_l>; spi-max-frequency = <3000000>; + wakeup-source; cros_ec_pwm: pwm { compatible = "google,cros-ec-pwm";