From patchwork Tue Dec 26 19:21:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 183348 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1056534dyb; Tue, 26 Dec 2023 11:25:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUOqmtpYKfrbnnAt4e500CCoZQOFvPCqdvjTTOtjRt2X/Yb2LVSEZvpAZXT2tk920OgkT4 X-Received: by 2002:a17:902:bb10:b0:1d4:8e5:1ab0 with SMTP id im16-20020a170902bb1000b001d408e51ab0mr8312491plb.121.1703618721769; Tue, 26 Dec 2023 11:25:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703618721; cv=none; d=google.com; s=arc-20160816; b=Dq4hAUgrTeacirCF0Od8t80CSnDUjok9vaK8g8QuEVJhVzMjO0QtptCLOHm8wBxyU2 MmCaS0ozF/QAYlCkKVX9SVeyRKX0QZ8gXLEgaKpTcfbmukLBfUaIwE0vShetvperz4kp opBGvwi7Rh5Bug1lmoOrH32VFj8PFyI3U5avZ/8kp1ARouILwOcy4zCuoolrPfqv4q66 AvSqBbFcCdZU0HRmCWueGZ7kgNXt0zYUgGxt9NXk5uYHI/zRAO+AHLcxLiosCXJ5y5Qy KsmpNWdtUjfVFFtUOLdiM/1XsSKsZ5ixv6JIcbls2rOaV1GpXj7V6I+vxSLqZww+C0ZS TnxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ESf+HP/4Pbj+l15SV7DO/QREg1e8QVEjr0ahdi8QujY=; fh=pt1TLB/wZ8z1dGXaDPjijncZtx8Ewp7qeNyQlDGp8/M=; b=HbSULEmeZE2UZ+Akm1x1yDUoondWnbXLxZbpOJcSIvLsZkdUOfxS57+dOENxpNfni/ PrEoVvreZCAlVfzh3zqnQrIMvM50PASJe6T0/+s/AW0gmDnzlzh+RT+DWpf6A0jc0UnL uFBi1PlZK6N89+e3YyaGw9jPOPW7ZR37jgAuqgd5TnWEMQoZFHr/BWdrw5b32plxmKcp y2pd3XktDuFRwNrjMiYBbNwTJoz7vepYghftYacp4R410FkLY19MIjTLqaxPkC+Ssr3S dQJI2JqXFO/5XO4J/kf4HSt1zLPIcMEbGD2m9ZYW0NmVr1dYBQUnS01nyXALhljCKILA Ig9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HkdKktzt; spf=pass (google.com: domain of linux-kernel+bounces-11639-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11639-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id n14-20020a17090ac68e00b0028bbed9e5a5si12553295pjt.96.2023.12.26.11.25.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:25:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11639-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HkdKktzt; spf=pass (google.com: domain of linux-kernel+bounces-11639-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11639-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7DF5C280ED8 for ; Tue, 26 Dec 2023 19:25:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79BD017721; Tue, 26 Dec 2023 19:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HkdKktzt" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CC912E72 for ; Tue, 26 Dec 2023 19:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7b7d55d7717so215336839f.2 for ; Tue, 26 Dec 2023 11:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618531; x=1704223331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ESf+HP/4Pbj+l15SV7DO/QREg1e8QVEjr0ahdi8QujY=; b=HkdKktzt7nt59KOZ+FkuhhdJMdW/AYVTpAwHDp+g0xR53xj3f/gQ4CAHnwzEIMkwa5 u/N5xdQ3l4GBqemrSSn8+/ziF/c30zF7bKzttsUjPs+bWCp7znmxolHrfHVUFbwKB+on 71vjXxguhACFN+7kSGw+VEDxDEpEIyvjYJ/00= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618531; x=1704223331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ESf+HP/4Pbj+l15SV7DO/QREg1e8QVEjr0ahdi8QujY=; b=UkG9NuwXoYibQfQa+uCA4QmIlQO7uugOK3aAxecE3105n+ZD2tk5u43eaC4OrUIaHS bG4EVW5aA/rkVFvRKLKZXVbDz7rnPjSqLaCAhVjgKH10oeKNR3hSHOLe+SoxD04APwTQ Bfw9rOaZhmowx052P8RQL9t+olunqj6sLsVq2dKrXth9yqHbjX3zcMzwrdPuqiiwP/aw joaxlo0yjq4Z3IodPaoK67++HN9b1xasXrlINc/35AWuTOpxpPptHMkDDuO9Lxl5RSZ9 vVaeMNfHeFaL+feSuoeC5mI9Pm+ILGCcNM/gPVqa1DPn1fibsXhBbBOSjEbu4jlX0xea SEVA== X-Gm-Message-State: AOJu0YxnubstiCZweRM6h5v3b0P3LXWMRhoJxVg7Qk8XB195O0J9b6LV K4hPqV/OmryKghjGSdhSRu9qMBWPHucyarpZ7z7f0BuXR+pG X-Received: by 2002:a6b:e714:0:b0:7ba:94cb:aa23 with SMTP id b20-20020a6be714000000b007ba94cbaa23mr8299937ioh.21.1703618531662; Tue, 26 Dec 2023 11:22:11 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:11 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 11/24] arm64: dts: mediatek: mt8192: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:15 -0700 Message-ID: <20231226122113.v3.11.Ibd330d26a00f5e219a7e448452769124833a9762@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786373704312607639 X-GMAIL-MSGID: 1786373704312607639 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi index f2281250ac35d..ab44d382f757e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi @@ -1332,6 +1332,7 @@ cros_ec: ec@0 { spi-max-frequency = <3000000>; pinctrl-names = "default"; pinctrl-0 = <&cros_ec_int>; + wakeup-source; #address-cells = <1>; #size-cells = <0>;