From patchwork Tue Dec 26 19:21:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 183347 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1056417dyb; Tue, 26 Dec 2023 11:25:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsKZFJO38xHrt6WWqJAaIjQv2VZkv5th6Ap4Ntaomx+Tyq7fkF2AcO8C3di8sl5YpTPdM3 X-Received: by 2002:a05:6a00:9097:b0:6d9:b15f:8ffe with SMTP id jo23-20020a056a00909700b006d9b15f8ffemr5306532pfb.6.1703618706396; Tue, 26 Dec 2023 11:25:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703618706; cv=none; d=google.com; s=arc-20160816; b=WiCpuHJTMS0aMC7cgzkBRBYgauwLvaw2SgKRTajRn3IYcuX8LcHloeHqEnSoZLD5kS T7AI+JUf5S2RZIWb/aUUFUSMknHp9DxGYpqpFXAHI1qP/rJVnh0Sw3DjaKrokXmrrONQ EvPqH5TmDoudC4v9mluwZrWdp8nyUHhz3Og/2CYF3Qg1oev28lIgVHAjZ83Er0FlXBz6 1fg2vzKyvmpLZGR8nx5o34BPlobkEY5Bt3xbICWpaks8f26VaG7J/nl9GximAekBD8fe qbl5M9VxIL7L//8jRBAsr+ki8oEAD+HKk8+sb7sUG8+HeG3/gk9qFMihfjl+Th1SFXra Jxnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=h7Ja8Mbk0Dn0paAcqtccJazS/+ZwMfvgkX5xOL8nKJI=; fh=pt1TLB/wZ8z1dGXaDPjijncZtx8Ewp7qeNyQlDGp8/M=; b=i75b5laQn9xR8zMOACX3hjIlp9x2zCDVU/hO75KoC3eHsftJYtJpOhq3WdOo/XfDWM gCIuQwrxaZ8ouXwg61SbqBqbgGNJsCD6mlgsSObtJb9w5+Wm1AslirQEtDXAJ6J7t1u0 lFFfwBbXdjf9GWudr7Yl0ran8QUo788X9pz6Z4omLQU+lfSe8RHSZ820O+VBfLa4BdeW VvLnzO4XhVmWwvkKr5uoW0VdS4sdy30BStgkJ7d9HGWSTFhkscvEFYZG/wq26MQhwUi9 IvIfYFA5FizLmyVkl91z11ZJ/Q4jJROEZvcIYHze86aKctIA9WDkIC8LKwkOAAurYE2A oP1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FcVKVBsB; spf=pass (google.com: domain of linux-kernel+bounces-11638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11638-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q16-20020a631f50000000b005ce13c1baf1si4812790pgm.889.2023.12.26.11.25.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:25:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FcVKVBsB; spf=pass (google.com: domain of linux-kernel+bounces-11638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11638-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3029E28207F for ; Tue, 26 Dec 2023 19:25:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9D1CD15EA6; Tue, 26 Dec 2023 19:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FcVKVBsB" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1E5512B6B for ; Tue, 26 Dec 2023 19:22:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-7baa8097064so145754639f.3 for ; Tue, 26 Dec 2023 11:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618530; x=1704223330; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h7Ja8Mbk0Dn0paAcqtccJazS/+ZwMfvgkX5xOL8nKJI=; b=FcVKVBsBIzjgccnZnc3m9lv2bIKNpYvewrs/E69Du2Mn8jDtSWs5y7MHDy7NHjXOeb WGu6Jsm1uHbU1jwDHz6RzKPXq4EdtnKBYt8AJQLXzVrc5PmqMQbAITfwY0q1/2X6qO5D 6clq1Db/55aeiKwQAvlEzmpmNKuFzcSV3V0Tk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618530; x=1704223330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h7Ja8Mbk0Dn0paAcqtccJazS/+ZwMfvgkX5xOL8nKJI=; b=s+fzfL1w5gWgAwdw1wLo86Lhq7nkZGg+Zx2UcvY3Eq6/smbzmPTEsqmkUD91fmAkjF pyd7gNRO0yE2d5ftV2ytDBsKLSAEDrMDtfHI/aA3oicoJcv132t8ygFud+vcwFYkni8p OlzY9nnFTpV8rLhj7oox04FbEQZBqqD+IFBO4/0N4FTCtfOa2Tg9UDhMZY2MD15NUMPI g7pCal6nuIRe/cRPE5a1YGB32PPs6rrHJfn+0r9PJI+r1kV4ruwj4rOEnVxeKsnrGJ3g NsSA52Kmn2YgWnuU6yZ5f6SyDwMGu4a0PO+NN0RY0l9CaEfSS+1gJsj5l6p+ihpRhRwn LePA== X-Gm-Message-State: AOJu0YzIcMwwEuhiM8zwx+fR81eqcmQndfmBjdrGfsUhmDUYixlR8916 l/cco/qYI1FKAUmxmgD2HKMDpnkxjxuBJGNlUc1bFxzKjYgh X-Received: by 2002:a05:6602:3e8b:b0:7ba:a650:13d1 with SMTP id el11-20020a0566023e8b00b007baa65013d1mr9133258iob.10.1703618530770; Tue, 26 Dec 2023 11:22:10 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:10 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 10/24] arm64: dts: mediatek: mt8183: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:14 -0700 Message-ID: <20231226122113.v3.10.Iba4a8b7e908989e57f7838a80013a4062be5e614@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786373688640059918 X-GMAIL-MSGID: 1786373688640059918 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index 5506de83f61d4..08261164ab18d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -924,6 +924,7 @@ cros_ec: cros-ec@0 { interrupts-extended = <&pio 151 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&ec_ap_int_odl>; + wakeup-source; i2c_tunnel: i2c-tunnel { compatible = "google,cros-ec-i2c-tunnel";