From patchwork Mon Dec 25 05:39:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Shenghao" X-Patchwork-Id: 183125 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp244725dyb; Sun, 24 Dec 2023 21:42:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzot+qPA9h/ltCAsI/zN8jcGLXWdtcFdewZEWH68m0yJS1070EVUWbsPwb1wVT+FThd0ic X-Received: by 2002:a05:6a20:3259:b0:194:9898:17f8 with SMTP id hm25-20020a056a20325900b00194989817f8mr4806920pzc.31.1703482940341; Sun, 24 Dec 2023 21:42:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703482940; cv=none; d=google.com; s=arc-20160816; b=kaeDNC5IL0gY5dmVA8JtvLcIcwscjQ7Il9j/RcC6PliCtF9qSa3IAn8nhiQceWEZZ7 4LUc39GXTcA420Z1Av7v0Sr52omkUL+rP9eU2GtBa82vjRGZzZnPxNgwNcZCZLKiKLTh QmLD036CXlmN9vZg9zP7pcpT/gL1fKq9uMYr8c+WnIBPwCc2XZVHuFaG0jYvsNYmm5RI hTD3jPSXzc5tzMTiTYLz8KZg5nXyzKzMqf6pmOx2eW9ea/KxjsdIuycGTGJTUHE7zGAh kKBYHOtj0Cv5LWUgWS9yrc2RlVA82h5eUUvtr3lVBz2XctXjoClmFOmS8Ti9eVwU8DA/ ajKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=IzvHSce1KXGXvd7Susyupy1VQZBvpXf3R+NT2Xh9qEE=; fh=nmpqriIAxzz9z4/piqOabUsFkiEK8VDv7G5j+pvfHas=; b=hvPE7rYE/gR7fAhpAXvjNWlYR5VIVP6ytlZK0v0gOwmMnZ9ekviMt5tpCR4URSiqQ6 qBNauorkQKqzH+kjJl7hM+3MiFRs5AqIepS5KLqb0+QQpnWFLq79DwDC1gHUGKxBxx2k p1CXbuLShUB7EGGFFr7r0zz5YgEZZ+p7Uke2e30zu/8TitMwUaTKbRVU/99yXC5HXRUz VjQ3l8Q+d3VeoQngNxjS7eJJXOa/q80gNf2wWsDc4bDBrWJdHsO2ZjcPQcxAUfDsVtpW FIg8KSpOGOhDpTkDRlplOoZh56otYMHp60DGIIUu6T04NFMIo41cbe+2Qiy2L9D9KTt4 5vaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=AfvWDeCU; spf=pass (google.com: domain of linux-kernel+bounces-10897-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10897-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k26-20020aa792da000000b006d5b877aa9bsi7313524pfa.368.2023.12.24.21.42.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 21:42:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10897-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=AfvWDeCU; spf=pass (google.com: domain of linux-kernel+bounces-10897-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10897-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 21E73281884 for ; Mon, 25 Dec 2023 05:42:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8CFFEF4E9; Mon, 25 Dec 2023 05:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="AfvWDeCU" X-Original-To: linux-kernel@vger.kernel.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9658310EE; Mon, 25 Dec 2023 05:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3BP5eDf9002428; Sun, 24 Dec 2023 23:40:13 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1703482813; bh=IzvHSce1KXGXvd7Susyupy1VQZBvpXf3R+NT2Xh9qEE=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=AfvWDeCU0yT1R3yAPjxur7nFtQar9HClWrDAX4x+Btf0BQbh1zn/HdzfQV7wAVmhK tha65BOYLYNZ23eTCxhfay5CYC7hZ/yfbfokXmBr/DQp5FxeQAnGQljpRBLRbv/BSd zzyIgK4D1iJ393Hxr8ithtP+XyIVkqyAJBMcSiMQ= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3BP5eDJs002184 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 24 Dec 2023 23:40:13 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sun, 24 Dec 2023 23:40:12 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sun, 24 Dec 2023 23:40:12 -0600 Received: from LT5CG31242FY.dhcp.ti.com ([10.250.160.240]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3BP5deff118972; Sun, 24 Dec 2023 23:40:05 -0600 From: Shenghao Ding To: , , CC: , , , , , , , , <13916275206@139.com>, , , , , , , , Shenghao Ding Subject: [PATCH v3 4/5] ASoC: tas2781: Add tas2563 into driver Date: Mon, 25 Dec 2023 13:39:30 +0800 Message-ID: <20231225053932.1138-4-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20231225053932.1138-1-shenghao-ding@ti.com> References: <20231225053932.1138-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786231327367328708 X-GMAIL-MSGID: 1786231327367328708 Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder dooes is to parse the firmware and download them to the tas2781 or tas2563, then power on tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver. Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding --- Change in v3: - Add tas2563 to tas2781 driver - Add more comments on why move tas2563 to tas2781 driver - Provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. --- sound/soc/codecs/tas2781-i2c.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index 55cd5e3c23a5..c6afc87f2c69 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -5,9 +5,9 @@ // Copyright (C) 2022 - 2023 Texas Instruments Incorporated // https://www.ti.com // -// The TAS2781 driver implements a flexible and configurable +// The TAS2781/TAS2563 driver implements a flexible and configurable // algo coefficient setting for one, two, or even multiple -// TAS2781 chips. +// TAS2781/TAS2563 chips. // // Author: Shenghao Ding // Author: Kevin Lu @@ -33,6 +33,7 @@ static const struct i2c_device_id tasdevice_id[] = { { "tas2781", TAS2781 }, + { "tas2563", TAS2563 }, {} }; MODULE_DEVICE_TABLE(i2c, tasdevice_id); @@ -40,6 +41,7 @@ MODULE_DEVICE_TABLE(i2c, tasdevice_id); #ifdef CONFIG_OF static const struct of_device_id tasdevice_of_match[] = { { .compatible = "ti,tas2781" }, + { .compatible = "ti,tas2563" }, {}, }; MODULE_DEVICE_TABLE(of, tasdevice_of_match);