From patchwork Sun Dec 24 18:34:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 183106 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp75010dyb; Sun, 24 Dec 2023 10:37:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKi/yt6UmvwDOg2qLmewdrx3ZmG55V90wA5O2wa3+VTQK+I1go9ISa8HCZ6lFKCZMJmFNk X-Received: by 2002:a05:6870:d8ca:b0:204:1a71:52d3 with SMTP id of10-20020a056870d8ca00b002041a7152d3mr6764911oac.35.1703443046520; Sun, 24 Dec 2023 10:37:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703443046; cv=none; d=google.com; s=arc-20160816; b=FtkPiNZ00YNKNJWiW+1tFtWr4zR7Fjvw2S11hcIpd9XBZzPkaoXIzZ0DWlbbUN34Y8 oJLs3jPWJ05c14n3aoIj3boumvgRUypMhrWiDJ6HSc3HFGtjMcX+xwJ0BOFzWWFWHGrw 4wxv/wr3dMZnSLqFloe0RzvEask+ikrXHrO4dPxOT47f0lPVrRqYV7b2xDaFKYWC9Qj4 U8jZ/VLWFSt2kYCtnysqIQP2A/opWm2rIUj9vl36jWIVEdaBpNJ2Qs8acMgX46LKwqij DCbcCKYxCK22BrZ7I/g+tBCNNNT19bmx2r3FBNTVVWEN4QiTTUcLf9vZWFljyOtZmaDC k89w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=zvZOHxWVh/mJiCQHlq/7UwzyMBE7eRNX3nk6Uoehacw=; fh=mAP6OjvWItsuYmlxI3oGuIcHHyhFdjhD5nj/wT7LofM=; b=aJRuszZuOEjavdyL2bnje2xWWFJytbmpTVYJdw1sNgoPn9yknyzL70nwR785XZIowE TBAfcGuNVwuCLza0wR7+S4GJc4TdcYtvSB6lWo2Kdy8ZDPEysoe4BL1bkQzV7E+jNcja bkpNePmKJEpD+tnj+4SnMmXG0Cagr25Wo7Cib3bd/Fap4C/GEZcA4A1WtIIolKM3gD8Y ZVjik438DQyVlxAvE9wnUJBuOYl7bd3Ba81tHHCCy07+3ia3/87rH96Fwi0ogJCQqHPF DDpKGTnFiAphsMJsQO7tY3KAEOUWIdG5hCdyX8Uq7HTgaAMILKThPsgUO2re9l5dPFkE cQFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GA7iF933; spf=pass (google.com: domain of linux-kernel+bounces-10799-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10799-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e2-20020a656782000000b005cdff2eb998si3456854pgr.744.2023.12.24.10.37.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 10:37:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10799-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GA7iF933; spf=pass (google.com: domain of linux-kernel+bounces-10799-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10799-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E5072281F08 for ; Sun, 24 Dec 2023 18:37:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0070AFC1C; Sun, 24 Dec 2023 18:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GA7iF933" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E30418C17 for ; Sun, 24 Dec 2023 18:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703442856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zvZOHxWVh/mJiCQHlq/7UwzyMBE7eRNX3nk6Uoehacw=; b=GA7iF9339OKz6TJhZuD623+BSyK2mXpcLq4aGEl7Oal1uS2Nutq2OJ+15N/PiWd9PQlhoJ 10AeeUrXpALIqcco5x9nI5HA3sI0gH+S77Z7XpYN5faYsX3zDGQ0FpQ2qdwlynyglAAt5x EAOHjL/8Hb3Ni8GpZur4+6ZjWQ1s76c= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-PpWDDgHrPOimc3FcWeExTg-1; Sun, 24 Dec 2023 13:34:11 -0500 X-MC-Unique: PpWDDgHrPOimc3FcWeExTg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D592738562C1; Sun, 24 Dec 2023 18:34:10 +0000 (UTC) Received: from localhost.localdomain (unknown [10.39.192.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE44A51D5; Sun, 24 Dec 2023 18:34:09 +0000 (UTC) From: Hans de Goede To: Eric Piel , Greg Kroah-Hartman Cc: Hans de Goede , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] misc: lis3lv02d_i2c: Add missing setting of the reg_ctrl callback Date: Sun, 24 Dec 2023 19:34:02 +0100 Message-ID: <20231224183402.95640-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786189496008000254 X-GMAIL-MSGID: 1786189496008000254 The lis3lv02d_i2c driver was missing a line to set the lis3_dev's reg_ctrl callback. lis3_reg_ctrl(on) is called from the init callback, but due to the missing reg_ctrl callback the regulators where never turned off again leading to the following oops/backtrace when detaching the driver: [ 82.313527] ------------[ cut here ]------------ [ 82.313546] WARNING: CPU: 1 PID: 1724 at drivers/regulator/core.c:2396 _regulator_put+0x219/0x230 ... [ 82.313695] RIP: 0010:_regulator_put+0x219/0x230 ... [ 82.314767] Call Trace: [ 82.314770] [ 82.314772] ? _regulator_put+0x219/0x230 [ 82.314777] ? __warn+0x81/0x170 [ 82.314784] ? _regulator_put+0x219/0x230 [ 82.314791] ? report_bug+0x18d/0x1c0 [ 82.314801] ? handle_bug+0x3c/0x80 [ 82.314806] ? exc_invalid_op+0x13/0x60 [ 82.314812] ? asm_exc_invalid_op+0x16/0x20 [ 82.314845] ? _regulator_put+0x219/0x230 [ 82.314857] regulator_bulk_free+0x39/0x60 [ 82.314865] i2c_device_remove+0x22/0xb0 Add the missing setting of the callback so that the regulators properly get turned off again when not used. Signed-off-by: Hans de Goede --- Note I've deliberately left out Fixes && Cc:stable tags, this driver has not been touched in ages so apparently this bug has been with us for ages and has never really been a problem. So lets play it safe and not backport this. --- drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c index 3882e97e96a7..c6eb27d46cb0 100644 --- a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c +++ b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c @@ -150,6 +150,7 @@ static int lis3lv02d_i2c_probe(struct i2c_client *client) lis3_dev.init = lis3_i2c_init; lis3_dev.read = lis3_i2c_read; lis3_dev.write = lis3_i2c_write; + lis3_dev.reg_ctrl = lis3_reg_ctrl; lis3_dev.irq = client->irq; lis3_dev.ac = lis3lv02d_axis_map; lis3_dev.pm_dev = &client->dev;