Message ID | 20231223033703.2949831-3-linan666@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-10270-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1471410dyi; Fri, 22 Dec 2023 19:39:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGSq4cMuVPeoeQ4y6reTa9lrOe4+aw30XD83CbSUzI0q5k/Rf6Gk/lHfaHGNWW0cJTZx2ug X-Received: by 2002:a05:6e02:174c:b0:35d:5995:1d74 with SMTP id y12-20020a056e02174c00b0035d59951d74mr3952491ill.57.1703302798372; Fri, 22 Dec 2023 19:39:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703302798; cv=none; d=google.com; s=arc-20160816; b=Itntd7IJkMj4kC6MazIusG6WjrP2MkjXYIi1qrCsC0EaDU0bqZ5cYvTXpxLNRMEOKH rWlPu1iamNAwfE2+aDXbamhxuU6+rtqTn5KA1ja/s7As6WIVX/PQD86iRQkYX9kq0MME U3hEJ2DrYVxB7u6Mwd//8wCIXSiwge4k1HnW5ogV76YpwqxrjJhpoOPybrvx1oR98GpX L+mMp1ZzkwsBkOp8++FoYTYiTTv33PvQOvtD34YHfN7q5rDjtg0U2oqIxWQmI8ZbtkLo YOdoFAF3ygeKtGRtYW5HbF2f4MOBaldVuh9WVX9hkvYWilfQYx9n3iOte1qo/4FKLiY7 Azcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=JpfLgy+rYMnxPzrifkDDFIprQVyh58KP7+xLvNm0DdI=; fh=KzMu/56/cZ/XdN+BRAd8A7ip70iszopujqpzmcppc/E=; b=HO6gc8WWI2+XED2E32PBBLdm7f3wPAKoihRVSx4eLWC3mperO4RgGRiutCjkOtBh/m RCZj01Xa+kI8xJYtkW/Oju5kR+4F/rf3voLva8buAPbMddAKItnjNlWa6H5zifRjSYOO 95pFQbi9MGmUaKVApg6K9zzE5MowVy4haloj7rVilYK2noYAMHwObFBDW6h8Ve412x3d HSu8yiX1cHQ3J56X5fqZZhYMHpGEnHm2zulPk/b7QgvdC3g/V2FBD6Va2WZpvrFSehMT mu9lPkPzVj6/obx/HQSVJ0KIGTkT/UvGWYGJckjkShw3i42vvtDjcXA7Qyew0SkunI9t Hj3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10270-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10270-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id je22-20020a170903265600b001d3e0015962si4237546plb.256.2023.12.22.19.39.58 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 19:39:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10270-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10270-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10270-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2553B28382F for <ouuuleilei@gmail.com>; Sat, 23 Dec 2023 03:39:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B4ADF8BEC; Sat, 23 Dec 2023 03:39:16 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBCDED9; Sat, 23 Dec 2023 03:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Sxqdz6grDz4f3lCy; Sat, 23 Dec 2023 11:39:03 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 39A331A0743; Sat, 23 Dec 2023 11:39:09 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP1 (Coremail) with SMTP id cCh0CgD3Rg1aVoZl1dePEQ--.1070S6; Sat, 23 Dec 2023 11:39:09 +0800 (CST) From: linan666@huaweicloud.com To: song@kernel.org, axboe@kernel.dk Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linan666@huaweicloud.com, yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com Subject: [PATCH v3 2/2] md: don't account sync_io if iostats of the disk is disabled Date: Sat, 23 Dec 2023 11:37:03 +0800 Message-Id: <20231223033703.2949831-3-linan666@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231223033703.2949831-1-linan666@huaweicloud.com> References: <20231223033703.2949831-1-linan666@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: cCh0CgD3Rg1aVoZl1dePEQ--.1070S6 X-Coremail-Antispam: 1UD129KBjvJXoW7KFWxKF4kKr1xuF15Jr4DCFg_yoW8XryfpF Z5AF9ay34UXr45Wa4DXryDCa4rW3srKFWUArW7u3yfXFyaqr9xGFWrXayqqF1DXFWrGFWa v3Wjy39093W0yr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmK14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jryl82xGYIkIc2 x26xkF7I0E14v26r4j6ryUM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAa c4AC62xK8xCEY4vEwIxC4wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzV Aqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S 6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxw ACI402YVCY1x02628vn2kIc2xKxwAKzVCY07xG64k0F24l42xK82IYc2Ij64vIr41l4I8I 3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxV WUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAF wI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcI k0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j 6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU1xhLUUUUU X-CM-SenderInfo: polqt0awwwqx5xdzvxpfor3voofrz/ X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786042435436000876 X-GMAIL-MSGID: 1786042435436000876 |
Series |
md: fix is_mddev_idle()
|
|
Commit Message
Li Nan
Dec. 23, 2023, 3:37 a.m. UTC
From: Li Nan <linan122@huawei.com> If iostats is disabled, disk_stats will not be updated and part_stat_read_accum() only returns a constant value. In this case, continuing to count sync_io and to check is_mddev_idle() is no longer meaningful. Signed-off-by: Li Nan <linan122@huawei.com> --- drivers/md/md.h | 3 ++- drivers/md/md.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-)
Comments
在 2023/12/23 11:37, linan666@huaweicloud.com 写道: > From: Li Nan <linan122@huawei.com> > > If iostats is disabled, disk_stats will not be updated and > part_stat_read_accum() only returns a constant value. In this case, > continuing to count sync_io and to check is_mddev_idle() is no longer > meaningful. > > Signed-off-by: Li Nan <linan122@huawei.com> > --- > drivers/md/md.h | 3 ++- > drivers/md/md.c | 4 ++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/md.h b/drivers/md/md.h > index 1a4f976951c1..e2d03a7a858c 100644 > --- a/drivers/md/md.h > +++ b/drivers/md/md.h > @@ -584,7 +584,8 @@ extern void mddev_unlock(struct mddev *mddev); > > static inline void md_sync_acct(struct block_device *bdev, unsigned long nr_sectors) > { > - atomic64_add(nr_sectors, &bdev->bd_disk->sync_io); > + if (blk_queue_io_stat(bdev->bd_disk->queue)) > + atomic64_add(nr_sectors, &bdev->bd_disk->sync_io); > } > > static inline void md_sync_acct_bio(struct bio *bio, unsigned long nr_sectors) > diff --git a/drivers/md/md.c b/drivers/md/md.c > index a6829ea5b560..b56614eae8dc 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -8502,6 +8502,10 @@ static int is_mddev_idle(struct mddev *mddev, int init) > rcu_read_lock(); > rdev_for_each_rcu(rdev, mddev) { > struct gendisk *disk = rdev->bdev->bd_disk; > + > + if (!blk_queue_io_stat(disk->queue)) > + continue; Consider that the queue flag can be set/cleared through sysfs, let's keep set rdev->last_events in the case 'init'. To prevent a false positive(althrough highly unlikely) if iostat is enabled during md_do_sync(). Thanks, Kuai > + > curr_events = > (long long)part_stat_read_accum(disk->part0, sectors) - > atomic64_read(&disk->sync_io); >
在 2024/1/3 11:16, Yu Kuai 写道: > > > 在 2023/12/23 11:37, linan666@huaweicloud.com 写道: >> From: Li Nan <linan122@huawei.com> >> >> If iostats is disabled, disk_stats will not be updated and >> part_stat_read_accum() only returns a constant value. In this case, >> continuing to count sync_io and to check is_mddev_idle() is no longer >> meaningful. >> >> Signed-off-by: Li Nan <linan122@huawei.com> >> --- >> drivers/md/md.h | 3 ++- >> drivers/md/md.c | 4 ++++ >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/md/md.h b/drivers/md/md.h >> index 1a4f976951c1..e2d03a7a858c 100644 >> --- a/drivers/md/md.h >> +++ b/drivers/md/md.h >> @@ -584,7 +584,8 @@ extern void mddev_unlock(struct mddev *mddev); >> static inline void md_sync_acct(struct block_device *bdev, unsigned >> long nr_sectors) >> { >> - atomic64_add(nr_sectors, &bdev->bd_disk->sync_io); >> + if (blk_queue_io_stat(bdev->bd_disk->queue)) >> + atomic64_add(nr_sectors, &bdev->bd_disk->sync_io); >> } >> static inline void md_sync_acct_bio(struct bio *bio, unsigned long >> nr_sectors) >> diff --git a/drivers/md/md.c b/drivers/md/md.c >> index a6829ea5b560..b56614eae8dc 100644 >> --- a/drivers/md/md.c >> +++ b/drivers/md/md.c >> @@ -8502,6 +8502,10 @@ static int is_mddev_idle(struct mddev *mddev, >> int init) >> rcu_read_lock(); >> rdev_for_each_rcu(rdev, mddev) { >> struct gendisk *disk = rdev->bdev->bd_disk; >> + >> + if (!blk_queue_io_stat(disk->queue)) >> + continue; > > Consider that the queue flag can be set/cleared through sysfs, let's > keep set rdev->last_events in the case 'init'. To prevent a false > positive(althrough highly unlikely) if iostat is enabled during > md_do_sync(). > Thanks for your review, I will add checks of 'init' in next version. > Thanks, > Kuai > >> + >> curr_events = >> (long long)part_stat_read_accum(disk->part0, sectors) - >> atomic64_read(&disk->sync_io); >>
diff --git a/drivers/md/md.h b/drivers/md/md.h index 1a4f976951c1..e2d03a7a858c 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -584,7 +584,8 @@ extern void mddev_unlock(struct mddev *mddev); static inline void md_sync_acct(struct block_device *bdev, unsigned long nr_sectors) { - atomic64_add(nr_sectors, &bdev->bd_disk->sync_io); + if (blk_queue_io_stat(bdev->bd_disk->queue)) + atomic64_add(nr_sectors, &bdev->bd_disk->sync_io); } static inline void md_sync_acct_bio(struct bio *bio, unsigned long nr_sectors) diff --git a/drivers/md/md.c b/drivers/md/md.c index a6829ea5b560..b56614eae8dc 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -8502,6 +8502,10 @@ static int is_mddev_idle(struct mddev *mddev, int init) rcu_read_lock(); rdev_for_each_rcu(rdev, mddev) { struct gendisk *disk = rdev->bdev->bd_disk; + + if (!blk_queue_io_stat(disk->queue)) + continue; + curr_events = (long long)part_stat_read_accum(disk->part0, sectors) - atomic64_read(&disk->sync_io);