diff mbox series

[8/8] platform/x86/intel/pmc: Add missing extern

Message ID 20231223032548.1680738-9-david.e.box@linux.intel.com
State New
Headers
Series Intel PMC Core GBE LTR regression fix |

Commit Message

David E. Box Dec. 23, 2023, 3:25 a.m. UTC 
  Add missing extern for tgl_h_reg_map. Fixes sparse warning:

  drivers/platform/x86/intel/pmc/tgl.c:213:26: warning: symbol 'tgl_h_reg_map' was not declared. Should it be static?

Fixes: 544f7b7f651c ("platform/x86/intel/pmc: Add regmap for Tiger Lake H PCH")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
 drivers/platform/x86/intel/pmc/core.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Hans de Goede Jan. 2, 2024, 12:24 p.m. UTC | #1 
Hi,

On 12/23/23 04:25, David E. Box wrote:
> Add missing extern for tgl_h_reg_map. Fixes sparse warning:
> 
>   drivers/platform/x86/intel/pmc/tgl.c:213:26: warning: symbol 'tgl_h_reg_map' was not declared. Should it be static?
> 
> Fixes: 544f7b7f651c ("platform/x86/intel/pmc: Add regmap for Tiger Lake H PCH")
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/intel/pmc/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
> index ce7b1cd2b194..2a797fccf5e6 100644
> --- a/drivers/platform/x86/intel/pmc/core.h
> +++ b/drivers/platform/x86/intel/pmc/core.h
> @@ -452,6 +452,7 @@ extern const struct pmc_bit_map tgl_vnn_misc_status_map[];
>  extern const struct pmc_bit_map tgl_signal_status_map[];
>  extern const struct pmc_bit_map *tgl_lpm_maps[];
>  extern const struct pmc_reg_map tgl_reg_map;
> +extern const struct pmc_reg_map tgl_h_reg_map;
>  extern const struct pmc_bit_map adl_pfear_map[];
>  extern const struct pmc_bit_map *ext_adl_pfear_map[];
>  extern const struct pmc_bit_map adl_ltr_show_map[];
diff mbox series

Patch

diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
index ce7b1cd2b194..2a797fccf5e6 100644
--- a/drivers/platform/x86/intel/pmc/core.h
+++ b/drivers/platform/x86/intel/pmc/core.h
@@ -452,6 +452,7 @@  extern const struct pmc_bit_map tgl_vnn_misc_status_map[];
 extern const struct pmc_bit_map tgl_signal_status_map[];
 extern const struct pmc_bit_map *tgl_lpm_maps[];
 extern const struct pmc_reg_map tgl_reg_map;
+extern const struct pmc_reg_map tgl_h_reg_map;
 extern const struct pmc_bit_map adl_pfear_map[];
 extern const struct pmc_bit_map *ext_adl_pfear_map[];
 extern const struct pmc_bit_map adl_ltr_show_map[];