From patchwork Fri Dec 22 17:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Bee X-Patchwork-Id: 182751 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1225922dyi; Fri, 22 Dec 2023 09:49:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IE91ZnIE88Iw4mcGjBot/tjvxtYIsrVOhpmKySTzdEWAZx+8KIufxVtdaCiZB0yKMLhdX8n X-Received: by 2002:a17:906:2929:b0:a17:f7ca:b375 with SMTP id v9-20020a170906292900b00a17f7cab375mr812549ejd.0.1703267372133; Fri, 22 Dec 2023 09:49:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703267372; cv=none; d=google.com; s=arc-20160816; b=Kmvj5MVpzOwsHK6VtStQ48duJqEu/hrv09GAY2LGDu/ScLg6yAju8kreQnp2xNysDr JULcVT0ePZW1cgJOTUpawoi0Z0PmJ79laVmvrNc7CG2UN/vx3pIqRwGCguhf53O+pAhO /OsLRLK+z6QeG1lTMX4WUvr+03pac5glh6ySsp8xEoi4ckH56oZOd3KJefmHDkteUxfx ZfQ8vcpjp6muh/rL+QEeIZc1vM45FTfKvyOgbO5xZb4EzTFlWKha7v5Pl+B6OvbyUQc8 Ihb7LDXGCdu1ILJZGAuwV4dEbKDPNfNhDM5UkCZOX/D5aL436mc/J6e891Esak6Tn0tj rjKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=34BUg2B4LjsKRfrLMHkMQRe61oTuxBkBwcQpvuibjEM=; fh=k7ZhfSDxugAUNAX9PFQjqQnTRGZ+rgCl5CN8/TdzbyU=; b=Zou6T0isIR2606II9FcNCuWUgSQ8Bsvt0tmOi50AUDjBD9y+1YdBHDgyxRRQHbp/0d 8Tlz7RFGeAUzuM64d1rFqbbfyj0yUqASOxOKu1a9ntBv8P+ohtDwbMGpCSUGM2ZFAeNz 6NMlUOOruqfMRA6sU0j09SOg6T2aFOsy8nTBhHITwIRkcynNbN6aNXXJ02wUHKzyBHy3 b1lR/Prr09RsZLb39m+yTNfFIUA9KaGenZqBXJWyxDMnRPtx0l523bc6mxxEgZupSjbz D/jPuewA2vobUp2qtJ/XKIAmLaLp4+7NUXNvlTIbcMP1NmcfxxzXQPvw1ln5LStWGPa8 ajgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=SJ87EL41; spf=pass (google.com: domain of linux-kernel+bounces-9975-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9975-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id o9-20020a17090637c900b00a26a9598d51si1639725ejc.41.2023.12.22.09.49.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 09:49:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9975-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=SJ87EL41; spf=pass (google.com: domain of linux-kernel+bounces-9975-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9975-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BE9401F23C98 for ; Fri, 22 Dec 2023 17:49:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64C034CE06; Fri, 22 Dec 2023 17:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SJ87EL41" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5717928E18; Fri, 22 Dec 2023 17:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-336746c7b6dso1673345f8f.0; Fri, 22 Dec 2023 09:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703266960; x=1703871760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=34BUg2B4LjsKRfrLMHkMQRe61oTuxBkBwcQpvuibjEM=; b=SJ87EL41OA5aeB5Cl2TcRdpScY2Jw00p35WdvucvXNM8p0PaVhHaUyPK1JylutDivR g7paADpEd0BYGaMvFkZyWi1LE/hVd8piPl3EvfkwsZzO2aAnB30CBPlwqpY5acSnOhIz I2w4U33YeNKUZMV6ZJvIDi1bSBEC1tdga5OZZQW2rvHzdNayKZB/zG1S2UX/kYVYFX3G nz6PSBVe/EBkje8hz4vj/PB0fftr3EvkYlVXRJlNionyx2z9eGnjWhlwo7E8O7luHJ0m ft3KJZ7VrQDjlOkFXvnqtuYY9gTlYFcNUkMhj5txFlFabJr8AogliQ0Qcl3Fo7InkK7j Cz4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703266960; x=1703871760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=34BUg2B4LjsKRfrLMHkMQRe61oTuxBkBwcQpvuibjEM=; b=syyRLyhMeRluHZao7LKg9RqwN+3Fy/5b3cqZ/UdvVMVLyk+wNw0Bvb16t3t/stcoj8 DIjYGzHY8i2c+qop+9LAAzskxHhxZ8I7ddPYfYukABT/tnFEdX3gPYOfcb9cAB8KLSeX gQdPhHOc7s1DmmRicAaTprx0xMhr4U2vfsgNyGBA21+Eaa60jD+D7OjyJk+7KdsoLlAv qLjk12NvKPPjtmCaxAi86tm3CdsBDSGuDh8fR+Dtp0KlU4iuMYHZa4anyW46lH4RdYKi l7cHaKvJvYE/ousOLnxzW0XkNDugGcdhjj2tFYo5vAJU85eAnmEBDSXXU+oFWMQ+QUVm sC8Q== X-Gm-Message-State: AOJu0YzIENrS9LTYp6LsWQB+RjuZyGmeIbDzCdfDC1txabuG2SbxVFwP 8H9RAGCvfUZ5r6mG0Pn2bDdYWoXW0g== X-Received: by 2002:adf:e7c7:0:b0:336:619f:4647 with SMTP id e7-20020adfe7c7000000b00336619f4647mr905229wrn.108.1703266960737; Fri, 22 Dec 2023 09:42:40 -0800 (PST) Received: from U4.lan ([2a02:810b:f40:4300:f3ae:2788:7e03:f44]) by smtp.gmail.com with ESMTPSA id w10-20020adfec4a000000b00336670abdcasm4777116wrn.40.2023.12.22.09.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 09:42:40 -0800 (PST) From: Alex Bee To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Alex Bee Subject: [PATCH v4 26/29] drm/rockchip: inno_hdmi: Drop custom fill_modes hook Date: Fri, 22 Dec 2023 18:42:17 +0100 Message-ID: <20231222174220.55249-27-knaerzche@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231222174220.55249-1-knaerzche@gmail.com> References: <20231222174220.55249-1-knaerzche@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786005288424567797 X-GMAIL-MSGID: 1786005288424567797 Now that we have proper pixelclock-based mode validation we can drop the custom fill_modes hook. CRTC size validation for the display controller has been added with Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to hardware capabilities") Signed-off-by: Alex Bee Reviewed-by: Maxime Ripard --- changes in v2: - no changes changes in v3: - collect RB changes in v4: - none drivers/gpu/drm/rockchip/inno_hdmi.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index a074451a0c49..d7453c36d37a 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -630,13 +630,6 @@ inno_hdmi_connector_mode_valid(struct drm_connector *connector, return inno_hdmi_display_mode_valid(hdmi, mode); } -static int -inno_hdmi_probe_single_connector_modes(struct drm_connector *connector, - uint32_t maxX, uint32_t maxY) -{ - return drm_helper_probe_single_connector_modes(connector, 1920, 1080); -} - static void inno_hdmi_connector_destroy(struct drm_connector *connector) { drm_connector_unregister(connector); @@ -695,7 +688,7 @@ inno_hdmi_connector_duplicate_state(struct drm_connector *connector) } static const struct drm_connector_funcs inno_hdmi_connector_funcs = { - .fill_modes = inno_hdmi_probe_single_connector_modes, + .fill_modes = drm_helper_probe_single_connector_modes, .detect = inno_hdmi_connector_detect, .destroy = inno_hdmi_connector_destroy, .reset = inno_hdmi_connector_reset,