Message ID | 20231221132400.1601991-22-dhowells@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-8465-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp413187dyi; Thu, 21 Dec 2023 05:36:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8JV15EH/FPaz4mtPxZCn6nZG7IlMIc3fZDZCHeVkJiVh1Cr42Wrup8KUgqkZqMGOR/g/M X-Received: by 2002:a17:907:90d8:b0:a23:5f5f:cb94 with SMTP id gk24-20020a17090790d800b00a235f5fcb94mr3171725ejb.47.1703165770083; Thu, 21 Dec 2023 05:36:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703165770; cv=none; d=google.com; s=arc-20160816; b=kBMl+tvMudPYmTPx22FZWh/vSTl209iEIgfdamEYNAtVdE9mVedspx6CcL2W54cjcz x8DPPGd80bChpz7wAw4+UptGNK4ouF8pn223B+S31Id2hv4hizL2cyqZywgWfJ3izoB9 +C8ZdO5LtUKxoj9q/hA8y1EfwqwHFvl81ozStKX85qqEl4FS5JLXybqqTIs34dNtexYv DvojZbCjWSX1YPwT7lvXWYbQrXskfTWemiYXhDnNW2nQ9MSHKXCpVDbBcJMoEZUG8sFr gZNtqNgvOFAxvBhzt6jZRe5x6NvAyhdaMusQVuKRZd0Ybd7UuUufWWwso44mwYn0UjZc BzSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=U/y+xm2N9V1erDz4QIGlE5zRDPNtyRW7a99pDjZCrtc=; fh=ib4gl95HfLmZdfX9QIMf3rTepWCH9JlNymcDKJTPhJg=; b=iEtdzBqtVe2yi3KjIpFCQbD0bNKTJRYwYL77r8XXKleO+AUOrKJRWVs8neFqu8SUjt Ar9SafjbVE7Cr/R/tqFVogEaY0PH54hh8aVCKARUztJeT96XTSoknWlU7aoEk0PkSuIo X6Em6R1T6lcx33uZnOOageMQMAo83XQFqaaFYpV21DWnF3XqOi1mZU9vYMNkqTZ7smBf sgSD4p5ex+zoe0nBOZi182HqkmDWXeDArmqkEnos81loQpeDJ9sw8hwuQSarK+2gWPhD MnjPooWT+Fe8g3z7wEmItcVeT7r+kFcTDWyhRCYz1yEoPjo4ahgwvXwjGMS1wI6a0/xS x8QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QzQ54kLQ; spf=pass (google.com: domain of linux-kernel+bounces-8465-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8465-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e22-20020a170906045600b00a1d5063b024si864799eja.720.2023.12.21.05.36.09 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 05:36:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8465-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QzQ54kLQ; spf=pass (google.com: domain of linux-kernel+bounces-8465-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8465-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B1E491F2148A for <ouuuleilei@gmail.com>; Thu, 21 Dec 2023 13:36:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA46180E0B; Thu, 21 Dec 2023 13:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QzQ54kLQ" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60A5580560 for <linux-kernel@vger.kernel.org>; Thu, 21 Dec 2023 13:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703165131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U/y+xm2N9V1erDz4QIGlE5zRDPNtyRW7a99pDjZCrtc=; b=QzQ54kLQtdTEXkZNA9HXyQ3LXtJG0/JbTEv9R/YXP1S+kuKlXYvIsMZkE0EoTjMAKsspFD TDj0dBlzMJTmeyP0D6/QkLsTgcw3dRZgR666Rj60g7kdL2UjHp56AWhYx6HWxZf5kLNHEb 7O4Ysu6FmzcKCherTm6Cwd+cn0g9nII= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-9pjKgx18P2eV28IFZ7u4ow-1; Thu, 21 Dec 2023 08:25:27 -0500 X-MC-Unique: 9pjKgx18P2eV28IFZ7u4ow-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A30185A58B; Thu, 21 Dec 2023 13:25:26 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.39.195.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6425F51D5; Thu, 21 Dec 2023 13:25:23 +0000 (UTC) From: David Howells <dhowells@redhat.com> To: Jeff Layton <jlayton@kernel.org>, Steve French <smfrench@gmail.com> Cc: David Howells <dhowells@redhat.com>, Matthew Wilcox <willy@infradead.org>, Marc Dionne <marc.dionne@auristor.com>, Paulo Alcantara <pc@manguebit.com>, Shyam Prasad N <sprasad@microsoft.com>, Tom Talpey <tom@talpey.com>, Dominique Martinet <asmadeus@codewreck.org>, Eric Van Hensbergen <ericvh@kernel.org>, Ilya Dryomov <idryomov@gmail.com>, Christian Brauner <christian@brauner.io>, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 21/40] netfs: Make netfs_put_request() handle a NULL pointer Date: Thu, 21 Dec 2023 13:23:16 +0000 Message-ID: <20231221132400.1601991-22-dhowells@redhat.com> In-Reply-To: <20231221132400.1601991-1-dhowells@redhat.com> References: <20231221132400.1601991-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785898750370559459 X-GMAIL-MSGID: 1785898750370559459 |
Series |
netfs, afs, 9p: Delegate high-level I/O to netfslib
|
|
Commit Message
David Howells
Dec. 21, 2023, 1:23 p.m. UTC
Make netfs_put_request() just return if given a NULL request pointer. Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/objects.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c index 65a17dd4ab49..3aa0bfbc04ec 100644 --- a/fs/netfs/objects.c +++ b/fs/netfs/objects.c @@ -106,19 +106,22 @@ static void netfs_free_request(struct work_struct *work) void netfs_put_request(struct netfs_io_request *rreq, bool was_async, enum netfs_rreq_ref_trace what) { - unsigned int debug_id = rreq->debug_id; + unsigned int debug_id; bool dead; int r; - dead = __refcount_dec_and_test(&rreq->ref, &r); - trace_netfs_rreq_ref(debug_id, r - 1, what); - if (dead) { - if (was_async) { - rreq->work.func = netfs_free_request; - if (!queue_work(system_unbound_wq, &rreq->work)) - BUG(); - } else { - netfs_free_request(&rreq->work); + if (rreq) { + debug_id = rreq->debug_id; + dead = __refcount_dec_and_test(&rreq->ref, &r); + trace_netfs_rreq_ref(debug_id, r - 1, what); + if (dead) { + if (was_async) { + rreq->work.func = netfs_free_request; + if (!queue_work(system_unbound_wq, &rreq->work)) + BUG(); + } else { + netfs_free_request(&rreq->work); + } } } }