From patchwork Thu Dec 21 08:51:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gan, Yi Fang" X-Patchwork-Id: 182059 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp275775dyi; Thu, 21 Dec 2023 00:56:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGGjDJpG2JOrnGhdYY/pPQZB9bhK99Wbdk1z1MYLcZXLPh6maBhBCeWKjq+qbat3yVGG0i X-Received: by 2002:a05:6214:d4f:b0:67f:889a:a9a3 with SMTP id 15-20020a0562140d4f00b0067f889aa9a3mr160146qvr.82.1703148966794; Thu, 21 Dec 2023 00:56:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703148966; cv=none; d=google.com; s=arc-20160816; b=HUO6sF4ITvi8H/I0KRMG5awGSFk7ANDDpUUJB97b3vGr4EqhkwPc/1kN/PAZeh80Zy FDs9HXd9NGDweaBHxe+GbPjRzg+lM5YX0MLqdGg10iNwe05IYtrjU8U9jhjYX8CLbnil C0MEORja8Z0TM02HTD2nGwtUagTNqjMc1gsTtt0yIQ2P3LlFE68xbHCUeMrUFviWAO8G C8ixjFtZlKWyQhg3NxvQrBszdPGsokYtnDBtQJLysg0wzHjCe5F/VFfrZj9MKwl+1htu QNIhF1eYclpqNPCL/eIR8VWHCVApZyTaT6rk3iggci9fxWs/+ojB6/Tv9v7wsyq/NBYu OT9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=WtNeJHaG2+u6itwvw6SQ1Nweil/QWpwKG7cjZG9twDI=; fh=JhCqbF4gKBTnfq5pCBXWHsT+mGI+wlxAlh9egES2Iko=; b=VYz+/8Nx+Ct5IfGoy7S47MIAPcqDQp7ZaFLj5httcBdnFfZC1FJLJLW/gWoZpzJBqn Ylha63A5x2FA5gTX+mg+ZxhzYKLH+iPnJ9Cb95MB+etsanREYZ8hnTfPl0lDOBcGuI3M mzGzIxtSssu7+pTYG2eAZw7abrx+4PKop5kzVj9X5AqUnjW8fzWUOGhrbhv2N0WD2jWv L423opcfK76NpGxZpGCr6BLdZZrU4Zswet8J67+lS/Me34XHUi64lnVPBXbwxreffIEy eI2GQj1NJLizACZjqaD/l2pr3N7MYkSFKVlpqZufllGqn6nClh3Sn84cZN8p8AwU90zC fgaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d7SM2IT5; spf=pass (google.com: domain of linux-kernel+bounces-8026-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8026-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v9-20020a0c8e09000000b0067f57e10b34si1631361qvb.595.2023.12.21.00.56.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 00:56:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8026-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d7SM2IT5; spf=pass (google.com: domain of linux-kernel+bounces-8026-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8026-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9296C1C21A73 for ; Thu, 21 Dec 2023 08:56:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D166640C1E; Thu, 21 Dec 2023 08:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="d7SM2IT5" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF568405D0; Thu, 21 Dec 2023 08:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703148888; x=1734684888; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1JsXbGf0ei8NX9i8T+iRqjYzH4+nfdAl4Vq6Pu5B8C0=; b=d7SM2IT5KxNyNvF0TewpWFy/x+/l5VzHs+oE5p7bXyoj9lvXOdsSTOBj 6VWW4HlrAubmKtQWolHFUUYxpBn8bGgm4ghq5SQsKuKkNbgmqB4b7ecs0 GNxweNqr/O6+OHed1/H/SsDyAyK6sM7vXxCkYzI6aAbxt0qwH8mcXV63m bQvGUBYAhz2GKhKXqRvKGUA5PpkiIA/+HFBOOn+AMlYZB3KjaCynb84qe gZmApuM6Y17qcFMe96Z9yyrCIIVg6NG5JiYI+hbEHN/OdPvw+FlaJCvtn NXCsndYvWiUZrNG5QRY7B0fj0NEqZK/0LccMmWsrUNz7z6Fm1z8sDTlQD w==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="2793718" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="2793718" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 00:54:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="842568348" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="842568348" Received: from ssid-ilbpg3-teeminta.png.intel.com (HELO localhost.localdomain) ([10.88.227.74]) by fmsmga008.fm.intel.com with ESMTP; 21 Dec 2023 00:54:41 -0800 From: "Gan, Yi Fang" To: Greg Kroah-Hartman , Andrew Halaney , Javier Martinez Canillas , John Stultz , "Rafael J . Wysocki" , Gan Yi Fang , Jens Axboe , Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?q?Marek_Beh=C3=BAn?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Looi Hong Aun , Voon Weifeng , Song Yoong Siang , Lai Peter Jun Ann , Choong Yong Liang Subject: [PATCH net v2 2/2] net: phylink: Add module_exit_stub() Date: Thu, 21 Dec 2023 16:51:09 +0800 Message-Id: <20231221085109.2830794-3-yi.fang.gan@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231221085109.2830794-1-yi.fang.gan@intel.com> References: <20231221085109.2830794-1-yi.fang.gan@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785881131096415289 X-GMAIL-MSGID: 1785881131096415289 In delete_module(), if mod->init callback is defined but mod->exit callback is not defined, it will assume the module cannot be removed and return EBUSY. The module_exit() is missing from current phylink module drive causing failure while unloading it. Add module_exit_stub() in phylink for the module to be unloadable. Fixes: eca68a3c7d05 ("net: phylink: pass supported host PHY interface modes to phylib for SFP's PHYs") Cc: # 6.1+ Signed-off-by: Gan, Yi Fang --- drivers/net/phy/phylink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 25c19496a336..823c9b43cd92 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -3725,6 +3725,7 @@ static int __init phylink_init(void) } module_init(phylink_init); +module_exit_stub(phylink); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("phylink models the MAC to optional PHY connection");