From patchwork Thu Dec 21 19:09:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 182425 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp632543dyi; Thu, 21 Dec 2023 11:13:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjVG1RFrbQJga9e/FBkTKEXiFmTW22AHm6sU7PDC2DAp9YeCy+fMx5WMwr4wD6lugR8wTJ X-Received: by 2002:a05:6a00:4b51:b0:6d9:35c3:e7b2 with SMTP id kr17-20020a056a004b5100b006d935c3e7b2mr178915pfb.11.1703185982620; Thu, 21 Dec 2023 11:13:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703185982; cv=none; d=google.com; s=arc-20160816; b=RiT7Qx3MFe9EgCuVcbQmIuRZM7LjySzKFOpnnX+EJL3o9R5XsrgN7vl1AoDGU07Ewe uoYAjZZPO5thUt1eclQkmdKM0ZtK77feifr7EYmdZ30ClT38IxDokvQLI8gM9Dq28Ms8 EI1jnDsu3WnyzGNHBD4Tx+ISyIO4HSCwgKMsVRlnV4YKGkfDRiBLMx4dUpSH8z/WUCep 3riIX2alVDeZ10gzK7RoWRtrK3lhTjO5p1i7Nftz6TQQXwbvwnTn4iNyuUHU8syzS8uv J4gEf9PQPo0zS1JNwZnaUOgYhQqdjgFKjMK7nwjKOv17rNljXw1mE4Zm4cnjxr5hoMJ/ OSig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=xUUJuT608SRhCl6+0/SpXWAx7Kuk//nvBAACeA7YhJo=; fh=1ZbOLymucMpHPgAW6Ec0PFi2ApL0mTrRg5dRvTVPo8g=; b=O3qjtvm3S9ihwOp7rgmePRopAJBBqq8V8IpuDCxJiA/c0fACIXPjRQsyStxLH7W3XT AUqiiQy2UvhPyKvgz8otOkjum8GcOrepFOJltB2RRhzcCvC6S2yEl+XOVTP+cffedUEr R8y5iO4/pJayu75qOWilAFE69C0Y3fHJMQYNA57EQVXsgCyR9rqrCif7DtC0rwPlHxJF bCyc6oiTKWPM1y9rgLLQIjLEz/cgl0hcgOcb4qN4QlYnVafgagIDOxynEfBlD6hWks3u R9M5jTHLvmYkOWM1wedRy/j6dEU80/HjtmMy9vm8MB9LzdFRXBasrdzNTxqsiShDO8Z7 wn8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YhwbzY80; spf=pass (google.com: domain of linux-kernel+bounces-8984-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8984-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 11-20020a63104b000000b005c662419214si2037350pgq.229.2023.12.21.11.13.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:13:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8984-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YhwbzY80; spf=pass (google.com: domain of linux-kernel+bounces-8984-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8984-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3FD3B286843 for ; Thu, 21 Dec 2023 19:13:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A00E77F03; Thu, 21 Dec 2023 19:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YhwbzY80" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90E71697A6 for ; Thu, 21 Dec 2023 19:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703185865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xUUJuT608SRhCl6+0/SpXWAx7Kuk//nvBAACeA7YhJo=; b=YhwbzY80QbppRP6SpROhl81wCQTtvg8UhuB0sbOJC3nlUa6KwfW+XPYsP6jQDeLHr8Rgsa u9KWjf2xTmRF7ol3kazrGgkuvveQYuuiz9OQy9i5UbMc+ATYLWpgVFYm9sltyt9WnTtsfs 17Qe9pI+Gy0/sYnRwDSeoeFYg718mDg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-t7WcWc0bPM2BErT_4bApMw-1; Thu, 21 Dec 2023 14:11:03 -0500 X-MC-Unique: t7WcWc0bPM2BErT_4bApMw-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-78118a0bf69so137140585a.0 for ; Thu, 21 Dec 2023 11:11:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703185859; x=1703790659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xUUJuT608SRhCl6+0/SpXWAx7Kuk//nvBAACeA7YhJo=; b=PN8HQOvY5sPlqkdzYicq9Cl8tZuyXqE64Gq2ctLyoANvzDGfv5/tTX8BowrwaG9RPS T3nHMRYbyZ+yReq0+BJwcQ4L6PADZ34vszL7sEfNFMx3M5JTndZhdgTCO1UouAJSPKzs +WckXC14zZQ4zCaShTA8oXyqaJZyT0TfzzaGaXcCtZOQrfzi2T7lmaG3MQwWxKDGNUdk 0tz2QsByTZZTJxZeVol/0n76kyd9QW4TOk0yhXeh+GGc4yeCFyqTiNYJvUqC0EV7Ogn+ xo+PtSv6BlFL7sn+S65V3eyGT4vxQagDXob/54JAIAc3L0vYdcgsWl+6NVnlcGQwXH7A xL0Q== X-Gm-Message-State: AOJu0YyudVQB3m93Xt2eSPHmOC7QiRMux7d9anNz6ORATJ2CCL7hNYrL gHyEmtLSzpGvUXGg07xIOr9XJE9z17B3jefNgrWsfJvr8ud/vwFGyr7FgqKprBm9rdFWahS2mkH xD8zau+CdlsbULwJSy6sDEPWMrgaFDHvQ X-Received: by 2002:ae9:e00e:0:b0:781:1a4a:584f with SMTP id m14-20020ae9e00e000000b007811a4a584fmr318117qkk.120.1703185859664; Thu, 21 Dec 2023 11:10:59 -0800 (PST) X-Received: by 2002:ae9:e00e:0:b0:781:1a4a:584f with SMTP id m14-20020ae9e00e000000b007811a4a584fmr318097qkk.120.1703185859419; Thu, 21 Dec 2023 11:10:59 -0800 (PST) Received: from fedora.redhat.com ([2600:1700:1ff0:d0e0::37]) by smtp.gmail.com with ESMTPSA id 25-20020a05620a04d900b0077f0a4bd3c6sm846370qks.77.2023.12.21.11.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:10:56 -0800 (PST) From: Andrew Halaney To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Can Guo Cc: Andrew Halaney , Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC v3 07/11] scsi: ufs: core: Perform read back after writing UTP_TASK_REQ_LIST_BASE_H Date: Thu, 21 Dec 2023 13:09:53 -0600 Message-ID: <20231221-ufs-reset-ensure-effect-before-delay-v3-7-2195a1b66d2e@redhat.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> References: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.12.3 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785919945114952777 X-GMAIL-MSGID: 1785919945114952777 Currently, the UTP_TASK_REQ_LIST_BASE_L/UTP_TASK_REQ_LIST_BASE_H regs are written to and then completed with an mb(). mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring these bits have taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure the bits hit the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: 88441a8d355d ("scsi: ufs: core: Add hibernation callbacks") Signed-off-by: Andrew Halaney Reviewed-by: Bart Van Assche Reviewed-by: Can Guo --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index d1e33328ff3f..7bfb556e5b8e 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -10351,7 +10351,7 @@ int ufshcd_system_restore(struct device *dev) * are updated with the latest queue addresses. Only after * updating these addresses, we can queue the new commands. */ - mb(); + ufshcd_readl(hba, REG_UTP_TASK_REQ_LIST_BASE_H); /* Resuming from hibernate, assume that link was OFF */ ufshcd_set_link_off(hba);