From patchwork Thu Dec 21 19:09:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 182423 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp632121dyi; Thu, 21 Dec 2023 11:12:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IG868iJPfcMluQYzMkVJVmfmzKbTUIo4j0AqGXcqhcVpuCikySqa4QDDu6ad9jh1UYQ+u6/ X-Received: by 2002:ad4:5747:0:b0:67f:4653:1b5c with SMTP id q7-20020ad45747000000b0067f46531b5cmr199881qvx.19.1703185936095; Thu, 21 Dec 2023 11:12:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703185936; cv=none; d=google.com; s=arc-20160816; b=laLYhO5uOUojhO80tTAQdlNxia7lgzgnQBdKxpVCrwkiochSlNaTnwh/VE4ogTpl+F AS3+KlijMUyeS3twh0wmAuzv7tFZCN3wI5rh8eA1RTQvCvDmBlWWt1Kcq3TJYA1z7j2R usOWkW5jznEh+UPjmvIyEu7D+Zl7/IAHhHxa7W+VECRqg6LgOKv37AgX6NF4WcfQGtpt kAdXmM6sFMA/qN8rCJbpVTFqWOtQqhnsjFacYTmb/4xKkX0NFqnJKSrTOCnqSE0sMFcG UKnVHEil3QQhPTQafV4PrzQJ4cCEVJNaDzASu4Uz04XGYDS0topsFnn58wRq+s5iJMeb ENVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=oX0CWwSSb/xcfXKSUEFguRgCx8LqXafuU1W5XbBtf6I=; fh=1ZbOLymucMpHPgAW6Ec0PFi2ApL0mTrRg5dRvTVPo8g=; b=fKF448h0k2h1EMIdvrbyZi+6oE5bQfBe+JxpnrSF1zBq8NKogDsquDZaFCLyG+wU42 V/9V6YcIZAyWTPzzktMhQR2b6LpfnRoFHMX9UbNxPVoAiZXajfath4w4+wYF8MIF/XG+ 7eV0WaAy1pzp6Rcqv40VugOnC2JtVdFdkbbXRqnkBUpbjgf8Rc51wWaxAl3ZWd5ke6XD 1IQvilPQKNU8t+D+JETzOMRl4lsZ5amVnjXePtBpXetlA4sUUU0xdx4noGi6p1fZxQQo BCQRKZPH9STHUkS51S5cFz2YLB3M0GD39qg99AckwrgL8/EHzc/wRMMEoxga8dwQ5bni mE0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UN4fTdHd; spf=pass (google.com: domain of linux-kernel+bounces-8982-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8982-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g13-20020a0ce4cd000000b0067f9111b539si447107qvm.506.2023.12.21.11.12.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:12:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8982-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UN4fTdHd; spf=pass (google.com: domain of linux-kernel+bounces-8982-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8982-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DC0861C23D5D for ; Thu, 21 Dec 2023 19:12:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29CCC76DC0; Thu, 21 Dec 2023 19:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UN4fTdHd" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D9EF76DA6 for ; Thu, 21 Dec 2023 19:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703185856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oX0CWwSSb/xcfXKSUEFguRgCx8LqXafuU1W5XbBtf6I=; b=UN4fTdHdMSca8LN5B1rtxO8eUr5Sx+EdFWIIT8owFUpMRE5F4IDH3sWshnYqfZoVfXsHqt iSNR8dlQwcRT9jv0QHNCt6+EZrRzU/8nMKck0dhsYdSwkxWKau5omYhmArca1egpF7rrI4 +vwhBNro8jc0Qm/aocHR0VLufPEVSDw= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-uysadmXcNMO9HK9bqpcOuw-1; Thu, 21 Dec 2023 14:10:54 -0500 X-MC-Unique: uysadmXcNMO9HK9bqpcOuw-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-781293a471fso24537885a.3 for ; Thu, 21 Dec 2023 11:10:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703185850; x=1703790650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oX0CWwSSb/xcfXKSUEFguRgCx8LqXafuU1W5XbBtf6I=; b=XcIBJIHLP0HtqM4e3dYTI1EQTGXP09aX69QuEPLnvg3FgIE5jQqnuSPUMuy8JbmQdn JlaFi6QduJQTUXPbTMoQXZBx/qirXneJIdUjZZC+7VcI2nXCZ0IHBhoN+zX8+0Cc/sDQ 5Hk5glulXZnTN05NW5QSn5lCwf7t1Ah7oSdkASCf3pqB+lJUxLcJXCGMyD4G+NkooOwY KnQlVGsBpQwcxxOt2TaPk+2qAlKnzpWRrSI06E5/YEsEnOpoHXEnOOV4hPyL9mM6rl3U W78NHjVWJy1/Urd+S0OJbrY3Lrq2rEesSlV6viG3iEUSlPTSDq5XNCGzES6FfMNTjW3h HF0g== X-Gm-Message-State: AOJu0Ywy5WMFK7raM69/8ERccOFccs0tTlg7p5inFOGqtFUF2tJ9dHVS yXDtm9r6lfy/qPLD0PbVgDyh7DRP5IEB1DqUJzAE4z0VYez2ipcXeyxgDPX7xxTtgqCRoqZ5IKq WtnjGnhkG/UP2e8zRj6xvCiRxNwRqQ+cg X-Received: by 2002:a05:620a:2914:b0:77f:92f:fcc0 with SMTP id m20-20020a05620a291400b0077f092ffcc0mr328946qkp.24.1703185850241; Thu, 21 Dec 2023 11:10:50 -0800 (PST) X-Received: by 2002:a05:620a:2914:b0:77f:92f:fcc0 with SMTP id m20-20020a05620a291400b0077f092ffcc0mr328927qkp.24.1703185849959; Thu, 21 Dec 2023 11:10:49 -0800 (PST) Received: from fedora.redhat.com ([2600:1700:1ff0:d0e0::37]) by smtp.gmail.com with ESMTPSA id 25-20020a05620a04d900b0077f0a4bd3c6sm846370qks.77.2023.12.21.11.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:10:48 -0800 (PST) From: Andrew Halaney To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Can Guo Cc: Andrew Halaney , Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC v3 05/11] scsi: ufs: qcom: Perform read back after writing CGC enable Date: Thu, 21 Dec 2023 13:09:51 -0600 Message-ID: <20231221-ufs-reset-ensure-effect-before-delay-v3-5-2195a1b66d2e@redhat.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> References: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.12.3 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785919896262222889 X-GMAIL-MSGID: 1785919896262222889 Currently, the CGC enable bit is written and then an mb() is used to ensure that completes before continuing. mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring this bit has taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure the bit hits the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: 81c0fc51b7a7 ("ufs-qcom: add support for Qualcomm Technologies Inc platforms") Signed-off-by: Andrew Halaney Reviewed-by: Can Guo --- drivers/ufs/host/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index ab1ff7432d11..3db19591d008 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -409,7 +409,7 @@ static void ufs_qcom_enable_hw_clk_gating(struct ufs_hba *hba) REG_UFS_CFG2); /* Ensure that HW clock gating is enabled before next operations */ - mb(); + ufshcd_readl(hba, REG_UFS_CFG2); } static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba,