From patchwork Thu Dec 21 18:25:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 182393 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp606333dyi; Thu, 21 Dec 2023 10:27:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEA6aX5/qPHvofUXEvfwltUhU0dWomuJCURNZuGmDcbBsqjw/p/R8Tx3ATTy5Soi7wIHMuh X-Received: by 2002:aa7:8216:0:b0:6d9:39bf:2c3b with SMTP id k22-20020aa78216000000b006d939bf2c3bmr99375pfi.8.1703183276007; Thu, 21 Dec 2023 10:27:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703183275; cv=none; d=google.com; s=arc-20160816; b=kLGpKO61f1+RwfvIQsieMvCTLPGC1JoR5GA+rDpJA16h1Q1ajpuiX8KrYu3fbNgN+m gwi7G0EMiXtz5/dKf1urjdhKoYMx0W7ze50GwIG/yktz4mvrUoRkFN1rww2dDfPxN75v SuAifAjEjmL6RGuKK7J+XH7vo5hMTvue4/BMU9D2xSZ/SlfzBmJW0GbElf/JDPCS7I+h hQ73lPfRsrBtDu7OnBqXpvoX5gVtXl5zahlh+jhjGHUZohn+1+x1+GS4HKWVv7ExXGiY i5ISA0RrGggbEIQPtNf5nvZ0BrWxLSConRbuAB4qMgSslHe0jVB29bzPY4/zBMM/Vssy n05Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=hFXXGAQMvAtKWxVkRcpFMTchD2fzgAOU8dNzT5bz2Wo=; fh=04D4Yk3yOxJShnjvHS+/hsfQo1XzUk2+baHXEOLZllI=; b=Re1WM4iWvuuEmshWQDYXJKY2NuFy4taa4aRF4tF+5KZlqupjYea/cydQupC0ajFEXC NS98AOZIBwy2iR1A952ECzP0r/7zq1Tlp0jytcOpb5RcN0WcPNYgKToijk3l+fKWx8CK tu2UbPRqLVeIQyuxF5dqp7JJYALnDwcWAvMU/ENg2R5oDltrHqXkZLVyFGn8GG9L69jr unj0pt+uu79qVzslueMOC3ZeIrhmndsNHBzRKSsW29vqvRpA2V+7JiW7Kia/3e3F9e1h 8wypJrdvv81IdwDh0mUbHaa52XI6V6gIxINB6gd54v8aTl93GjMUZulegNNLODxR8bWV fYWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M3VjT6LK; spf=pass (google.com: domain of linux-kernel+bounces-8919-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8919-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k126-20020a633d84000000b005be1ee5be76si1914350pga.373.2023.12.21.10.27.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:27:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8919-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M3VjT6LK; spf=pass (google.com: domain of linux-kernel+bounces-8919-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8919-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E6DEC2864B9 for ; Thu, 21 Dec 2023 18:27:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2058376DAE; Thu, 21 Dec 2023 18:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M3VjT6LK" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44FCA64A9C for ; Thu, 21 Dec 2023 18:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703183150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hFXXGAQMvAtKWxVkRcpFMTchD2fzgAOU8dNzT5bz2Wo=; b=M3VjT6LKNaZ2dghsR40WOMnvGE3IbNJoHhBjWhzSwWQNFxzQoiZgZwL+rG4dIC1sFXdgRz 4TwWtGkrQUmZDxIWnqvzLZIRviYtpE67/s5uh22rxhcEGrksV/L/ptIt9H2tw2AFu1N/dv /LySG/p01J/Z2C9G7f6RpmQlkzSkVzA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-PW-9Qr6SO0q7_ZXIn_CE0w-1; Thu, 21 Dec 2023 13:25:49 -0500 X-MC-Unique: PW-9Qr6SO0q7_ZXIn_CE0w-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-67f7b69433dso16492066d6.1 for ; Thu, 21 Dec 2023 10:25:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703183145; x=1703787945; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hFXXGAQMvAtKWxVkRcpFMTchD2fzgAOU8dNzT5bz2Wo=; b=p/p0OjgQJORcLuhfbIBSsYfv78kz0BBoztqaIOWj3rZKCNnM9losJePOnH7FBsTS+E 7whhVzwdcKWhUUGGjl+j+Jj262WRF2jjAmmZx3ukGgCirUmP1vXdc6PSj3hTAqC5zJ+n N5IynpH8vmzhuGiLp5vYcOFNqvRlMC+Um1uKYjoAnMjzEyaJgopOx+xtsn1ofMdN7cPw oKzgK9KkyP8OLJEFav8Hp/hj2cHXxJdXURQgta6YX9w2OKsezwAgtcn5LTc98z6MkXqh IQ3PU+QXbDA4tGZrsDEHvTgczITuqXKA2WJKaXjvT1Uo5OMyfS26Kmm4zbelojs1E8Ha u//Q== X-Gm-Message-State: AOJu0YwWXqtgYOVn6q9b+Mx22qu/zMTi3bzLNkE0/oNRaQT1ebV5UW0L yXZnwzF+NoRea9TF0pzQkZyKMlhn7ieKFbnSnLM5T8urIfWpj9mpy5zyGSBWLmonTg2/krwkRt+ vIZzNhD2xf8Gd2+TEcpNaM8wmX39J3vO7 X-Received: by 2002:a05:6214:20e6:b0:67a:a721:caf4 with SMTP id 6-20020a05621420e600b0067aa721caf4mr120993qvk.85.1703183144895; Thu, 21 Dec 2023 10:25:44 -0800 (PST) X-Received: by 2002:a05:6214:20e6:b0:67a:a721:caf4 with SMTP id 6-20020a05621420e600b0067aa721caf4mr120983qvk.85.1703183144634; Thu, 21 Dec 2023 10:25:44 -0800 (PST) Received: from [192.168.1.163] ([2600:1700:1ff0:d0e0::37]) by smtp.gmail.com with ESMTPSA id da7-20020a05621408c700b0067f2c03d4adsm779605qvb.100.2023.12.21.10.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:25:44 -0800 (PST) From: Andrew Halaney Date: Thu, 21 Dec 2023 12:25:23 -0600 Subject: [PATCH RFC v2 06/11] scsi: ufs: cdns-pltfrm: Perform read back after writing HCLKDIV Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231221-ufs-reset-ensure-effect-before-delay-v2-6-75af2a9bae51@redhat.com> References: <20231221-ufs-reset-ensure-effect-before-delay-v2-0-75af2a9bae51@redhat.com> In-Reply-To: <20231221-ufs-reset-ensure-effect-before-delay-v2-0-75af2a9bae51@redhat.com> To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Yaniv Gardi , Dov Levenglick , Hannes Reinecke , Subhash Jadavani , Gilad Broner , Venkat Gopalakrishnan , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Anjana Hari , Dolev Raviv , Can Guo Cc: Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney X-Mailer: b4 0.12.3 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785917106843452923 X-GMAIL-MSGID: 1785917106843452923 Currently, HCLKDIV is written to and then completed with an mb(). mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring this bit has taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure the bit hits the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: d90996dae8e4 ("scsi: ufs: Add UFS platform driver for Cadence UFS") Signed-off-by: Andrew Halaney Reviewed-by: Manivannan Sadhasivam --- drivers/ufs/host/cdns-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/host/cdns-pltfrm.c b/drivers/ufs/host/cdns-pltfrm.c index bb30267da471..66811d8d1929 100644 --- a/drivers/ufs/host/cdns-pltfrm.c +++ b/drivers/ufs/host/cdns-pltfrm.c @@ -136,7 +136,7 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba) * Make sure the register was updated, * UniPro layer will not work with an incorrect value. */ - mb(); + ufshcd_readl(hba, CDNS_UFS_REG_HCLKDIV); return 0; }