From patchwork Wed Dec 20 23:17:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Luba X-Patchwork-Id: 181887 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp68569dyi; Wed, 20 Dec 2023 15:19:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsbR4Wvxe+D8IFp81kv/nYSRrpc6l6xE2ippjt/woJPqvNzXaEhxPCtPEwxdg7x0NJEcqR X-Received: by 2002:a05:6359:458e:b0:170:e927:f0c4 with SMTP id no14-20020a056359458e00b00170e927f0c4mr488572rwb.40.1703114373764; Wed, 20 Dec 2023 15:19:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703114373; cv=none; d=google.com; s=arc-20160816; b=S/Skibqn6+8yKM/Wv5hKZ92NlMOkD8I0x/kLtM3MpYRRoQWTKt0zwOe7ehl6d54P/T xMYEgWBrmiVA/wReg46PCZ8uOnlc3RXxFuSSVYq9MkczzBAoPfwGhlX/zx5IEb/7pV8s rb+2dePNs7FyfqxYwilHAcJngarQ4cnyhcZ4dW40FEKYJUGgfQ6cnR1/QUQXWBK7kGWa +oppN5QnE1bKe0ZhXjv5LdQqmLTmmTMbysAvOxDbfncn3ZXdJtBxtNNyU4teW5eMV0Qm sf6grf7punNeAxOXzMAhPQyi3MawXyDEsjDKIXYDMveO8t9mlrj7s530ygbQR/iUybSM RCzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ayV46MLdyPPdTFOCH9EhAyhS36YYlj+jH0rMkyh+vgM=; fh=BLXDRFxX5XTO46cEytehPgkEKhEpfPIIZAXbZsHkuJk=; b=zRUoAC+G+QjJyic3q+jyMc9X2/IkBwUskEicnTVudhpA0Oa8r/vN6pspGfc4qcf3wx TAYtO+rQARpHdN1Qt5u75KBc7SxKNQGG7zWJU4YZo5jwlKJCpplz9vBGXucLALReaa21 5xv0BqfB7JvPGB60wqIc8rROpezdJKoLrw4dBuhDeAevB3icI0K3o8hOBNHg3Y6bZPSf ajm3p3XbhXz+qfZYkEiQS/goysfRCK+NxKG/e0/3NA0fP4ruCb/Jeeg2oq6qD0CrJI2W Syw9+ARqnPM5C54w1V5WWvYwQgvWaVx9mWgct6gMMrvfg8LPRnv9kBVawMQMPQNQhaRG IWtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-7631-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7631-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u12-20020a0cdd0c000000b0067efca87267si791520qvk.520.2023.12.20.15.19.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 15:19:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7631-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-7631-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7631-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 64C8B1C24EDC for ; Wed, 20 Dec 2023 23:19:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1290B4D59C; Wed, 20 Dec 2023 23:17:10 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 597DB4A9BB; Wed, 20 Dec 2023 23:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F712152B; Wed, 20 Dec 2023 15:17:52 -0800 (PST) Received: from e129166.arm.com (unknown [10.57.82.217]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D54F43F64C; Wed, 20 Dec 2023 15:17:05 -0800 (PST) From: Lukasz Luba To: linux-kernel@vger.kernel.org, rafael@kernel.org Cc: linux-pm@vger.kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com Subject: [PATCH v3 9/9] thermal: gov_power_allocator: Support new update callback of weights Date: Wed, 20 Dec 2023 23:17:53 +0000 Message-Id: <20231220231753.1824364-10-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231220231753.1824364-1-lukasz.luba@arm.com> References: <20231220231753.1824364-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785844857604827979 X-GMAIL-MSGID: 1785844857604827979 When the thermal instance's weight is updated from the sysfs the governor update_tz() callback is triggered. Implement proper reaction to this event in the IPA, which would save CPU cycles spent in throttle(). This will speed-up the main throttle() IPA function and clean it up a bit. Signed-off-by: Lukasz Luba --- drivers/thermal/gov_power_allocator.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c index b5ec60ae7efd..7b6aa265ff6a 100644 --- a/drivers/thermal/gov_power_allocator.c +++ b/drivers/thermal/gov_power_allocator.c @@ -77,6 +77,7 @@ struct power_actor { * @trip_switch_on should be NULL. * @trip_max: last passive trip point of the thermal zone. The * temperature we are controlling for. + * @total_weight: Sum of all thermal instances weights * @num_actors: number of cooling devices supporting IPA callbacks * @buffer_size: internal buffer size, to avoid runtime re-calculation * @power: buffer for all power actors internal power information @@ -88,6 +89,7 @@ struct power_allocator_params { u32 sustainable_power; const struct thermal_trip *trip_switch_on; const struct thermal_trip *trip_max; + int total_weight; unsigned int num_actors; unsigned int buffer_size; struct power_actor *power; @@ -405,16 +407,11 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp) u32 total_granted_power = 0; u32 total_req_power = 0; u32 power_range, weight; - int total_weight = 0; int i = 0, ret; if (!num_actors) return -ENODEV; - list_for_each_entry(instance, &tz->thermal_instances, tz_node) - if (power_actor_is_valid(params, instance)) - total_weight += instance->weight; - /* Clean all buffers for new power estimations */ memset(power, 0, params->buffer_size); @@ -430,7 +427,7 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp) if (ret) continue; - if (!total_weight) + if (!params->total_weight) weight = 1 << FRAC_BITS; else weight = instance->weight; @@ -651,6 +648,12 @@ static void power_allocator_update_tz(struct thermal_zone_device *tz, allocate_actors_buffer(params, num_actors); break; + case THERMAL_INSTANCE_WEIGHT_CHANGED: + params->total_weight = 0; + list_for_each_entry(instance, &tz->thermal_instances, tz_node) + if (power_actor_is_valid(params, instance)) + params->total_weight += instance->weight; + break; default: break; }