Message ID | 20231220213615.1561528-10-Frank.Li@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-7465-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp25935dyi; Wed, 20 Dec 2023 13:40:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFo47uN/6H/xRL8YqPMELanfNADNG1wHUt4zV0UwAmVu7dJzwKlAIxUIhyMSHcMDFM53oay X-Received: by 2002:a05:651c:211f:b0:2cc:856e:68b8 with SMTP id a31-20020a05651c211f00b002cc856e68b8mr2004955ljq.21.1703108411674; Wed, 20 Dec 2023 13:40:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1703108411; cv=pass; d=google.com; s=arc-20160816; b=q4YDfARHG8Si7At4VyK3EAw+y+9Qo7BgazUls1ziksR6Pk4bUF8NmIb/isj2C3w5/D hgrW8fpM8Z0bHAmlxVQzywDJx09Sw80EsoL4AQbnghU3Cp3oWOZ8PLrDJSRIjqKAM/5E BPucsGJRVlbSZ1LWx6ad9thGA6PwOGPKV7veZmaJREShEVPn7e1x4ULEd3KiWa8KDYH4 m0Lwj+l5b3cp1RNVSwNLSXFsjj2xGau4C092ZS06YMVjArfLpLiVVPyDmz3sFSW9l7+X PMUqmr1r0fytIunpVevqTkp9Brqd8ckKb3iWslmod5TYvTn6ubVyimt/0OXv5b48eOd4 g2hA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :content-transfer-encoding:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=B+6bkDM41BMATE8rf6K8b34570DjVBKEO4VsaZXlmOA=; fh=CQLaCgSM4X/4YT6QnbTibZNcIYVoAMuNg8B/6V3sj4U=; b=p1IZf+BaSWYOYWkACRteZEm1u8eQISV78yzeI5uBu9BPkXMAfXsfiQproyBY0z/OO8 0okfgtY3vzvAkwBQvG7ilgenu+XB2oZ+2wAhXRuHgaSG0X/k4QLD88BW2cLXPmGURrd4 7Puq4DJtw6SkOAes2qDyXjWTLn1yWHC9aYFTe6XiLi30HUikAwHaoIYpomxvT7RZeoiH YQR9rxOjd1/OA9gG9GLHSakzAZXKPY1hihbzTM7pqs6cxQMY3dxH50vuBRnuINeF8ESo YPoac1L+q0Lxk3GssjH0Arh3CnNQxy/5SL86WGtk3uG3+fdOoUXJkeR01fUAPB1GNZg4 m83A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b="F5ZewZ/O"; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel+bounces-7465-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7465-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d25-20020a50cd59000000b005538fc8a3f1si188722edj.260.2023.12.20.13.40.11 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 13:40:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7465-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b="F5ZewZ/O"; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel+bounces-7465-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7465-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 220951F23668 for <ouuuleilei@gmail.com>; Wed, 20 Dec 2023 21:40:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B39F4C60A; Wed, 20 Dec 2023 21:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="F5ZewZ/O" X-Original-To: linux-kernel@vger.kernel.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64CDA4C3D2; Wed, 20 Dec 2023 21:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WF7zBrvTBc+AQybQIqCgG4Vbj+d9FYJks+fctoFI18Ioqd7LVQ6E7odxH8CFAs2NEqozLMgD5vuaHp5GWK6Bp/c4aYEvo81syiW6BUMKDQfvat/69vV6zmxkn8yRMsHq+JKkbE0ZbcT4fQsRokXUhnpFNxlfh0nKSMW7s/LLbhQeI1sLnYOiAgcZJWzEE5DAVqF7fzy/sfOP41gKkK6mLB+TvQSbMX40Wg8PdpQl5gTAs3frRqxl+P/cvhXJYw6NSyyfVF5SA3p5FUIk+zNGjyGrd4F/tD3N1KtIjY/K09ci/L3vJR/7pglJEuBwOVYYC08WCgmOUuCZmI2aRqls1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+6bkDM41BMATE8rf6K8b34570DjVBKEO4VsaZXlmOA=; b=Wy/ihCmQ8TfBnsppip5GvOWWTp4IJ8Dbifct9+Cqrzl9LR/ww16g8USwzNTaL6vN0g7dg5o0XABxL2vridQf+26YqFLH6qGAs8oXb92dcB41BBbVdTrcj7wlZ7Lmm1WHoepCtB2VAo8LE7tIacr/guh/J7bdm3pDG0k080cS0Wj/Xn3Eu8G9fItgEosSsfxQV/v6tvnDLIYiTUXf1EG/8YMQR3EZoQVy4T3gxp468kwv5KRCwwRGmRG8S0AzSLk9ckQaiG3BIMESsHnvPUYPC5OOqR8Tfp+ANR7xawOnxMDbJc9bX14brZzFuiKJAusbVfn7B0PIlHzcjkbuIr9uKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+6bkDM41BMATE8rf6K8b34570DjVBKEO4VsaZXlmOA=; b=F5ZewZ/O2iSE81EmYt6D5AQ6e8VZCmkEn3V95N0MNsfFvdhhGC9ivWn38MrUBrHhhRBfwag88KkEh3tdpRui4nVWaoW263n/tk7UpdifEAuuBDx6dBgPIf9A9B4VcPAnbK0d54ZW13xHk+HJG2+7SVktrMkYVsZv+97lvG97fDw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by DB8PR04MB6777.eurprd04.prod.outlook.com (2603:10a6:10:11f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20; Wed, 20 Dec 2023 21:37:28 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::95f5:5118:258f:ee40]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::95f5:5118:258f:ee40%7]) with mapi id 15.20.7113.019; Wed, 20 Dec 2023 21:37:28 +0000 From: Frank Li <Frank.Li@nxp.com> To: manivannan.sadhasivam@linaro.org Cc: Frank.Li@nxp.com, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: [PATCH v5 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Date: Wed, 20 Dec 2023 16:36:08 -0500 Message-Id: <20231220213615.1561528-10-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231220213615.1561528-1-Frank.Li@nxp.com> References: <20231220213615.1561528-1-Frank.Li@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: PH0PR07CA0110.namprd07.prod.outlook.com (2603:10b6:510:4::25) To AM0PR04MB4834.eurprd04.prod.outlook.com (2603:10a6:208:c8::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|DB8PR04MB6777:EE_ X-MS-Office365-Filtering-Correlation-Id: 324c6ce6-830e-4bfa-0728-08dc01a3dd26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nxsIJXMc7dr6fJ99/e95arGSw9B1jU637bDLZyDtFNN4cCkoaW+Hmykq2/Hryf1+oyEbvXqeQqHdVOCbtRQYLEY/Ier8Q3VQgjP6Z12or2490rrw20469PQfaDedHmDFLm6Zn/YYkQ8sSzxbPLZHjYZgmSgsY68wpkKzcEnEUoyICmRkIedLyLLAWh6sdi0U1z7kDmwmJrTKcIQ87ul5a+HIkR6VmCnywUj5mxs27WM0s9tt4GhJm+jKx3KZPmyq+PHazG5U2pKqco3ZWnFsr8Rn5Uv05iFFJSu7/Z/RsxMAx8FAYRDJLWKJZT7D35Rq4YZe/IsiSt6G9suuNFKPZlb9v1jGLJmEKMa+t9t+BdrMQpI+EpVfG+f1KAoU3HRWsr9z/ki0EuZt5K2TfCJIdlaVYrNV+9K9uMcyBhsebLK3AVpGDCFrLYoFk3TWbfJJzHsI3cug+y1JXISYQSUXFxUKuHyUJk9LhISB1jzMO4q6rOMcr04pCoVU9lb20DkiVqDMtZCklvtpSWweNvMub4LVk1dlEFUUsBlF17BeiqMQpI4TgrKrlj37nICmLgnAZJztIF6tzJtORRhgc6bHWZBSoCotDDYGIn96F5RR6sfhKQT9ve7u684Eln80f44J/PxOGWRckaDulWj8QGn/JA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(376002)(396003)(39860400002)(136003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(6486002)(6666004)(316002)(478600001)(6916009)(66476007)(66556008)(8676002)(8936002)(66946007)(83380400001)(6506007)(6512007)(52116002)(1076003)(26005)(2616005)(41300700001)(2906002)(7416002)(4744005)(4326008)(5660300002)(86362001)(38350700005)(36756003)(38100700002)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uNgskJpM3keDoLjsnEkL3Yr5bHMeRBYGHUl3uWpYSIyG/KU14yIyWPXnd4eXDjynjrXFbRlwV23wejCjBW/cFbvMG2vTSh7d5+40oLs0xIIgkDOxPJs+cwgLPEKDFyuKIyfD+M447hf/7JrjLe9yVQqmcJeAUOn0UkoXm7JsxDhwPaELC6s1Zx9Eyvf1Ju5pGqb4yXtYOn7yf4Nnrg79CAr31u0lbMGdWHmnit5BpKDN+ofUL2JDrFpt3QdEj02cZZQdUJfmKm5neqK7PQcT6SBYpJxJsxQevR/cBlM5Zzp/72S+lBFx43AAsShAXf1puCMdCFeQBwZV+2O60tkOYcSZrMfi2WT9b0/seZkHeG4viZQ8ojUTBsqNF340zpaQdFCULTYnm1XxsDOLqftvDe1TLLVNu7OaZB892Kono0om1si7W4RRt5ZZ3g0Z5obojb/sRkOHshAaOge5FX7M4fwBP3wFGhbu2cM8XUAMhp7aKUlMr/AyEvOXAYanxfFof+q7v0hNIhlRZj7/IaX7SLqnSpCcGjDk8p9Gp+XuQSF7mW91VzF9sXEl6KAtX94gllMM3lu44XuXlUqUy/cPTAAVZ2ploG2ZHXY1q182db6sTTgXQ8M2FSRZrlAykJS1lOIev0e8AQL2Rly/O3raA/ayC+7Ihk47Yzp6LTL3WxzFkg7pRivgbIipZEdg6bFznzcG/gEwb0DkvHkZf7eygZtTXHFFQJBvZ0DMuZWDeNadt2jYZ5RQslX3dvOD5SmCb/sfZ4HkvKv5nGgizji1+QAZDNkfWuXpocSpkV+PxH//VE7hC9XtiugM97ahcmbHSz3glt+5jfzJDTSapr2Td3aMW7h+/ctzaesFBQPxIktfVpS2ASzSm/Ge0g4aXDYpqFsqizrZdRMADLYL3gAN01dPeny3R6QFZOOFRMdeor6CaIpqRMpx3LMTtkKQf0/UM68hmll+UU7Am0DHI6ueZNpUIkWPTvdKNoS+fzIplDxof+bRAuUH8HOOLGaiepD+IlI6GE9gDyKLOAdWGNf9cEDT5LE1JpeSt6HlPkSvLIfK7JkVuywkBelu1vM6bb8E0iFxJVFnvl7CGa8tq43Xhf+PlFE7Z91gFImMQCNIva4pfngSvVYeg4Vh4MBGiUUVB+KdUByX29N5XCs4KhyQyCq5PGd1F8Ld+3cSaOfXpH/tBXB5eepfzXZv6RUPW1NnKitYvG+RVkmyRWMzCPAW9NxqHCrEJ4FV0vyuTjuINwGjHQJDvoC7DlSefqG/vE30m4a2SMPr/6/zUSUHsVAqmkjXeUG62nf50kSbUE4HulCLAuWnyd1y+R5VpoAIdA/x4jYZc65+joVlzyC2SbWctZfk3K+RkENPYW6RXHdy4PKGclZJBcNVdtuaNkUr9AtBqty5sVf8nB31A21jjCEyxOMVUF8UGgLCp3Dr9XdtjjNUhmpkR836Tp6rBNMhJ3b9ZjW0SKAasxrBtpFDRlENWdl+iceYJ0gynUoJtKy6cR5kqkUPNXyWWKXamuuZsj+2HyE//KLXobliApuArTSfuJdZGY4JeSnDKb6LXn3gRaU= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 324c6ce6-830e-4bfa-0728-08dc01a3dd26 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4834.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 21:37:28.4817 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1Gqb1Lc3UDHiqzJ+CCKNojmWeF63e/B99p0780RPgfOk1pzVL8u3htYxhnzLPefjMP7+PAHQqzJer2emQsKt2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6777 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785838605911572699 X-GMAIL-MSGID: 1785838605911572699 |
Series |
PCI: imx6: Clean up and add imx95 pci support
|
|
Commit Message
Frank Li
Dec. 20, 2023, 9:36 p.m. UTC
There are clocks and clock-names restriction for difference compatible
string. So needn't irrationality check again for clock's miniItems and
maxItems.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Notes:
Change from v1 to v4
- new patch at v4
.../bindings/pci/fsl,imx6q-pcie-common.yaml | 16 ----------------
1 file changed, 16 deletions(-)
Comments
On 20/12/2023 22:36, Frank Li wrote: > There are clocks and clock-names restriction for difference compatible > string. So needn't irrationality check again for clock's miniItems and > maxItems. That's not really true. Other entry does not restrict clocks and leave items quite flexible. These entries should be combined so all constraints are fixed for all variants. Best regards, Krzysztof
On Sat, Dec 23, 2023 at 07:42:12PM +0100, Krzysztof Kozlowski wrote: > On 20/12/2023 22:36, Frank Li wrote: > > There are clocks and clock-names restriction for difference compatible > > string. So needn't irrationality check again for clock's miniItems and > > maxItems. > > That's not really true. Other entry does not restrict clocks and leave > items quite flexible. These entries should be combined so all > constraints are fixed for all variants. There are 7 compatible string at pci/fsl,imx6q-pcie.yaml - fsl,imx6q-pcie - fsl,imx6sx-pcie - fsl,imx6qp-pcie - fsl,imx7d-pcie - fsl,imx8mq-pcie - fsl,imx8mm-pcie - fsl,imx8mp-pcie - fsl,imx95-pcie All 7 compatible string have check - if: properties: compatible: enum: - fsl,imx6sx-pcie ... - if: properties: compatible: enum: - fsl,imx8mq-pcie ... - if: properties: compatible: enum: - fsl,imx6q-pcie - fsl,imx6qp-pcie - fsl,imx7d-pcie ... - if: properties: compatible: enum: - fsl,imx8mm-pcie - fsl,imx8mp-pcie ... This check was not necessary at all. > > Best regards, > Krzysztof >
On 24/12/2023 05:43, Frank Li wrote: > On Sat, Dec 23, 2023 at 07:42:12PM +0100, Krzysztof Kozlowski wrote: >> On 20/12/2023 22:36, Frank Li wrote: >>> There are clocks and clock-names restriction for difference compatible >>> string. So needn't irrationality check again for clock's miniItems and >>> maxItems. >> >> That's not really true. Other entry does not restrict clocks and leave >> items quite flexible. These entries should be combined so all >> constraints are fixed for all variants. > > There are 7 compatible string at pci/fsl,imx6q-pcie.yaml Then explain it in the commit msg. The file you are touching has something entirely else. And what about -ep binding? Commit msg explains nothing here as well. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml index 8f39b4e6e8491..a284a27c5e873 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml @@ -150,22 +150,6 @@ allOf: - {} - const: pcie_phy - const: pcie_aux - - if: - properties: - compatible: - not: - contains: - enum: - - fsl,imx6sx-pcie - - fsl,imx8mq-pcie - - fsl,imx6sx-pcie-ep - - fsl,imx8mq-pcie-ep - then: - properties: - clocks: - maxItems: 3 - clock-names: - maxItems: 3 - if: properties: