diff mbox series

[v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support

Message ID 20231220113857.1127598-1-kshitiz.varshney@nxp.com
State New
Headers
Series [v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support |

Commit Message

Kshitiz Varshney Dec. 20, 2023, 11:38 a.m. UTC 
  Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

    Issue:-
    Multiple crypto tests like sm3, sm4 xctr and polyval failing.

    skcipher: failed to allocate transform for xctr(aes): -2
    alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
    alg: self-tests for sm3 using sm3 failed (rc=-2)
    tcrypt: failed to load transform for sm3: -2
    alg: hash: failed to allocate transform for polyval: -2
    alg: self-tests for polyval using polyval failed (rc=-2)

    Resolution:-
    Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
    CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
    sm3, sm4, aria, polyval & xctr.

    Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Gaurav Jain Jan. 3, 2024, 9:43 a.m. UTC | #1 
Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>

> -----Original Message-----
> From: Kshitiz Varshney <kshitiz.varshney@nxp.com>
> Sent: Wednesday, December 20, 2023 5:09 PM
> To: Herbert Xu <herbert@gondor.apana.org.au>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Fabio
> Estevam <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Varun Sethi
> <V.Sethi@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Sahil Malhotra <sahil.malhotra@nxp.com>; Vabhav
> Sharma <vabhav.sharma@nxp.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; Rahul Kumar Yadav
> <rahulkumar.yadav@nxp.com>; Nikhil Singla <nikhil.singla@nxp.com>
> Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Kshitiz
> Varshney <kshitiz.varshney@nxp.com>
> Subject: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher
> test support
> 
>     Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
> 
>     Issue:-
>     Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> 
>     skcipher: failed to allocate transform for xctr(aes): -2
>     alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
>     alg: self-tests for sm3 using sm3 failed (rc=-2)
>     tcrypt: failed to load transform for sm3: -2
>     alg: hash: failed to allocate transform for polyval: -2
>     alg: self-tests for polyval using polyval failed (rc=-2)
> 
>     Resolution:-
>     Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
>     CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support
> of
>     sm3, sm4, aria, polyval & xctr.
> 
>     Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> b/arch/arm/configs/imx_v6_v7_defconfig
> index 0a90583f9f01..627f57da9d5b 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
>  # CONFIG_SLUB_DEBUG is not set
>  # CONFIG_SCHED_DEBUG is not set
>  # CONFIG_FTRACE is not set
> +CONFIG_CRYPTO_HCTR2=m
> +CONFIG_CRYPTO_SM3_GENERIC=m
> +CONFIG_CRYPTO_SM4_GENERIC=m
> +CONFIG_CRYPTO_ARIA=m
> --
> 2.25.1
Kshitiz Varshney Jan. 16, 2024, 9:59 a.m. UTC | #2 
Hi Herbert,

Gentle Reminder.
Please help to merge the patch.

Regards,
Kshitiz

> -----Original Message-----
> From: Kshitiz Varshney <kshitiz.varshney@nxp.com>
> Sent: Wednesday, December 20, 2023 5:09 PM
> To: Herbert Xu <herbert@gondor.apana.org.au>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Fabio
> Estevam <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Varun Sethi
> <V.Sethi@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Sahil Malhotra <sahil.malhotra@nxp.com>;
> Vabhav Sharma <vabhav.sharma@nxp.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; Rahul Kumar Yadav
> <rahulkumar.yadav@nxp.com>; Nikhil Singla <nikhil.singla@nxp.com>
> Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Kshitiz
> Varshney <kshitiz.varshney@nxp.com>
> Subject: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr
> cipher test support
> 
>     Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
> 
>     Issue:-
>     Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> 
>     skcipher: failed to allocate transform for xctr(aes): -2
>     alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
>     alg: self-tests for sm3 using sm3 failed (rc=-2)
>     tcrypt: failed to load transform for sm3: -2
>     alg: hash: failed to allocate transform for polyval: -2
>     alg: self-tests for polyval using polyval failed (rc=-2)
> 
>     Resolution:-
>     Enabling CONFIG_CRYPTO_SM3_GENERIC,
> CONFIG_CRYPTO_SM4_GENERIC,
>     CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables
> support of
>     sm3, sm4, aria, polyval & xctr.
> 
>     Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> b/arch/arm/configs/imx_v6_v7_defconfig
> index 0a90583f9f01..627f57da9d5b 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
>  # CONFIG_SLUB_DEBUG is not set
>  # CONFIG_SCHED_DEBUG is not set
>  # CONFIG_FTRACE is not set
> +CONFIG_CRYPTO_HCTR2=m
> +CONFIG_CRYPTO_SM3_GENERIC=m
> +CONFIG_CRYPTO_SM4_GENERIC=m
> +CONFIG_CRYPTO_ARIA=m
> --
> 2.25.1
Fabio Estevam Jan. 16, 2024, 10:05 a.m. UTC | #3 
On Tue, Jan 16, 2024 at 6:59 AM Kshitiz Varshney
<kshitiz.varshney@nxp.com> wrote:
>
> Hi Herbert,
>
> Gentle Reminder.
> Please help to merge the patch.

This patch goes to Shawn's tree, not Herbert's.

We are currently in the merge window, so this change will likely be
applied after 6.8-rc1 is out.
Shawn Guo Feb. 3, 2024, 2:21 p.m. UTC | #4 
On Wed, Dec 20, 2023 at 12:38:57PM +0100, Kshitiz Varshney wrote:
>     Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
> 
>     Issue:-
>     Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> 
>     skcipher: failed to allocate transform for xctr(aes): -2
>     alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
>     alg: self-tests for sm3 using sm3 failed (rc=-2)
>     tcrypt: failed to load transform for sm3: -2
>     alg: hash: failed to allocate transform for polyval: -2
>     alg: self-tests for polyval using polyval failed (rc=-2)
> 
>     Resolution:-
>     Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
>     CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
>     sm3, sm4, aria, polyval & xctr.
> 
>     Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>

The commit log and Signed-off-by lines shouldn't have leading
spaces/indent.

> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 0a90583f9f01..627f57da9d5b 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
>  # CONFIG_SLUB_DEBUG is not set
>  # CONFIG_SCHED_DEBUG is not set
>  # CONFIG_FTRACE is not set
> +CONFIG_CRYPTO_HCTR2=m
> +CONFIG_CRYPTO_SM3_GENERIC=m
> +CONFIG_CRYPTO_SM4_GENERIC=m
> +CONFIG_CRYPTO_ARIA=m

Instead of adding lines at the end of file, please use help from
'make savedefconfig' to get them appear at the correct places.

Shawn
Kshitiz Varshney Feb. 5, 2024, 11:42 a.m. UTC | #5 
> -----Original Message-----
> From: Shawn Guo <shawn.gsc@gmail.com>
> Sent: Saturday, February 3, 2024 7:52 PM
> To: Kshitiz Varshney <kshitiz.varshney@nxp.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Fabio
> Estevam <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Varun Sethi
> <V.Sethi@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Sahil Malhotra <sahil.malhotra@nxp.com>;
> Vabhav Sharma <vabhav.sharma@nxp.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; Rahul Kumar Yadav
> <rahulkumar.yadav@nxp.com>; Nikhil Singla <nikhil.singla@nxp.com>;
> linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4,
> polyval, xctr cipher test support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Wed, Dec 20, 2023 at 12:38:57PM +0100, Kshitiz Varshney wrote:
> >     Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
> >
> >     Issue:-
> >     Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> >
> >     skcipher: failed to allocate transform for xctr(aes): -2
> >     alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> >     alg: self-tests for sm3 using sm3 failed (rc=-2)
> >     tcrypt: failed to load transform for sm3: -2
> >     alg: hash: failed to allocate transform for polyval: -2
> >     alg: self-tests for polyval using polyval failed (rc=-2)
> >
> >     Resolution:-
> >     Enabling CONFIG_CRYPTO_SM3_GENERIC,
> CONFIG_CRYPTO_SM4_GENERIC,
> >     CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables
> support of
> >     sm3, sm4, aria, polyval & xctr.
> >
> >     Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
> 
> The commit log and Signed-off-by lines shouldn't have leading
> spaces/indent. 
Checkpatch has not reported any such issues.
> 
> > ---
> >  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> > b/arch/arm/configs/imx_v6_v7_defconfig
> > index 0a90583f9f01..627f57da9d5b 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
> >  # CONFIG_SLUB_DEBUG is not set
> >  # CONFIG_SCHED_DEBUG is not set
> >  # CONFIG_FTRACE is not set
> > +CONFIG_CRYPTO_HCTR2=m
> > +CONFIG_CRYPTO_SM3_GENERIC=m
> > +CONFIG_CRYPTO_SM4_GENERIC=m
> > +CONFIG_CRYPTO_ARIA=m
> 
> Instead of adding lines at the end of file, please use help from 'make
> savedefconfig' to get them appear at the correct places.
Changes done in v2.
> 
> Shawn
diff mbox series

Patch

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 0a90583f9f01..627f57da9d5b 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -484,3 +484,7 @@  CONFIG_DEBUG_FS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_SCHED_DEBUG is not set
 # CONFIG_FTRACE is not set
+CONFIG_CRYPTO_HCTR2=m
+CONFIG_CRYPTO_SM3_GENERIC=m
+CONFIG_CRYPTO_SM4_GENERIC=m
+CONFIG_CRYPTO_ARIA=m