Message ID | 20231220-sa8295p-gpu-v2-3-4763246b72c0@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-9332-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp846792dyi; Thu, 21 Dec 2023 20:43:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAd06QKImxDVhY+Lrewf+Zs0A4WfGonmNS18rTVf0rPTklcE8AnDQcuUEabELx8tcdvHrO X-Received: by 2002:a17:903:22cc:b0:1d0:a2b2:6b0d with SMTP id y12-20020a17090322cc00b001d0a2b26b0dmr672784plg.4.1703220208865; Thu, 21 Dec 2023 20:43:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703220208; cv=none; d=google.com; s=arc-20160816; b=riwrPh/GPupVhHCB4uBe9KyHvgwLiZzf8RvT4qtvzofPSjdvaqAT0iO6vYtTY+PtwU iDc2BtUxION2zmmjI6qsNIghQaVzlrIQaxIprnJbiXOmZuwC4JlUM+FCR5HcTqlZ9wAd GJ3XLWktxVn9TUrCZG5BADKRhwKFG9JPp/ZzUYWlXd5cz8OQo497MPdB5NeeK0GPklb8 /HxrPGGQfw7Xt5ba/m7PXDx3Eqs1PGleIKrxQxT+zxmiEdseSp+mZ0Ps4iOf3O5S689q 8UUrAW6EMA8BekFXdmTyhm8PqFxkoXlbupgyxtEsIMnY0nrKoX617Cl6jlaS0lhZxaAz BbNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=kAejFZ/ItBZE6aRrg3eCWMTH3zfSs6hqjTpGWmLt2WE=; fh=cDqKou/MPLU1EgQSItoiSR05MtOwJVTVLj4INM9cZSI=; b=ekdQHS0bWSWG1wyjoCL9IhfMTpxRMCqIeW8aA7yG0Op7iPXTImNYq27fsRLro1iILD B8yuOQvz45xedfqo1RDEvQmWDGiSgk17umMM/GoxpxHhw01/BFND2jt6jYrAxJtJj1C1 SGGqSpOLk7cP3IFKco+c8bA5JRC1SvTzsE7uCsATpO7HonS/uekLRJaD++g1ZRqF8r0D BT8xg7vt0u4nbXGqYCo26IFL6sH5hX0dih2MDgiZP37D6nuLTDKWGL4xRbH32HnUlysU ObvopcNBYxM34PBEEIi1BAb/vjkVhMc6rvHbRQXqObMyGJo/9SMHylBWg7xD3VYgdj9j U3eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=T25AMZkN; spf=pass (google.com: domain of linux-kernel+bounces-9332-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9332-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id p1-20020a170902e74100b001d076ffeecdsi2672373plf.198.2023.12.21.20.43.28 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 20:43:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9332-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=T25AMZkN; spf=pass (google.com: domain of linux-kernel+bounces-9332-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9332-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0B0DCB248B8 for <ouuuleilei@gmail.com>; Fri, 22 Dec 2023 04:42:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 790E01799B; Fri, 22 Dec 2023 04:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="T25AMZkN" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 946A68F6F; Fri, 22 Dec 2023 04:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BM3gkDm005725; Fri, 22 Dec 2023 04:39:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=qcppdkim1; bh=kAejFZ/ItBZE6aRrg3eCWMTH3zfSs6hqjTpGWmLt2WE =; b=T25AMZkNcOftcpnFAdDpzZvAUS7o8Qw7/PwvVnVrO7ZcO3A2SqGuoUfkowZ a0x2xI1MfLxDVdOkh97zknO5aZeXhM25S/fYsIn1VQiWf47iunKffcvcX0WuXWoF CwEBqShSfXHoKqkjamupznzX5b8dvSQZh+eQGCYiofjrcoLjMIk5DUepg8UWvOpl FO0qqlD+s+aKrxky2tsdVC8Bg+wBMybHG2t3hkI2cd3mb0IUC+oTbyN5UHYnze/K 5ezEbLiEz2fuAnkAN07IgWqSSlW/JkumPOm9p2gQ8tp61ve2FhcM05yZkeHpGdhc CfHoTF5UyzYoiTDhafdAaRM/AXQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3v4kneagdn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Dec 2023 04:39:26 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BM4dOwx029442 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Dec 2023 04:39:25 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 21 Dec 2023 20:39:24 -0800 From: Bjorn Andersson <quic_bjorande@quicinc.com> Date: Thu, 21 Dec 2023 20:39:24 -0800 Subject: [PATCH v2 3/8] clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20231220-sa8295p-gpu-v2-3-4763246b72c0@quicinc.com> References: <20231220-sa8295p-gpu-v2-0-4763246b72c0@quicinc.com> In-Reply-To: <20231220-sa8295p-gpu-v2-0-4763246b72c0@quicinc.com> To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Taniya Das <quic_tdas@quicinc.com>, Ulf Hansson <ulf.hansson@linaro.org>, Johan Hovold <johan+linaro@kernel.org>, "Catalin Marinas" <catalin.marinas@arm.com>, Will Deacon <will@kernel.org> CC: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, "Bjorn Andersson" <quic_bjorande@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1703219963; l=903; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=MVsSng1ynfk2113y2FsOO5lEw0hWd7R7aSUjkXVaa9s=; b=aIck3r0kV5Lw1JbvzgWACNvQqY+0rYrn6BVbb9HSyMcUpqx01m13vUE7pXZARyjSNQ9i93JJpk+E LpjHmOusDfJ3LCizRutJZbNuC6GxrdpxfPrJy9UUZhMcjK0a764l X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: A13oqu48HH-AQshFfDVm4jEJnjQWwkxQ X-Proofpoint-ORIG-GUID: A13oqu48HH-AQshFfDVm4jEJnjQWwkxQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 mlxlogscore=986 suspectscore=0 spamscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312220029 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785955834005221608 X-GMAIL-MSGID: 1785955834005221608 |
Series |
arm64: dts: qcom: sa8295p: Enable GPU
|
|
Commit Message
Bjorn Andersson
Dec. 22, 2023, 4:39 a.m. UTC
On SA8295P and SA8540P the GFX rail is powered by a dedicated external regulator, instead of the rpmh-controlled "gfx.lvl". Define the "vdd-gfx" as the supply regulator for the GDSC, to cause the gdsc logic to look for, and control, this external power supply. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- drivers/clk/qcom/gpucc-sc8280xp.c | 1 + 1 file changed, 1 insertion(+)
Comments
On 22.12.2023 05:39, Bjorn Andersson wrote: > On SA8295P and SA8540P the GFX rail is powered by a dedicated external > regulator, instead of the rpmh-controlled "gfx.lvl". > > Define the "vdd-gfx" as the supply regulator for the GDSC, to cause the > gdsc logic to look for, and control, this external power supply. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- Worth noting the regulator framework will create a virtual supply for the normal 8280 Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Wed, Dec 27, 2023 at 02:07:52AM +0100, Konrad Dybcio wrote: > On 22.12.2023 05:39, Bjorn Andersson wrote: > > On SA8295P and SA8540P the GFX rail is powered by a dedicated external > > regulator, instead of the rpmh-controlled "gfx.lvl". > > > > Define the "vdd-gfx" as the supply regulator for the GDSC, to cause the > > gdsc logic to look for, and control, this external power supply. > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > > --- > Worth noting the regulator framework will create a virtual supply > for the normal 8280 > You're right. No functional harm, but that's not very nice. I don't think we have any benefit from having a dummy supply, if the DT author failed to provide a proper one, so it seems reasonable to switch gdsc to devm_regulator_get_optional(). Regards, Bjorn > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Konrad
diff --git a/drivers/clk/qcom/gpucc-sc8280xp.c b/drivers/clk/qcom/gpucc-sc8280xp.c index 8e147ee294ee..e2b3bc000c71 100644 --- a/drivers/clk/qcom/gpucc-sc8280xp.c +++ b/drivers/clk/qcom/gpucc-sc8280xp.c @@ -399,6 +399,7 @@ static struct gdsc gx_gdsc = { }, .pwrsts = PWRSTS_OFF_ON, .flags = CLAMP_IO | RETAIN_FF_ENABLE, + .supply = "vdd-gfx", }; static struct gdsc *gpu_cc_sc8280xp_gdscs[] = {