| Message ID | 20231219171903.3530985-19-hugo@hugovil.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-5677-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2100032dyi;
Tue, 19 Dec 2023 09:31:44 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IFK063X+hgCNqYcp1BaxTLKvQj4jO7hSMYKlKHTpoJLmz4eTR39R0lZU0PnqnSFQ0cKtIFs
X-Received: by 2002:ac2:48b1:0:b0:50e:2f96:4ee with SMTP id
u17-20020ac248b1000000b0050e2f9604eemr2502269lfg.36.1703007103696;
Tue, 19 Dec 2023 09:31:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1703007103; cv=none;
d=google.com; s=arc-20160816;
b=fxYdDbcLj0MzhFC4cIk2YW/StpJ+rVxjigaJWxFY8YQKZLK34l7pfNtrGcVFLcGR40
/WWkwOOtzmsAwrkG9urHdsyKKn8w3sNoUzITpeis3Xctb6nyz2fVdJOLA4ufFTUKsB1H
T4fYuhBoQrOnqOpx5YWsTyFs1pVeCBpRm6EiBx+vhQZAKhMRphhKWK7j2gjJjDI3MzQn
Qdak/3+rru8dAPDB9SeDbWUEpahkBxxr1xEba+mpL6oY5KG5ZZOpqO5NwN1CTBc2cjFJ
uEMHW19XOB1g8Npdl4EF8f+WNHuVyLvsDilP76URzJFySaqw0AAp9dbmQO0V/Uuc597M
dbaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=subject:content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:references:in-reply-to:message-id
:date:cc:to:from:dkim-signature;
bh=KcYNp1sWTrGWiUqu1nyxva4KTAsY45l/5TWJVZ84DbE=;
fh=cU7nueyVLD6PCX143V/gcz7kaNKnsE7kxUBegEucbAs=;
b=Y2PN6vGYrkyqa98spg3Oko7856NC6YFhyge7wmnUpnhW7CTOSGYsJ15ILE8q/ym3Ll
7xHjLXoKfgTja7LU04Xj74nW5IG4VrvEy3ZT18weY8RE7HseTsPxu4ZMns1WdizkjRJL
tdeRGm9PtNL9QiyTq7OVCbGvtPWYFAQlXQIFzyHo12zKWBjhtJtod+DHphXgX+Pmcvh3
qKZMUmiWp8Cndbe+YIQPE7ZdpSu4CEUGJYChs7nzMRrYJUQmsghqdiFF3XRiP96HVRxZ
usCBQEFm6eBFkd39TEIwq4vumiOdbijeUebHBMb0eOVycYvVJNe+p4iJg9hll3eLr81z
SaBg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@hugovil.com header.s=x header.b=BeZkUDmS;
spf=pass (google.com: domain of
linux-kernel+bounces-5677-ouuuleilei=gmail.com@vger.kernel.org designates
147.75.80.249 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-5677-ouuuleilei=gmail.com@vger.kernel.org"
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249])
by mx.google.com with ESMTPS id
d23-20020a170906c21700b00a1d5063b01fsi10955476ejz.834.2023.12.19.09.31.43
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 19 Dec 2023 09:31:43 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-5677-ouuuleilei=gmail.com@vger.kernel.org designates
147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Authentication-Results: mx.google.com;
dkim=pass header.i=@hugovil.com header.s=x header.b=BeZkUDmS;
spf=pass (google.com: domain of
linux-kernel+bounces-5677-ouuuleilei=gmail.com@vger.kernel.org designates
147.75.80.249 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-5677-ouuuleilei=gmail.com@vger.kernel.org"
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by am.mirrors.kernel.org (Postfix) with ESMTPS id 130DF1F239AE
for <ouuuleilei@gmail.com>; Tue, 19 Dec 2023 17:24:09 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 57FB13FB37;
Tue, 19 Dec 2023 17:19:40 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (1024-bit key) header.d=hugovil.com header.i=@hugovil.com
header.b="BeZkUDmS"
X-Original-To: linux-kernel@vger.kernel.org
Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id E980221364;
Tue, 19 Dec 2023 17:19:30 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=none (p=none dis=none) header.from=hugovil.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=hugovil.com
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com
; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To
:From:subject:date:message-id:reply-to;
bh=KcYNp1sWTrGWiUqu1nyxva4KTAsY45l/5TWJVZ84DbE=; b=BeZkUDmS0Qlg0Xyvi2r+RDaD9N
GfZJ7MuTv4qhQJwQpz+ywqURzyObSUnrDTmKZzJwjjkoASxaFny29IIrF2XrHRXAV3PQmHJ66TLtD
7HqLnLjfVu0bxFD/5k4ax4Ot23PNzrdHRMLj1IapmfMJafO+wlXEk2Jju+fbPhPQVmos=;
Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:40128
helo=pettiford.lan)
by mail.hugovil.com with esmtpa (Exim 4.92)
(envelope-from <hugo@hugovil.com>)
id 1rFdkb-0007Ao-Qt; Tue, 19 Dec 2023 12:19:26 -0500
From: Hugo Villeneuve <hugo@hugovil.com>
To: gregkh@linuxfoundation.org,
jirislaby@kernel.org,
jringle@gridpoint.com,
kubakici@wp.pl,
phil@raspberrypi.org,
bo.svangard@embeddedart.se
Cc: linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
hugo@hugovil.com,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Date: Tue, 19 Dec 2023 12:19:02 -0500
Message-Id: <20231219171903.3530985-19-hugo@hugovil.com>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20231219171903.3530985-1-hugo@hugovil.com>
References: <20231219171903.3530985-1-hugo@hugovil.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 70.80.174.168
X-SA-Exim-Mail-From: hugo@hugovil.com
X-Spam-Level:
X-Spam-Report:
* -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
* -0.0 T_SCC_BODY_TEXT_LINE No description available.
Subject: [PATCH 18/18] serial: sc16is7xx: fix whitespace in
sc16is7xx_startup() comments
X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000)
X-SA-Exim-Scanned: Yes (on mail.hugovil.com)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1785732376553252127
X-GMAIL-MSGID: 1785732376553252127
|
| Series |
serial: sc16is7xx: fixes, cleanups and improvements
|
|
Commit Message
Hugo Villeneuve
Dec. 19, 2023, 5:19 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Add missing space at end of comments. Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- drivers/tty/serial/sc16is7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, Dec 19, 2023 at 12:19:02PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Add missing space at end of comments. ... > - /* Reset FIFOs*/ > + /* Reset FIFOs */ > val = SC16IS7XX_FCR_RXRESET_BIT | SC16IS7XX_FCR_TXRESET_BIT; > sc16is7xx_port_write(port, SC16IS7XX_FCR_REG, val); > udelay(5); You can combine this with other comment style cleanups and spelling fixes (if any). I.o.w. proof-read the code and check if there are any issues besides noted ones.
On Wed, 20 Dec 2023 18:04:55 +0200 Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > On Tue, Dec 19, 2023 at 12:19:02PM -0500, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Add missing space at end of comments. > > ... > > > - /* Reset FIFOs*/ > > + /* Reset FIFOs */ > > val = SC16IS7XX_FCR_RXRESET_BIT | SC16IS7XX_FCR_TXRESET_BIT; > > sc16is7xx_port_write(port, SC16IS7XX_FCR_REG, val); > > udelay(5); > > You can combine this with other comment style cleanups and spelling fixes > (if any). I.o.w. proof-read the code and check if there are any issues > besides noted ones. Ok. Hugo Villeneuve
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index ab68ee346ec6..a8a78d8f7fcf 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1139,7 +1139,7 @@ static int sc16is7xx_startup(struct uart_port *port) sc16is7xx_power(port, 1); - /* Reset FIFOs*/ + /* Reset FIFOs */ val = SC16IS7XX_FCR_RXRESET_BIT | SC16IS7XX_FCR_TXRESET_BIT; sc16is7xx_port_write(port, SC16IS7XX_FCR_REG, val); udelay(5);