From patchwork Tue Dec 19 17:00:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Bee X-Patchwork-Id: 181121 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2085586dyi; Tue, 19 Dec 2023 09:09:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IEolhPUt12LxVnac1Ib76wTqKMYIYIXb73zeWKy3ZFmgi2M13ZILWAzxcObw1AA6Om5cR2u X-Received: by 2002:a05:620a:45:b0:77f:6bb6:a50e with SMTP id t5-20020a05620a004500b0077f6bb6a50emr1885039qkt.12.1703005797394; Tue, 19 Dec 2023 09:09:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703005797; cv=none; d=google.com; s=arc-20160816; b=ERgZF8/x8+/7RiR7FxWN5iDdBhF/4fHxnVSujt1Dna9AWouUBQ6s/dEXUK40SBgLvN yyc3BKRmAhlujaJm5V8s0Qt5y/rzawzMZ4uz0ITcZuzoG+cnjzi6c7eS89af44rJVBSI yJvKb6W+rSU4jeN+ZlvEJHLpNolmqRN6xSxG/ImoPUFIhg6oTQj0E7lEJ5VrsDrlTqOd kQXdAgfJ2qv6Q9qH2p0OF/xKuualHxAnm2JWgw/o+Bzhy8QCgXBaTzpRyri3v9n+NlKR xY1or5j5PLHtfLlMEoJUeYwCg6qrs22SCMei5LTk9VQFMAJk+c2Z8ZxNmXmqRbK7+PVy DSfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=arQ8xIKVUtWj1nUwdouDUReL6yFeDt+BlaNGpwFH10c=; fh=k7ZhfSDxugAUNAX9PFQjqQnTRGZ+rgCl5CN8/TdzbyU=; b=P8MI/xziTnCckd5UHsXZUkTejpeYen0HhYhbO6OYBxWTqH4qJOWjr4WP8RWrnH/+mk nzXo8LcvrKdQOdQWxOMuz3hE5RqoTXQ3Xf4lzZheFwdCgLj34uDrlWmISvwVcXjk7Qqi cGdEizsdz17499KhoNQVH4wmGly9BrvmNE3UwpjtP4rwHXXkiEi6P7G/B1kRawBsX8dF rqJft9Kuxal/+lddJ+jezLD9xPAqqLQBDnXLrxZo+W7dLww1CCjCeGkF1oCfvE4rmlq5 pj1kiD4KpFWRjiQBAQj7g4kF46Shh+K+pjwiBdChJ7rTHQzDp/bTNqigRf0HuQ/bRFEw jK9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RbTs8Oo7; spf=pass (google.com: domain of linux-kernel+bounces-5645-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5645-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id e11-20020ad4536b000000b0067ef4df6098si14747738qvv.127.2023.12.19.09.09.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 09:09:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5645-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RbTs8Oo7; spf=pass (google.com: domain of linux-kernel+bounces-5645-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5645-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 308A61C20B9E for ; Tue, 19 Dec 2023 17:09:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1A19644C98; Tue, 19 Dec 2023 17:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RbTs8Oo7" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8970C40C09; Tue, 19 Dec 2023 17:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40c2308faedso56875975e9.1; Tue, 19 Dec 2023 09:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703005292; x=1703610092; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=arQ8xIKVUtWj1nUwdouDUReL6yFeDt+BlaNGpwFH10c=; b=RbTs8Oo7u6lWQN4ritpdDDtCnEZyYNqr3daLnGr3XpV1bsq24lQMnl6xaFRlc0Vmry lWaMXh57LHQqN+Asnv6Lps9gJb1mjKoP7e4DFObAwbE1hdzrzQOQ17D5op3/SFya+obg HJtuEXY5vtEImSmti0fqPLnGLXc6GOrkb3wBO1ibeNX5FkZP6waVw2IFEnJvq4Zgxyje OthXovLYBf3dale2ZvJ3GGh4rlgI/q8Ju63KHrczvWCD3DxvqBhu9v+o74fZ9EqHK0ty h5VqcmKzbQ0DT0rdS9TvSShMyVIfY/I/xq0SgjxneJlorPIu1ZGl+hwKwFaVRyseipC+ /p9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703005292; x=1703610092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=arQ8xIKVUtWj1nUwdouDUReL6yFeDt+BlaNGpwFH10c=; b=MvpTSOV/JzNJLJN6CWfiv1aCGdBHqcBVSRx2mTatLH8IcV8U948Unrpx0rKNykG7y1 3cF1YYpQ6TQj84ruh6OSWqpScf1AHARxe7HXbIxXgQ0gQrAlJdKWxz+ZA+ElxOGYGdhD Gawg3klC5pJlog+DPAQXj2nKv8ePExcpXQF7AayAV+4yFCUcJQB9XBsGBRqNYl8d9IzR 34i5WX7BaW8AiL95W5i6xkxbX9eoq4lduBJaV2mhf4fjzzEJrZxQGzmgfnf8kgJKdY3x JiYUxEXjM+FnWGMmHQwGHjqTWIbcXPwIksnNA7P6ulTGvWZ5zHB2H7yPN2u1nJTI7oCr oC2Q== X-Gm-Message-State: AOJu0Ywq7Iex7av+xEAGYormncQf7FhZC5+0SNKj7DhPMESMi+rR0EhB SdIx3kbqi9bDrY4bBh0F1Q== X-Received: by 2002:a05:600c:4f52:b0:40b:5e21:d362 with SMTP id m18-20020a05600c4f5200b0040b5e21d362mr9931502wmq.107.1703005291752; Tue, 19 Dec 2023 09:01:31 -0800 (PST) Received: from U4.lan ([2a02:810b:f40:4300:7ae5:3e:d1c6:a138]) by smtp.gmail.com with ESMTPSA id i7-20020a05600c354700b0040d2805d158sm3225878wmq.48.2023.12.19.09.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 09:01:31 -0800 (PST) From: Alex Bee To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Alex Bee Subject: [PATCH v3 26/29] drm/rockchip: inno_hdmi: Drop custom fill_modes hook Date: Tue, 19 Dec 2023 18:00:56 +0100 Message-ID: <20231219170100.188800-27-knaerzche@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231219170100.188800-1-knaerzche@gmail.com> References: <20231219170100.188800-1-knaerzche@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785731007371175502 X-GMAIL-MSGID: 1785731007371175502 Now that we have proper pixelclock-based mode validation we can drop the custom fill_modes hook. CRTC size validation for the display controller has been added with Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to hardware capabilities") Signed-off-by: Alex Bee Reviewed-by: Maxime Ripard --- changes in v2: - no changes changes in v3: - collect RB drivers/gpu/drm/rockchip/inno_hdmi.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index a2a9e54b76c0..29a2c1b87294 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -631,13 +631,6 @@ inno_hdmi_connector_mode_valid(struct drm_connector *connector, return inno_hdmi_display_mode_valid(hdmi, mode); } -static int -inno_hdmi_probe_single_connector_modes(struct drm_connector *connector, - uint32_t maxX, uint32_t maxY) -{ - return drm_helper_probe_single_connector_modes(connector, 1920, 1080); -} - static void inno_hdmi_connector_destroy(struct drm_connector *connector) { drm_connector_unregister(connector); @@ -691,7 +684,7 @@ inno_hdmi_atomic_destroy_state(struct drm_connector *connector, } static const struct drm_connector_funcs inno_hdmi_connector_funcs = { - .fill_modes = inno_hdmi_probe_single_connector_modes, + .fill_modes = drm_helper_probe_single_connector_modes, .detect = inno_hdmi_connector_detect, .destroy = inno_hdmi_connector_destroy, .reset = inno_hdmi_connector_reset,