From patchwork Tue Dec 19 14:23:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 180977 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1974354dyi; Tue, 19 Dec 2023 06:26:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtPbrZgjCG/q4vaIjZ4J73DR1gdqndgv1tALaX8F/p6iREYcB80kfY288TBOHfin+GeyBb X-Received: by 2002:a05:6a00:349b:b0:6d7:bfb2:f289 with SMTP id cp27-20020a056a00349b00b006d7bfb2f289mr4544884pfb.51.1702996004149; Tue, 19 Dec 2023 06:26:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702996004; cv=none; d=google.com; s=arc-20160816; b=egtSGJCZmSELWF/1joJsdOu4BmYpVA255g1kdfc3BhbDCOlNUjCiXG3iBsrjtwXBpf zVDJx7rhrZSg15kSf67vPoa58MMZwWIoq1AQJR/D9q7tGq2L03mzAmN2xO3q6yxMpRAZ V4nm82J20bCjXaggjhVcpdkRb/5e/gQl8ZRE6a1QjvO76IG2CD84o7obYm3mwLixuf59 c0S/w5ESpgIS8Vg8m1E8Z3/8dZ5DLFBXVv1IBM7XU2vMc5ZCEhhL4bJpJFA3TN7wYUil GFQTaL74lZk6vccsXYo21DSSz5qdcQK5xCRarltGnXxltSoEzftkOu7R+OwL8syFjUx9 39AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=m0ixPtoAPGKvK37J2//i5TEfAHvCqoh+89EGr3jhVvs=; fh=u8rLQsUjk/DQ68o09SM+wx8FxqDFcT3zeQdKot9Eyy4=; b=HfF9O/4Ma7y1p9p6vsu7jDNhz68JRGB0mP7IPzBswca1sFDgqL4L5dbBKBw9GeCLOQ exHhWbdzzcb0BFNHjNp8GecAAKRVJtMxidxOUbbWROJBBJFegWq0rz97FWMNKNPhdp9e 8eQy6cmjIQRve5IVN8Y79GFd1EKInSuskJua5F/cpQNDNTV4Ql0YTK03lFrrVFmXCAsD E7ACO9e7VxiaeFkrYnXNRwOwy8OnDptNF1EWZqWybhjI1QI5BjIS+OE/kChQdOW2QRyF jm7NhDBMYvgSrS8y/wgIyZGTslCR4ieUtNAPh/g4owfDEtrt1ME7dtIw0irwdti7F3Ym 0r4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=HrdbuES1; spf=pass (google.com: domain of linux-kernel+bounces-5347-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5347-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ka9-20020a056a00938900b006cde1cef718si4345019pfb.322.2023.12.19.06.26.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 06:26:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5347-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=HrdbuES1; spf=pass (google.com: domain of linux-kernel+bounces-5347-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5347-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0F3D728356A for ; Tue, 19 Dec 2023 14:24:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 319AF1C6B4; Tue, 19 Dec 2023 14:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="HrdbuES1" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52D751B288 for ; Tue, 19 Dec 2023 14:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-336695c4317so2213110f8f.3 for ; Tue, 19 Dec 2023 06:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1702995807; x=1703600607; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=m0ixPtoAPGKvK37J2//i5TEfAHvCqoh+89EGr3jhVvs=; b=HrdbuES1NGfwpowO7HGB7Jqz39EI2lOXKUviEuq/dwNfLnQhkKMcaxe5Rt2KHH0xYA mb9JwllXypjYLiZGREbFoPVQ/rZ3+c2X29f2k7lt9gbSd3PS7J08UFZa6ImoMxf/r2HT fNnj+PaFsy3yiM2wdYG7e3ooU+ly9RsfTKB3jZsDBOvXzNXHHph3JeJWrHJTi4tVZWZ8 sYdwz55wfwnL/sHUHIU5OxW1MkFiswC5H+s44xYzUbWJLmuu9d1w0N4knLPR/U5Imt5C HPs9yGDZ5kQQYu4bzhxQ4vqngKByIDMfsG7O7vCYzp1sIaz3RD0Xz2RZFQd3a0y5lbms UHQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702995807; x=1703600607; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m0ixPtoAPGKvK37J2//i5TEfAHvCqoh+89EGr3jhVvs=; b=OUfsX/CJkjs5Iq9RiP/KIqjqIKK8tfpxu6Ic54zBp1dOdgbosXS2FzmIN6DF6CmBN/ mevjQHNw4GLs4vsnQ2JTauz4iEaxM6FeqVyDEnzf5JQVeKFYE7tYFzxuABa9OcUX51UZ ewiIw3ynaB9nKVKlcPt4Z+BzxrspOvkXyyOTZ4C/lRQSKNUP1L94PtC3ko+C8pg1HSZr UbsJKF35CED7vpUZsKD4oqTFmNXEW/T1mGpuriBJNvYyP+dK9uTfkOb0QUKBm0IiODbR 9/aCT4E613V9p+xeflv4cifnK5V3Evm2IlcBT0bSHji04LcXzD1KKrSjtLyjy79cB7av eRgg== X-Gm-Message-State: AOJu0Yyw2+D8mWxhu2f1xYl2JpiuwKPoU0paAxZB5bofJunIi27uKCx8 uVMnR+wHcSchJgDBn06dOZHOFw== X-Received: by 2002:a05:6000:1d84:b0:336:1fcf:5aec with SMTP id bk4-20020a0560001d8400b003361fcf5aecmr9838671wrb.55.1702995807441; Tue, 19 Dec 2023 06:23:27 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:bfd0:6ab0:50e2:7f18]) by smtp.gmail.com with ESMTPSA id e32-20020a5d5960000000b003366e3b434bsm3038375wri.65.2023.12.19.06.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 06:23:27 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko , Kent Gibson Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 1/2] gpiolib: drop tabs from local variable declarations Date: Tue, 19 Dec 2023 15:23:22 +0100 Message-Id: <20231219142323.28929-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785720737737270472 X-GMAIL-MSGID: 1785720737737270472 From: Bartosz Golaszewski Older code has an annoying habit of putting tabs between the type and the name of the variable. This doesn't really add to readability and newer code doesn't do it so make the entire file consistent. While at it: convert 'unsigned' to 'unsigned int'. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- drivers/gpio/gpiolib.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index c9ca809b55de..c3704d32afdd 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1049,8 +1049,8 @@ EXPORT_SYMBOL_GPL(gpiochip_add_data_with_key); void gpiochip_remove(struct gpio_chip *gc) { struct gpio_device *gdev = gc->gpiodev; - unsigned long flags; - unsigned int i; + unsigned long flags; + unsigned int i; down_write(&gdev->sem); @@ -2186,10 +2186,10 @@ EXPORT_SYMBOL_GPL(gpiochip_remove_pin_ranges); */ static int gpiod_request_commit(struct gpio_desc *desc, const char *label) { - struct gpio_chip *gc = desc->gdev->chip; - int ret; - unsigned long flags; - unsigned offset; + struct gpio_chip *gc = desc->gdev->chip; + int ret; + unsigned long flags; + unsigned int offset; if (label) { label = kstrdup_const(label, GFP_KERNEL); @@ -2301,9 +2301,9 @@ int gpiod_request(struct gpio_desc *desc, const char *label) static bool gpiod_free_commit(struct gpio_desc *desc) { - bool ret = false; - unsigned long flags; - struct gpio_chip *gc; + bool ret = false; + unsigned long flags; + struct gpio_chip *gc; might_sleep(); @@ -2577,8 +2577,8 @@ int gpio_set_debounce_timeout(struct gpio_desc *desc, unsigned int debounce) */ int gpiod_direction_input(struct gpio_desc *desc) { - struct gpio_chip *gc; - int ret = 0; + struct gpio_chip *gc; + int ret = 0; VALIDATE_DESC(desc); gc = desc->gdev->chip; @@ -2927,7 +2927,7 @@ static int gpio_chip_get_value(struct gpio_chip *gc, const struct gpio_desc *des static int gpiod_get_raw_value_commit(const struct gpio_desc *desc) { - struct gpio_chip *gc; + struct gpio_chip *gc; int value; gc = desc->gdev->chip; @@ -3222,7 +3222,7 @@ static void gpio_set_open_source_value_commit(struct gpio_desc *desc, bool value static void gpiod_set_raw_value_commit(struct gpio_desc *desc, bool value) { - struct gpio_chip *gc; + struct gpio_chip *gc; gc = desc->gdev->chip; trace_gpio_value(desc_to_gpio(desc), 0, value); @@ -4709,13 +4709,13 @@ core_initcall(gpiolib_dev_init); static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev) { - struct gpio_chip *gc = gdev->chip; - struct gpio_desc *desc; - unsigned gpio = gdev->base; - int value; - bool is_out; - bool is_irq; - bool active_low; + struct gpio_chip *gc = gdev->chip; + struct gpio_desc *desc; + unsigned int gpio = gdev->base; + int value; + bool is_out; + bool is_irq; + bool active_low; for_each_gpio_desc(gc, desc) { if (test_bit(FLAG_REQUESTED, &desc->flags)) {