| Message ID | 20231218174042.794012-3-mike.rudenko@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-4186-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1412621dyi;
Mon, 18 Dec 2023 09:42:40 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IGV3bR6UTGkdHnWMv3gAF+0j/xbsuen9nFkUKAFtM/sboBLd41ereOwsLI+tICYQPo9rTqN
X-Received: by 2002:a05:620a:46aa:b0:76f:1268:9e26 with SMTP id
bq42-20020a05620a46aa00b0076f12689e26mr24146493qkb.24.1702921360231;
Mon, 18 Dec 2023 09:42:40 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1702921360; cv=none;
d=google.com; s=arc-20160816;
b=LljNB5bzxRUUY2HNc4fMQgjKEo0YFcw1ERODhGxXEa3IzVy+EIG4FHsYxPR1bx44j4
I1skhs8LY5DNSTmg6gakEkWZx/2Y78OCdYvSEqrH1rJPgOLKooPevWpVcUPD5UewN1cL
iAaA4oFrUd28AepYfP0IIxlY/JXh1mdVkNABcU7u15646AcGLL4VJweCzWEg5jKr+SRg
jA4+lcmPc2qi68w7xyuGkp7zWtA5Hle+03JPetCUGkX9g6svYfN4i3/eFLUKw2c0YSYq
Q5Azk2xuq/8TSkZ/NK8BT2iZqAMkxwz7S+yr9e7E7vEapArwySAnXWXfibu3G43Yu4gY
5yww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=4czKecRr4zUiqvQxmuxZf3Bt0qVxMHQuUS2sRj3gQ9o=;
fh=Ft8dYvEuFIKwnehVwpL0WG7QMIrRLMi0wgN4ll940k8=;
b=pKg4jsCPI6s2JzHOGP5zUQBHXVSu2gNqKlBrdQApjuS3CfS57W2p4Qnf6tK/tbvLqx
NwgTGtK/Y1YG0oMNOPiIZ+F/reEYoBUBFHlVc6Oj3qjuGr2I2ztnocnLbZLRYSh5x6iQ
WmYCuW3FQU5/JQtKSIsX1SkfCAUSOPPaIJvfWv2QycFCE+1Rfj47RvAQjxoBQLxCcDH4
VoLF+QN2Ed++oxGd56IipVvWgALWF9ZSzohLlF9/ZQsr8K6l3+2dGE1vMNEv7VSK731h
e6dVDpfmlDAxcu9saaX+pCy1BikMDDE5kel4ApfRE68Ne41jNq6adPPh0LAHYKqeL6iQ
HetQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=C1iYIqPT;
spf=pass (google.com: domain of
linux-kernel+bounces-4186-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-4186-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org.
[2604:1380:45d1:ec00::1])
by mx.google.com with ESMTPS id
j17-20020a05620a289100b0077f911d44f2si13580110qkp.325.2023.12.18.09.42.40
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 18 Dec 2023 09:42:40 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-4186-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=C1iYIqPT;
spf=pass (google.com: domain of
linux-kernel+bounces-4186-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-4186-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ny.mirrors.kernel.org (Postfix) with ESMTPS id EC9F21C254AB
for <ouuuleilei@gmail.com>; Mon, 18 Dec 2023 17:42:39 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id EA4967348A;
Mon, 18 Dec 2023 17:41:11 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
header.b="C1iYIqPT"
X-Original-To: linux-kernel@vger.kernel.org
Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com
[209.85.167.54])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD75E5D758;
Mon, 18 Dec 2023 17:41:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=gmail.com
Received: by mail-lf1-f54.google.com with SMTP id
2adb3069b0e04-50e2bd8c396so2410919e87.0;
Mon, 18 Dec 2023 09:41:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1702921259; x=1703526059;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=4czKecRr4zUiqvQxmuxZf3Bt0qVxMHQuUS2sRj3gQ9o=;
b=C1iYIqPTprmgc3srMBvzf+1LlOOCtfy1qNb8XLA+RoGDnAyPrPcuhfHw28bHgB8xSY
+2bTZqTkpGqCqLCq7yE9wzO7E3AWKkd8283uohkM5KKUm61Qvd60StIepgfhYO4Wad4y
UkoaavQ8sE+LBDNK7uCckL6/X7G2tlVDedEeDdGud5q+fL8siPEbv45MiZNBmyeki7+S
1TRPwf7EFpm/i/No26Kpc6GVPT8uk+bA0yMVr4s3Dx+MwHDMhh0cWMYAu8+Twae43BiI
ko8e4iqisY+v5Ke/vPR07UiQbKQGKWWUeX/YLVA15QUcYJarhR8AIlLdprBpx6MEG0pD
x9AQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1702921259; x=1703526059;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=4czKecRr4zUiqvQxmuxZf3Bt0qVxMHQuUS2sRj3gQ9o=;
b=cKKXg2oa7Dw/rK/69pxSAx5IivYBwRmSBrh0e5LE7UeAaO+q+UJ7rQH41Gftc17doQ
NFnVZ6RvnUVOpaEN4KopQFbnwIphfEI0bwp4kP1RfFJ3Mq79ROCoLWvk2GqqNpJ4yF4e
HceQfcFGU43SyCU0dhOIZkSaXkzfZQ0AOQmj+9m5x7OZjCbC0X7Bqfaz/PdxiVvVaLq+
ZVYd9Is+CxLi8F26tjvuTwgq2N+hxE6IhqcMJhVboXKQ5FFkZ0OOToRbRl3hQxN0pLDS
HxbfJ8AG7YrQpzz4w+/s5j166UdMG6nMtHsLGHAyakZ4rqr/c6hl5EqH8NbsRnjIhUPg
RI+Q==
X-Gm-Message-State: AOJu0YyUqi9wl1wzpkZN+oouHBocuw+DkvOWTvguxNSu3MXNNYemxI7N
wgLKifON83DSup2BRkz+/fX4Dt3u5OSfSg==
X-Received: by 2002:ac2:5f7c:0:b0:50e:2275:59bb with SMTP id
c28-20020ac25f7c000000b0050e227559bbmr2351376lfc.44.1702921258994;
Mon, 18 Dec 2023 09:40:58 -0800 (PST)
Received: from localhost ([83.149.246.185])
by smtp.gmail.com with ESMTPSA id
dx6-20020a0565122c0600b0050e3cd7444asm226006lfb.15.2023.12.18.09.40.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 18 Dec 2023 09:40:58 -0800 (PST)
From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mikhail Rudenko <mike.rudenko@gmail.com>
Subject: [PATCH v2 02/20] media: i2c: ov4689: Sort register definitions by
address
Date: Mon, 18 Dec 2023 20:40:23 +0300
Message-ID: <20231218174042.794012-3-mike.rudenko@gmail.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20231218174042.794012-1-mike.rudenko@gmail.com>
References: <20231218174042.794012-1-mike.rudenko@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1785642467894771003
X-GMAIL-MSGID: 1785642467894771003
|
| Series |
Omnivision OV4689 refactoring and improvements
|
|
Commit Message
Mikhail Rudenko
Dec. 18, 2023, 5:40 p.m. UTC
Put register defininitions in the order of increasing register
address.
Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
---
drivers/media/i2c/ov4689.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Comments
Hi Mikhail, Thank you for the patch. On Mon, Dec 18, 2023 at 08:40:23PM +0300, Mikhail Rudenko wrote: > Put register defininitions in the order of increasing register > address. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/ov4689.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c > index ff5213862974..1ae6d9b9c9b3 100644 > --- a/drivers/media/i2c/ov4689.c > +++ b/drivers/media/i2c/ov4689.c > @@ -19,15 +19,15 @@ > #include <media/v4l2-subdev.h> > #include <media/v4l2-fwnode.h> > > -#define CHIP_ID 0x004688 > -#define OV4689_REG_CHIP_ID 0x300a > - > #define OV4689_XVCLK_FREQ 24000000 > > #define OV4689_REG_CTRL_MODE 0x0100 > #define OV4689_MODE_SW_STANDBY 0x0 > #define OV4689_MODE_STREAMING BIT(0) > > +#define OV4689_REG_CHIP_ID 0x300a > +#define CHIP_ID 0x004688 > + > #define OV4689_REG_EXPOSURE 0x3500 > #define OV4689_EXPOSURE_MIN 4 > #define OV4689_EXPOSURE_STEP 1 > @@ -41,12 +41,12 @@ > #define OV4689_GAIN_STEP 1 > #define OV4689_GAIN_DEFAULT 0x80 > > +#define OV4689_REG_VTS 0x380e > + > #define OV4689_REG_TEST_PATTERN 0x5040 > #define OV4689_TEST_PATTERN_ENABLE 0x80 > #define OV4689_TEST_PATTERN_DISABLE 0x0 > > -#define OV4689_REG_VTS 0x380e > - > #define REG_NULL 0xFFFF > > #define OV4689_REG_VALUE_08BIT 1
diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c index ff5213862974..1ae6d9b9c9b3 100644 --- a/drivers/media/i2c/ov4689.c +++ b/drivers/media/i2c/ov4689.c @@ -19,15 +19,15 @@ #include <media/v4l2-subdev.h> #include <media/v4l2-fwnode.h> -#define CHIP_ID 0x004688 -#define OV4689_REG_CHIP_ID 0x300a - #define OV4689_XVCLK_FREQ 24000000 #define OV4689_REG_CTRL_MODE 0x0100 #define OV4689_MODE_SW_STANDBY 0x0 #define OV4689_MODE_STREAMING BIT(0) +#define OV4689_REG_CHIP_ID 0x300a +#define CHIP_ID 0x004688 + #define OV4689_REG_EXPOSURE 0x3500 #define OV4689_EXPOSURE_MIN 4 #define OV4689_EXPOSURE_STEP 1 @@ -41,12 +41,12 @@ #define OV4689_GAIN_STEP 1 #define OV4689_GAIN_DEFAULT 0x80 +#define OV4689_REG_VTS 0x380e + #define OV4689_REG_TEST_PATTERN 0x5040 #define OV4689_TEST_PATTERN_ENABLE 0x80 #define OV4689_TEST_PATTERN_DISABLE 0x0 -#define OV4689_REG_VTS 0x380e - #define REG_NULL 0xFFFF #define OV4689_REG_VALUE_08BIT 1