From patchwork Mon Dec 18 15:35:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 180506 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1330048dyi; Mon, 18 Dec 2023 07:42:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8VVqewx+JzOp3zbXJFnNBQaDuBtPo5VYoXfihTlrYhlFak9bM6p8/T9hYxojd35x5tSQg X-Received: by 2002:a17:902:f54a:b0:1d3:ad3b:466 with SMTP id h10-20020a170902f54a00b001d3ad3b0466mr1117822plf.13.1702914151402; Mon, 18 Dec 2023 07:42:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702914151; cv=none; d=google.com; s=arc-20160816; b=XoKAUqXguLTNgswpfAZyKVsK+GD9QNAGGSzPZlUvQ9nMq2LJJg6rkmfM5HzOcSTdz5 k9nkQ+lK6TB9fub8xG9vr0TTwK6Qo1t16K2DRznf3H1tKfs9ujf0JOAGHKZPN2cLIa+M 2dvRDB7KMYnd58lfl68M0BJFO/1UyKJHXh64yQGPHNZzwXR5S8DKwjv6Xn1qNEkunqoL 1OuBHVclyHILICQml877+Fd3uIg8F21uf5d40l52DQsqYmNtrS3xAIAIh0SKb/ChySge IlYrZ0N/zvsr7YBw2wuA3Xrx/Uw+dcriceBwjW0+e1kXK9HJknoPIUxwFk12iYvzhEBS +JjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Yv9NEALRhhPVlldz2t/Fuz2oV/CBEjy/kwNcSSKy2c0=; fh=m0HBXuwgOCKat7wyuY7vstPypqMqxNmINnjBv5+EUjU=; b=Fp1dDzYX8dA4uKZ+gdW0RMdJbeW+9s1raltbpRvUD/Tfn3FVMUPrOWReGXoluMRyrV JbKJ7911CfXat5Qv59rV27QzDoHnji2D6ILlVTgT7avYLDQHPZoC82SlR9irio4QbezC Pa/9fsA5rJbz3BbNoJxvTK2f5pxctuS/wB7lRV55oZ7EnHw4aPQU6CY4k4EfIu8KTO3/ +HAnZJDVyPJGSEetIh/z3XFZICRaUJtNe9vEP2wknI0eJMzytYCPp0EhfpG0NrWS+pMy 4MuaNC+hC0q9bTSFOAhlr6DoeUu4ltkB2u7xficEIzVfJlhcWvILKxWYFaA/OvpjPHWQ g8Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Ta/ZLMIs"; spf=pass (google.com: domain of linux-kernel+bounces-3960-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3960-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b6-20020a170902bd4600b001d055df4ce6si17889349plx.422.2023.12.18.07.42.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 07:42:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3960-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Ta/ZLMIs"; spf=pass (google.com: domain of linux-kernel+bounces-3960-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3960-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2DFC1283CD7 for ; Mon, 18 Dec 2023 15:42:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C186B760AF; Mon, 18 Dec 2023 15:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ta/ZLMIs" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7D347608C; Mon, 18 Dec 2023 15:36:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Yv9NEALRhhPVlldz2t/Fuz2oV/CBEjy/kwNcSSKy2c0=; b=Ta/ZLMIsSHqIp2kIeOMq/K8hB2 zFZCr1dwmBjJEP7zd40V7gPNrS8Qq8UdpAP4HvpFibJa7PnELaGjiXIkJgs9LbZfhxzMLiZxR19/Z ++ITeDX1dp9VlPnF7QA5rPA1D7yzo/KssnWGNQfL8BiIiooj5jmwq4zPBo9jPWNrxYSz0+JvXqQzt PcEtGKUqDiewhkGM0ONfc2onosXMtAAhLVUhezlbdzmUWnT4EE50UjXRKfAWvUhEtjA4PLGZp0qYc a8UXrSBukXbauIaVN5VwADLcnX3Mq8vOHhtXGAGyXTGZLBBIcMALFeurlzETNild+N+rdYR7/ZYiq U19LWeWQ==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rFFfh-00BEdJ-09; Mon, 18 Dec 2023 15:36:45 +0000 From: Christoph Hellwig To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/17] writeback: update the kerneldoc comment for tag_pages_for_writeback Date: Mon, 18 Dec 2023 16:35:53 +0100 Message-Id: <20231218153553.807799-18-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231218153553.807799-1-hch@lst.de> References: <20231218153553.807799-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785634909078327854 X-GMAIL-MSGID: 1785634909078327854 Don't refer to write_cache_pages, which now is just a wrapper for the writeback iterator. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara --- mm/page-writeback.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index d3c2c78e0c67ce..bc69044fd063e8 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2325,18 +2325,18 @@ void __init page_writeback_init(void) } /** - * tag_pages_for_writeback - tag pages to be written by write_cache_pages + * tag_pages_for_writeback - tag pages to be written by writeback * @mapping: address space structure to write * @start: starting page index * @end: ending page index (inclusive) * * This function scans the page range from @start to @end (inclusive) and tags - * all pages that have DIRTY tag set with a special TOWRITE tag. The idea is - * that write_cache_pages (or whoever calls this function) will then use - * TOWRITE tag to identify pages eligible for writeback. This mechanism is - * used to avoid livelocking of writeback by a process steadily creating new - * dirty pages in the file (thus it is important for this function to be quick - * so that it can tag pages faster than a dirtying process can create them). + * all pages that have DIRTY tag set with a special TOWRITE tag. The caller + * can then use the TOWRITE tag to identify pages eligible for writeback. + * This mechanism is used to avoid livelocking of writeback by a process + * steadily creating new dirty pages in the file (thus it is important for this + * function to be quick so that it can tag pages faster than a dirtying process + * can create them). */ void tag_pages_for_writeback(struct address_space *mapping, pgoff_t start, pgoff_t end)