From patchwork Mon Dec 18 09:57:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karina Yankevich X-Patchwork-Id: 180236 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1133554dyi; Mon, 18 Dec 2023 02:00:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJ4K0zw4FgWqVo0RL5KhCavdCxac0P2AZ620tMSDvv/XaRAVezeolViz1BsPN6k1FvtzsA X-Received: by 2002:a37:e201:0:b0:77f:9106:899f with SMTP id g1-20020a37e201000000b0077f9106899fmr10826372qki.137.1702893606629; Mon, 18 Dec 2023 02:00:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702893606; cv=none; d=google.com; s=arc-20160816; b=I6y2MvwUtd+Ld2Eq/VNg0+tH6d77//27u1mM4utK7aa75mD5qZTNZsrjtgefzwOdq7 Uhz2aSTxPhLDtjwjPfdVVosEt1csm1Fw+jFq9nuLEIcSgaFhP/No/5CQmIe5JaFajiaq MnsCKUpGVe8z7WeOUnbrb3Ujx7AJCk/Y85pYj6TbffRQBH+g5ZXvht2BMrv0K/TJ2LiU P6StvhZxtzmY1Ej78+UVKDMel7a3KuGQstHPrlTs8tEv5fTOvpgj/zGHkp4K1XYCJvkg RFHvTtP/6o/5FzmOwoqD3cUYPRKYnY3oc5Q+omYyEY9Y2KY1QRZqIVwuOcFGAoMIXFBv pEIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=hFZA6eybJwFkYBphqBShH2VoFfKmQXRQF7QY9UHqQL0=; fh=XAP0CWOZNKar76SZMUPaSvJ+Q8z9AAa1F3q5QV4knqM=; b=0p2PheQeIc0N8NEi1e2OdUgzHlbc8bU94i8y8Nm5T3lv/Rj6v17XnohO10BNvuHUWj J2Sqr3rkflTqwaTQBeHxz9BxV9TOJ4a34cQEAFus7vNGRO8fAZltpPlX3JL5xG+3Z54Z JxNBdd5IfCI4L89108WagO0szYBgvY9IRf+Lcq27nwkNlDaAy9IMRMp57rTY3MeCcSiv L+PSYB2a7A5PFDxk5UgynOdpF6XiRgNnv02FTV8lnagOyTZb7tm3B6rVfTm//srr5/3L g1v/kLpVu9lfolVpy/TZ+h4aSub+dFs81S8wNyG67cBDRsNPCdcMjHJfWQgxQM3SGAh/ O8iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-3284-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3284-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dt10-20020a05620a478a00b0077eff4d54b3si23182967qkb.261.2023.12.18.02.00.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 02:00:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3284-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-3284-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3284-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CA6E31C22A9E for ; Mon, 18 Dec 2023 09:59:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D204D1426F; Mon, 18 Dec 2023 09:59:32 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3032E13FE7 for ; Mon, 18 Dec 2023 09:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from spb1wst022.omp.ru (109.73.39.18) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Mon, 18 Dec 2023 12:59:19 +0300 From: Karina Yankevich To: Liam Girdwood CC: Karina Yankevich , Mark Brown , , Subject: [PATCH] regulator: of: Remove redundant check in of_get_regulation_constraints Date: Mon, 18 Dec 2023 12:57:07 +0300 Message-ID: <20231218095707.2625407-1-k.yankevich@omp.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 12/18/2023 09:32:49 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 19 X-KSE-AntiSpam-Info: Lua profiles 182159 [Dec 18 2023] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: k.yankevich@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 109.73.39.18 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;spb1wst022.omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 109.73.39.18 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 19 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 12/18/2023 09:37:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 12/18/2023 7:00:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785613366277410415 X-GMAIL-MSGID: 1785613366277410415 The pointer 'suspend_state' cannot be NULL after the switch statement so remove the redundant check. Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Karina Yankevich --- drivers/regulator/of_regulator.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 1b65e5e4e40f..c926779523ca 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -266,10 +266,6 @@ static int of_get_regulation_constraints(struct device *dev, suspend_np = of_get_child_by_name(np, regulator_states[i]); if (!suspend_np) continue; - if (!suspend_state) { - of_node_put(suspend_np); - continue; - } if (!of_property_read_u32(suspend_np, "regulator-mode", &pval)) {