diff mbox series

Message ID 20231218094139.2616883-1-k.yankevich@omp.ru
State New
Headers
Series |

Commit Message

Karina Yankevich Dec. 18, 2023, 9:41 a.m. UTC 
  Date: Thu, 14 Dec 2023 18:59:20 +0300
Subject: [PATCH] regulator: of: Remove redundant check in
 of_get_regulation_constraints

The pointer 'suspend_state' cannot be NULL after the switch statement
so remove the redundant check.

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Karina Yankevich <k.yankevich@omp.ru>
---
 drivers/regulator/of_regulator.c | 4 ----
 1 file changed, 4 deletions(-)
diff mbox series

Patch

diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 1b65e5e4e40f..c926779523ca 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -266,10 +266,6 @@  static int of_get_regulation_constraints(struct device *dev,
 		suspend_np = of_get_child_by_name(np, regulator_states[i]);
 		if (!suspend_np)
 			continue;
-		if (!suspend_state) {
-			of_node_put(suspend_np);
-			continue;
-		}
 
 		if (!of_property_read_u32(suspend_np, "regulator-mode",
 					  &pval)) {