From patchwork Sat Dec 16 03:03:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 179750 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp8687dyi; Fri, 15 Dec 2023 19:04:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFn6MoMKSshDB1HfMVpZkfnGIW6p/ZkhyNVg/1xmWtN8bXy3pQnsXmCEFB35saSR30hmqoO X-Received: by 2002:a05:6a00:170d:b0:6ce:5431:6e43 with SMTP id h13-20020a056a00170d00b006ce54316e43mr16340058pfc.33.1702695890359; Fri, 15 Dec 2023 19:04:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702695890; cv=none; d=google.com; s=arc-20160816; b=BEotGCbERn0jdu6EpqhEgApRvg4QtOtb4o5SNxHM4wxwoVkfDKSQ47QC5X/60mqFq/ j0YY9cPBfOBUxrpYvgtI/HRPuCU9LmGRq6xNwjxNtYYbwgUIfSIgfHUjow6vUIfmPla+ jsN2oZmTyWkeuGFQvsJBkE7z7nERpf5M37LR01bQkcRZC/huYYJ4B1+FGOsGP8sSMnlx BX+ADxMSapIb7yEgVcECF7itcGUx5qeOwrqjbMGJEMfpxLPoZUk137zKaP81ikEBDbBw uYkXXuJtugy4j77EaDePEoteizi4ylPVOdrCDzFQxE8qHpqH/6r+cWZHdaG2Sa6PxKnF EcOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=m1kkjflSaXlRG8CRCUF8DyyydFgrQziYsG0nGeB4/64=; fh=fpGccoeHqxMjllh9FqyVbmOoAW07PyLJ54jbmir5SGo=; b=qdHMBVIbKKREVq0KbWs9fq3zYXFZbJoK0/usvheo8t2FdGNrt7saNDZAsamuSRLbFT EYcjsLf3TG2HvNiIaggxteYnw7dyCatg9XuSx3lynAOJ/sdvrTjHJ0zOyp2cZXgoOTcq XUv3WcvCQ9plmxCmUqW+3IkRMV/NJSQm1ATmT+pFtSx8rxI/EDq/5nZsBF/D4juTlt1d 6rebxOaYFQYS6IoMVXuvdr4OKgcAuyLMZMwN5aOqHmU4nrsiF5N1LVYENlko2NhCw2Yn lSM4alcWrBUPLWl9utY9lmYBbjL39uO9Ypuq73m00U7mH3tkEnkG84KNT7RHd+VWtJV3 HUng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="KuhMqLw/"; spf=pass (google.com: domain of linux-kernel+bounces-1977-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1977-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j4-20020a056a00234400b006cec976aba9si13975693pfj.323.2023.12.15.19.04.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 19:04:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1977-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="KuhMqLw/"; spf=pass (google.com: domain of linux-kernel+bounces-1977-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1977-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9D4222862A0 for ; Sat, 16 Dec 2023 03:04:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 571264681; Sat, 16 Dec 2023 03:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KuhMqLw/" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0448E5670; Sat, 16 Dec 2023 03:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=m1kkjflSaXlRG8CRCUF8DyyydFgrQziYsG0nGeB4/64=; b=KuhMqLw/iYusyNgvEAy8QduJNj 1/kUrf8rKilum4ck/VlP4mKtyDerXqHsNAH89IFr73dM7z8U6mG/Sy6cPA8KkCJFHouA6g/1wHVEm FtEdBpaZpWbj+DmT7/9H4UckblBvoM+eOlEzETWhU3FsVvYFlUYJADEDJXi8oFhSRRp3Y0R5ghP7h X79MizaeoWbXyfBcbC8vftSotHMfsc9nffdUY5qc2FwefsLxpQjTSXTMnbW7iKL830Nv43jTpdIhH tSppyZdpTDfGQ2l2CN/fqVdQBUbFE2fcuC1x5z3dR6aHGLGImA8rPXeQVkhKqKR99fGwLSGt/bdIs 86Jsst5g==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEKy6-005DN6-2d; Sat, 16 Dec 2023 03:03:58 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Namjae Jeon , Steve French , Sergey Senozhatsky , Tom Talpey , linux-cifs@vger.kernel.org Subject: [PATCH] ksmbd: auth: fix most kernel-doc warnings Date: Fri, 15 Dec 2023 19:03:57 -0800 Message-ID: <20231216030357.7728-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785406045728977377 X-GMAIL-MSGID: 1785406045728977377 Fix 12 of 17 kernel-doc warnings in auth.c: auth.c:221: warning: Function parameter or member 'conn' not described in 'ksmbd_auth_ntlmv2' auth.c:221: warning: Function parameter or member 'cryptkey' not described in 'ksmbd_auth_ntlmv2' auth.c:305: warning: Function parameter or member 'blob_len' not described in 'ksmbd_decode_ntlmssp_auth_blob' auth.c:305: warning: Function parameter or member 'conn' not described in 'ksmbd_decode_ntlmssp_auth_blob' auth.c:305: warning: Excess function parameter 'usr' description in 'ksmbd_decode_ntlmssp_auth_blob' auth.c:385: warning: Function parameter or member 'blob_len' not described in 'ksmbd_decode_ntlmssp_neg_blob' auth.c:385: warning: Function parameter or member 'conn' not described in 'ksmbd_decode_ntlmssp_neg_blob' auth.c:385: warning: Excess function parameter 'rsp' description in 'ksmbd_decode_ntlmssp_neg_blob' auth.c:385: warning: Excess function parameter 'sess' description in 'ksmbd_decode_ntlmssp_neg_blob' auth.c:413: warning: Function parameter or member 'conn' not described in 'ksmbd_build_ntlmssp_challenge_blob' auth.c:413: warning: Excess function parameter 'rsp' description in 'ksmbd_build_ntlmssp_challenge_blob' auth.c:413: warning: Excess function parameter 'sess' description in 'ksmbd_build_ntlmssp_challenge_blob' The other 5 are only present when a W=1 kernel build is done or when scripts/kernel-doc is run with -Wall. They are: auth.c:81: warning: No description found for return value of 'ksmbd_gen_sess_key' auth.c:385: warning: No description found for return value of 'ksmbd_decode_ntlmssp_neg_blob' auth.c:413: warning: No description found for return value of 'ksmbd_build_ntlmssp_challenge_blob' auth.c:577: warning: No description found for return value of 'ksmbd_sign_smb2_pdu' auth.c:628: warning: No description found for return value of 'ksmbd_sign_smb3_pdu' Signed-off-by: Randy Dunlap Cc: Namjae Jeon Cc: Steve French Cc: Sergey Senozhatsky Cc: Tom Talpey Cc: linux-cifs@vger.kernel.org Acked-by: Namjae Jeon --- fs/smb/server/auth.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff -- a/fs/smb/server/auth.c b/fs/smb/server/auth.c --- a/fs/smb/server/auth.c +++ b/fs/smb/server/auth.c @@ -208,10 +208,12 @@ out: /** * ksmbd_auth_ntlmv2() - NTLMv2 authentication handler - * @sess: session of connection + * @conn: connection + * @sess: session of connection * @ntlmv2: NTLMv2 challenge response * @blen: NTLMv2 blob length * @domain_name: domain name + * @cryptkey: session crypto key * * Return: 0 on success, error number on error */ @@ -294,7 +296,8 @@ out: * ksmbd_decode_ntlmssp_auth_blob() - helper function to construct * authenticate blob * @authblob: authenticate blob source pointer - * @usr: user details + * @blob_len: length of the @authblob message + * @conn: connection * @sess: session of connection * * Return: 0 on success, error number on error @@ -376,8 +379,8 @@ int ksmbd_decode_ntlmssp_auth_blob(struc * ksmbd_decode_ntlmssp_neg_blob() - helper function to construct * negotiate blob * @negblob: negotiate blob source pointer - * @rsp: response header pointer to be updated - * @sess: session of connection + * @blob_len: length of the @authblob message + * @conn: connection * */ int ksmbd_decode_ntlmssp_neg_blob(struct negotiate_message *negblob, @@ -403,8 +406,7 @@ int ksmbd_decode_ntlmssp_neg_blob(struct * ksmbd_build_ntlmssp_challenge_blob() - helper function to construct * challenge blob * @chgblob: challenge blob source pointer to initialize - * @rsp: response header pointer to be updated - * @sess: session of connection + * @conn: connection * */ unsigned int