From patchwork Sat Dec 16 01:55:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 179732 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9700247dys; Fri, 15 Dec 2023 17:57:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtmfwFGq/IkhyVv0Q7p0lx3wY2bdy8s+sRwzImZK+xgz/lRqZJryTtJfO3Nbr+NOfgdmbv X-Received: by 2002:a05:6870:d38c:b0:203:8416:d05f with SMTP id k12-20020a056870d38c00b002038416d05fmr1107407oag.33.1702691822799; Fri, 15 Dec 2023 17:57:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702691822; cv=none; d=google.com; s=arc-20160816; b=iSnoz1RD+lTElw4dgi1M3L036TyRH8d75m78jAPa9pJS//o0ptyZ0Zw8FDwaOtVg+Q CirCzRn9tROxZpg5f8rMiY2XES6yaV4YtIKlVyJoceE1RyvSNPgXu7JHLnPHlw2ZIBlW BI5T3aXLvXnl3aw8oii8rQqcjKHP4D4/rUM1rEH0ek0rDCB6iWiOnMRPjBEhI1Zw7JqQ r+0pM53B2RJY+CBIoYZVvMq47sUikyQRJHVMCpv0luN2nzbjbS4qeZNlSh+OqL1TpFPq R0r83WuWnKccRyMGFJ30YK8QlqOD0uB1/wuDuYBejST8ibTRWvjaaHBGNeTG69iX6Dgs pfQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=QJL/oymgKktJpb0b6BlRieduvf4h6pM+eHnmmIXqIIQ=; fh=VE5ZfoJWem8it6OrnlM5ov49ej/hHjarqyIgnpICDoo=; b=K7RjSgL4/scH/5o2olGuZbHA+pen3Izwgna6mYsqH6+jbEk+8cjlQ2vFQRMXlUlExI QtMC/skJ5PFxam/DO4HadHeQWvh0Jbxtnuj6CuGwVwfIa1gXzOcf2RSMNdnH2YjvOP4W dsSaQ7DAE1uOSGWOfoHmJvhLX8CP8Hpqmnfm/053JxXZiGT4YQpW7TUFCFb7f+BXtKmz qURisPSlo/UWAAfGYWHJevYkEgnyOc/+Yntk3ZGiKk95jtw49o0B8pt/k2CAtaZimyFN MekzAGaGOZtGSKK/RhUN7+i6kUcsaIp0Es7F8vj9JpU+m/EnqmeUKQsKz2wIBd8Nu8DA O1lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=HVsiTsi4; spf=pass (google.com: domain of linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b38-20020a630c26000000b005c201eb7e85si13860801pgl.541.2023.12.15.17.57.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 17:57:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=HVsiTsi4; spf=pass (google.com: domain of linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6C1EA285C57 for ; Sat, 16 Dec 2023 01:57:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D62C75387; Sat, 16 Dec 2023 01:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="HVsiTsi4" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D8471363; Sat, 16 Dec 2023 01:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1702691774; x=1703296574; i=w_armin@gmx.de; bh=iRRAKbmAPwXhvUW4GeDAtHUeGHCa7UwO3y4IzMhZosU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=HVsiTsi4E/5xdpDXVtctRIpM2N23LOMCPUHwodHrmknycMsDGuJbRO96zdF4U0SH bjkGyFYIoCaDuckpwtR2jYWvyVF3FtRDM1b/mSVAuS3O4liD20rmhUNAk2hsjuy1R os7TlUFnATc3eYlSNH5D0APJgk38ZI0Wra1NjYNW5qXiNORVR522LHtevLTUxArqX sH9Y53KDZiAr9uNeap08HjigS3h40dFahdEcgbfQs/ODwzWWgjgXyHnY2tVT0QOGY DewFqBZHNoiL1X+PZOfCxDtedI2mRqH6gTE8WQeBVBUdarPUJ+AYRjopM6wkMj3Ub unktvxa+B4vUh5Hisw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M59GA-1rDDys1NuW-001CoP; Sat, 16 Dec 2023 02:56:14 +0100 From: Armin Wolf To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] platform/x86: wmi: Remove unused variable in address space handler Date: Sat, 16 Dec 2023 02:55:56 +0100 Message-Id: <20231216015601.395118-2-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231216015601.395118-1-W_Armin@gmx.de> References: <20231216015601.395118-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:MOirfnZjqqSa7HKQZpaCjRHQzbSnjM/WT0d9T5Iambpw8kD6B9y 28m2Aow+fBqN0ma3ceR3fbZCEW/VusvoVPjx/Z61DKdNH24CTDtgsibYLUp7dQUY/fJL+Pj fyTXopPyGIIbgliOO8KCsKMzSgdfqBEOSn5PypGzVIUz0pok/I3OSZ0aM8LpldoR2rUUjqy uMR1DIPkjCn739AF6FK7g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:g6TJpMyVtzg=;8NJD8ZkcZbvWcPGjTdnCYAfn48e rS/yojc3meuqmvJ5oso+pp5CEd9xvsTzahRVyRzmg949loKL46jyAcNCZI5ImHrGZKmXUswtv BwY23woQqcu1Uqm87Pzi8gfgrqdymGcCdNudKJxPW/+tKW02ZgfJOaFJxxCvr/ueTZuLoiKug /vuc8B7amK/VtZngUoqt+TmBDPbQ4MDc4DdsiYe2vT3oLWhJHgSCtJ176knmVXVF5kI5t75xp DGsOWLfA9XH5uDqIxO3UvN9k132jmxzQ/ZzQPwIxfPxIK18SyvCMDcle4fExUCdws3hQNY7Ze RM1+m3PLYeLm8ma7XGzx6DDcUR3XayOmfnkUIjNHU/WD00JKI7SJ3bfmypl2vST4bXYtIRd2V 8wZ+yaRLUNrMD61NIFenRs1KPdNEOxGmn+zFnvWLOYn2LAwIj9mz4u1lKHdQHfP03uE3KUbiS WyV51xWuM0POH4BOpsBcmPA2C7mzgp21VPf2NnN6cQwwK3CqSDru291Zz2qJycLe7JkLLiiiG V/LcFOZYgNLi11OPsIZ6o1+aJRPfOqkY5iGgtusibw/VmKKsJuisg8hJGAM8P9Xzso1sgdNMR BqRRuRGPE725kooFahxDm8nHFXKWkojFYTq5fGsrk4I5bvX0mzE7Cdm1/WFUYNNv+3YWObtLk T/NdslgPL8YNrH5e0s8CrIikPzu5CSj1w6yrBCOvrZpnz6nFwRdLi/Q0rSKrJ9KywJRe/5PWA Mxb3jVHaK/v8xVGN+zePFUsR8VMZ3ZZUBkO2FoOi01JbHcVEvKWM9av+63+MEI+2rJLjj179M A16yZHI969PbnXwd7DZXHVnhwACLNnCaqW5yG7/SQop7IXrouOltIQJVty4fxzYnzupUlsGJJ EFY0JmZ4OLy02346Xbz8yPUXGnPwifm3f+QAAPIslQr21+Dd1B74cTVAYJmoXxkAdB+luyOV3 Q8aXwqqSRlozaFZ4MPrQ5WXHpN8= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785401780817969629 X-GMAIL-MSGID: 1785401780817969629 The variable "i" is always zero and only used in shift operations. Remove it to make the code more readable. Signed-off-by: Armin Wolf Reviewed-by: Ilpo Järvinen --- drivers/platform/x86/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.39.2 diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 7303702290e5..906d3a2831ae 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1144,7 +1144,7 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, u32 bits, u64 *value, void *handler_context, void *region_context) { - int result = 0, i = 0; + int result = 0; u8 temp = 0; if ((address > 0xFF) || !value) @@ -1158,9 +1158,9 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, if (function == ACPI_READ) { result = ec_read(address, &temp); - (*value) |= ((u64)temp) << i; + *value = temp; } else { - temp = 0xff & ((*value) >> i); + temp = 0xff & *value; result = ec_write(address, temp); }