From patchwork Fri Dec 15 13:05:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna-Maria Behnsen X-Patchwork-Id: 179264 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9256769dys; Fri, 15 Dec 2023 05:06:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHt0r8M05wLy88RhMcr18PU6FS8XUpqLHXTtgmODLIJv1jf2lk1MlZkwBx2Ja2MeD3riGnb X-Received: by 2002:a17:903:704:b0:1d3:3a00:d8de with SMTP id kk4-20020a170903070400b001d33a00d8demr5758518plb.30.1702645577098; Fri, 15 Dec 2023 05:06:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702645577; cv=none; d=google.com; s=arc-20160816; b=YkY/lmW9Z52dqY0le0cDIP5eqZMZQ9rGfL4z/Qz0iWFZLddB+IN15z6Z1zudXOTz4w qqK3AaSibEF0lFu0vJv5fjGe5hGqyt45oERScM/ikcAZRMaTYVH5FXGnX7Hv+GFcMuxH g8cla4sx/yXssTf9T29lM2uD1yLnhJO/o55uzb6D/VznmUhDPEANP1h7qE0+kyq0lBUa DJYOUkyU+EdRy6p6h1XlqLxs8WE44vScPPQ75qUi2bODiqtUXrCAVoVblhfrsNCWVlfB 8zcy98BmBMhLjzpo3zIRMwQXmYJ4v9m7Il6Yb/+JnUVcBT3yZwpsRYGSuOHfCzfyy+pz u7Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :dkim-signature:dkim-signature:from; bh=U2tDiKHKYr5BFBF9MXdN4euPv07ro9CC99NNHl3ihkg=; fh=8eucRM/E/6Vm+s9321T/RQBjZf79bIaNiF/9aTHmHWo=; b=C4mzz0BKeB62rkXcWwfWh78n0QdiUbPDG6G3EucCp10yyGy5xIQW6r3mgETyv0b3dd CLNagIAef+ceVfzkY68nW7DHj99AzWl+U6CitQFOAXS6rY+Xr5nRjnGWuCx/Pjbmg4Wj usB/QoOfXnst5d8uBY9D4ci0B/8SHBonEGc/iJmdKurDEVZuUB4allNkKpd3rEUuaaPW ImgcN+OpdG/0UTG3aMMxtyW44bqLRscCWR2R5zFuzbXaQOj3BJhJ6dks/jkr9YV3kOis RY/FsIkClDM3WtSEmEqyMamT59sDwiDYatu/gA74wpTQhy+dpj/R9UhluXcHzUXwEVBh tZCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=rlNUTVj1; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel+bounces-971-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-971-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n7-20020a1709026a8700b001d356043820si3981650plk.604.2023.12.15.05.06.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 05:06:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-971-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=rlNUTVj1; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel+bounces-971-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-971-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8F64BB23703 for ; Fri, 15 Dec 2023 13:05:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6658F2DB6D; Fri, 15 Dec 2023 13:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="rlNUTVj1"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="aCbWa5Az" X-Original-To: linux-kernel@vger.kernel.org Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A4B22DB7C for ; Fri, 15 Dec 2023 13:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1702645511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=U2tDiKHKYr5BFBF9MXdN4euPv07ro9CC99NNHl3ihkg=; b=rlNUTVj11k9F9xc53az5oRZhTvMk3vR94kDWFOfa7PKvXnflbuwCP1YKdtZGHxLpdRhcgg fDm25g5wa4AfJJLPZK2dxPjsW2nBasLq4ivhyW54mNkGHLlGMcy46RAmGtr+8CtBkltUFP a00rKENsxQjPdgL8Wuhu8eWz9LhHREfhMsEashAZZ9/I0vIvFrbEle23ziddTULY32XYKT NURUrmnfZ/rMFgoT3TeGgb/Uoe4G7quDjS6FlR8LZFqtesbqjcADn2ZmTYx43LJZgjByGc MUOIjFrFOXGNCvrdwoTMJpXW9qa+k85M5Ox2A7EhML7EYrK0JtetLNekGnRN6w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1702645511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=U2tDiKHKYr5BFBF9MXdN4euPv07ro9CC99NNHl3ihkg=; b=aCbWa5AznxUTz9+fLqfPxDsN2XeRkh9QsBGsRJ837u6cYvKn96zQhQAwbLWBVxvV1EGE+i +rFPQBp4IS/u5cCw== To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Thomas Gleixner Subject: [PATCH] sched/idle: Prevent stopping the tick when there is no cpuidle driver Date: Fri, 15 Dec 2023 14:05:01 +0100 Message-Id: <20231215130501.24542-1-anna-maria@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785353288488644005 X-GMAIL-MSGID: 1785353288488644005 When there is no cpuidle driver, the system tries to stop the tick even if the system is fully loaded. But stopping the tick is not for free and it decreases performance on a fully loaded system. As there is no (cpuidle) framework which brings CPU in a power saving state when nothing needs to be done, there is also no power saving benefit when stopping the tick. Therefore do not stop the tick when there is no cpuidle driver. Signed-off-by: Anna-Maria Behnsen --- kernel/sched/idle.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c index 565f8374ddbb..fd111686aaf3 100644 --- a/kernel/sched/idle.c +++ b/kernel/sched/idle.c @@ -165,8 +165,6 @@ static void cpuidle_idle_call(void) */ if (cpuidle_not_available(drv, dev)) { - tick_nohz_idle_stop_tick(); - default_idle_call(); goto exit_idle; }