From patchwork Fri Dec 15 10:45:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 179169 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9180414dys; Fri, 15 Dec 2023 02:47:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IELY2zcg+HehmtUgXetGKbk9WeTZeS2sDU4aoUei7RRAWCfgGl2g6Fa+TvHqGvrrBfCeg3H X-Received: by 2002:a05:620a:40c4:b0:77f:6810:dcff with SMTP id g4-20020a05620a40c400b0077f6810dcffmr16688836qko.28.1702637250668; Fri, 15 Dec 2023 02:47:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702637250; cv=none; d=google.com; s=arc-20160816; b=DkIg2ZCF15bk9gb+5rekbI3LSiwFon2wXW8vhCBtrhNr6clny7tEsAOd972bhU9Mee dN3CIcPoVmSQJngdI/7cgAzKxB1sU5LUlH11TawHgL1iVt8d/iDha/vpjQtQY+HlF1fu X5m/TOLGwtEE12QWbdKwgP+cJJyEjAukOkvyuaG89/KvaG2fyiT/ftacC94l77+pBd6V HXr2q/LT+khuY+wZYGxScc0A7fblueJI1K1vZyhkPcsMMFW8InvniIiBnztSS3bZ6omu k8z1jYFC1SFyt0cHyPlwPa1QsLJKyBrXhc3QbwJopOyXLu9MU53wo5k/YbYizRhd+fMa qGJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Ryh1iGTa7kF9idOemql3ilVj21B/Zv9mQQDRw2KtiZk=; fh=uXuiAKCIzcls/bVWehiPG5bGSzwyo88Xr298kNzj2n4=; b=YSzhu64wWCOK1UMVIM3tvOlMESpcxf3rH6YPByKq+gS9Cwa+kpR8kWDEY7bSboVqhA vT8hj6vu8BoZLFhb15C/BaZB3VxsXO7w0kEt0wJyAmtP5JIo+QgjcSxM40rQsqlGdqdr NvCyHmQIQMiqXPh/lVITMJz6Fp8l65yKRx0sILFsMB1byMgv/R/0puYJkfyvV6aQwdPt /rl4i+XCdWnWfr82QobUlM5cUoOjgPBOxUZOufOq47Rf0KGbkyCmEn/Io+yaIeHtxlzE Qw+eqPjIdlXhi6gl2YQ4xEE4dDZKKnLvq6zXCeExLKYSfQMo/QQzRUPoyw0gnmxZH5hQ nidA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="kVTRpd/Q"; spf=pass (google.com: domain of linux-kernel+bounces-778-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-778-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s17-20020a05620a29d100b0077f63268fd3si14759267qkp.48.2023.12.15.02.47.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 02:47:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-778-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="kVTRpd/Q"; spf=pass (google.com: domain of linux-kernel+bounces-778-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-778-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 724C01C231E1 for ; Fri, 15 Dec 2023 10:47:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5721A2C699; Fri, 15 Dec 2023 10:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="kVTRpd/Q" X-Original-To: linux-kernel@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41DE01A73F; Fri, 15 Dec 2023 10:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702637166; bh=/CmNXLjXKNYtE3QqvhH1lwezEnrtQSIJkJcxeOmHOgs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kVTRpd/QXiE/fuAxIqthRZXkouBjFQYgItywSZsLJrn7P2ek1WFaczYYy6AezJwvu z1n1jckY6JH9ZDRGuMPKp2I4IiRmEqGd+sDufnJa1aB49oanAmcIERk5gWE6ajzSC+ JRG7lL7NYb2XVWbX2jyon60DbIkHTnyIaCaWQqqTnpvlPoXufRHv9zczg85fDebCRI +s/hW2SvwIhpf1qyaQ7xwlvqVSCLrOjVIXxaNgaTcq3Yyi05skff9e9l9RQbFqX8DN SGsmV24D01n7jHIYh4GlSGG77R37fan293irVkgoYmLdHWrtMJVIU6zCWdDD/fbNVM 3HVsXNzZWiR9g== Received: from eugen-station.. (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BDE013781FD6; Fri, 15 Dec 2023 10:46:05 +0000 (UTC) From: Eugen Hristev To: linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, linux-media@vger.kernel.org, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, Eugen Hristev Subject: [PATCH v2 3/7] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name Date: Fri, 15 Dec 2023 12:45:47 +0200 Message-Id: <20231215104551.233679-3-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231215104551.233679-1-eugen.hristev@collabora.com> References: <20231215104551.233679-1-eugen.hristev@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785344558150415758 X-GMAIL-MSGID: 1785344558150415758 Looking at the binding it makes sense that the `-vp8` compatible has the `venc_lt_sel` while the other bindings have the `venc_sel` as name for the clock. This was also mentioned in the txt version of the binding before the conversion: ` clock-names: avc encoder must contain "venc_sel", vp8 encoder must contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2", ` So it is easier to check for compatible that includes vp8, since that's just one, to have the requirement for the clock name property as `venc_lt_sel`, rather than for all the others, some of which are missing, thus for them, the requirement is wrongly `venc_lt_sel`. Reordered the if/then/else to match `-vp8` and have all the rest of the compatibles using the other clock name (`venc_sel`). Signed-off-by: Eugen Hristev Reviewed-by: Rob Herring --- Changes in v2: - new patch. .../bindings/media/mediatek,vcodec-encoder.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index 403530de5624..5166c1c6934e 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml @@ -111,10 +111,7 @@ allOf: properties: compatible: enum: - - mediatek,mt8173-vcodec-enc - - mediatek,mt8188-vcodec-enc - - mediatek,mt8192-vcodec-enc - - mediatek,mt8195-vcodec-enc + - mediatek,mt8173-vcodec-enc-vp8 then: properties: @@ -124,8 +121,8 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_sel - else: # for vp8 hw encoder + - const: venc_lt_sel + else: properties: clock: items: @@ -133,7 +130,7 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_lt_sel + - const: venc_sel additionalProperties: false