From patchwork Thu Dec 14 18:40:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 178867 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8765237dys; Thu, 14 Dec 2023 10:41:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiXPCXPPnk/mKr+J/yHwHifwekf8Kvu4u+KPbH5uKjg699Jz9cJj3v+0xTuFqiM8t3HSmm X-Received: by 2002:a05:6358:7e97:b0:172:ab3c:b952 with SMTP id o23-20020a0563587e9700b00172ab3cb952mr202883rwn.31.1702579291391; Thu, 14 Dec 2023 10:41:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702579291; cv=none; d=google.com; s=arc-20160816; b=oX7qwlThfF+aQd9enmCj6BUUrhWfyRsXjoNGkuvoN6NWK4DG3RhdEruN7+ir8dHWP+ ma/sfqshmFoX7ia3mIKJc7uqEKUT0K2ssHwKF1/FmJc9WkhN7pZWdFfNTOdYAoA05i2x vqhln29E1AlWi67hxvjpLYJZHDqDirNzpXGzcEk5Dg15k2AMSCtsJuE4ITZHA2IWF6yr mUGI3w728VlAjVURwbcwc7DCQgVT5Lj0yT8/X15XkT8G+8g26/29Hq/v6gPeN772Pplh 21UjXywAQyYYDr0k08ZXbsVRp0p75cnq74YJcGAuzjnduDiMHmv+BLsC5LLPKuP6NItI 3e9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TK9NlbTxDI56GHMUTG1tQI+3qAZA0g+0jgmSrxJAMJM=; fh=gYRgAXbu/FHO/Cqj/TKspqZnXUXsvaSPLTSdapZ7Ru0=; b=vUzhzg61+TWGQIRlvS+m3TOqNTvKR29a20MBoSmdXl9xVdKbQw7oOReBP4/na/Xm7j o3/mPmCidFHJisidnpUrM2AR0WDnuQvoHvQ1TDM6xCJfBaNpN3cJPawkdzHIFa9b6v6q FXFVQjYMQEZdI7hGn7/a9VWdZwsNxf3dBrOejtVuz4T6xtDaVFswhK/29lJaH9SsSXVC 7eLZxhz+inswvOl5gZldTutjbcLco+RFwuengEid/3QbjK0/N0uqAKjd1RF233rDciQN avbvj8S2NTwaKh7c7xcJEoH77hZ0L6JEyWj64ExG3GJiZ7nlpSJ/Bra8/tmnBBXn3wyv vsgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PnhH0gOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z14-20020a63c04e000000b005c6b4e4abe2si11857084pgi.169.2023.12.14.10.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:41:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PnhH0gOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C5414826FAC6; Thu, 14 Dec 2023 10:41:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573084AbjLNSlS (ORCPT + 99 others); Thu, 14 Dec 2023 13:41:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573124AbjLNSlP (ORCPT ); Thu, 14 Dec 2023 13:41:15 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE20D10F; Thu, 14 Dec 2023 10:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702579281; x=1734115281; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=spWRbrUoo3GHPvJawqTt5vlWN5LSpxWaXUCc4b6zvNY=; b=PnhH0gORm5FI1q/3PBOYd32mecI8eniLr8pY4AcSk/VWDVwYcZQAUY7e p6P/2ufKNHXggs5cnM3BR2Hyk0fpuXGmi0dAj7vKYN5F1xXKlPHzY5Uis mzFW96f1Fh8Imh1ilLtVFpLUCQUh7J97HLu9Gb6Z5GM2A787/YcC4ydRU F5W8G0Egq2QQ1W46bsVD/4czyB8UPcfMVvFUezuYUa/1lfTGqnaJtEAjI GpJC6FDtubAPr8c7WI2gz9/CZK6TVuRc+jd/UJPOfHqjvNBWtCywq9Ynm LuVi6GGVJCjNNH+b1WFlw0sm+aKo3ukErR5TRmcAWBphp+7hrBUhlWdtf g==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="461631068" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="461631068" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 10:40:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="803395262" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="803395262" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 14 Dec 2023 10:40:54 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3196E44F; Thu, 14 Dec 2023 20:40:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Patrick Rudolph , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 3/4] leds: max5970: Make use of dev_err_probe() Date: Thu, 14 Dec 2023 20:40:10 +0200 Message-ID: <20231214184050.1272848-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> References: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:41:28 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785283783284390630 X-GMAIL-MSGID: 1785283783284390630 Simplify the error handling in probe function by switching from dev_err() to dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/leds/leds-max5970.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-max5970.c b/drivers/leds/leds-max5970.c index de57b385b4f6..60db3c28d7d9 100644 --- a/drivers/leds/leds-max5970.c +++ b/drivers/leds/leds-max5970.c @@ -62,7 +62,7 @@ static int max5970_led_probe(struct platform_device *pdev) continue; if (reg >= MAX5970_NUM_LEDS) { - dev_err(dev, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS); + dev_err_probe(dev, -EINVAL, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS); continue; } @@ -86,8 +86,7 @@ static int max5970_led_probe(struct platform_device *pdev) ret = devm_led_classdev_register(dev, &ddata->cdev); if (ret < 0) { fwnode_handle_put(child); - dev_err(dev, "Failed to initialize LED %u\n", reg); - return ret; + return dev_err_probe(dev, ret, "Failed to initialize LED %u\n", reg); } }