Message ID | 20231214183946.109124-1-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8764462dys; Thu, 14 Dec 2023 10:40:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhTMXYJeFyjsj/pP/SiWTKibbpzQbelM3SRwG2gVSjLTDjBlpK6N5pyYCotvnKZ3OSHmGf X-Received: by 2002:a17:90a:730c:b0:28a:cbce:71ab with SMTP id m12-20020a17090a730c00b0028acbce71abmr2526771pjk.13.1702579201678; Thu, 14 Dec 2023 10:40:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702579201; cv=none; d=google.com; s=arc-20160816; b=oavZ8atzOCouiGSdVN2JDLKLjTxn2b29laXrSqcORIQLM8/QwRMY7A6LOZmuweP5xF Gsp90e6IcDyzmzVwO6cpYCE4hkGFhggs0FTUWzpPW2RkFNn4PmAUNdFc6JrHazXllk8A bdBs0pEZUFkNPMcvu0Iki4SHGkBhifS+hwlzsVGfD4uZTSCNl5PXB5FJLAA4nbIid1nR Ez2M1L5+ubOohCCFNvvIlxmxzkfWKelQDKJMrNNXSLcBzeq2nEy2+h0U/6RGKgIjL/yF HHnDM3HTo16blQYmI0WA8DAMi1VQ6N1bPfhZSfCvJRBja220+hTbD+9wuzpxkVf8tBYH EJxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3yhB6eTQ5FXZkMyUhaiKOlSz8sui2h6qSwLfyzOfMbo=; fh=fFpITan00wkAHxFKINrpH2e4BL1B8ibIImPYUNaRjsg=; b=RGAXlSSZheLM9teRkM57LilsW+anmkKN9zSmlSFfVl14p2QiI7ZvtU1Dz0k+B9egg2 HwqS9zr+KgmQ6J5hSNOdgTDrDUpLk1fssJ6pfdu9esbAW70b2JbBT5kuUZI330RkgWN7 uttPAT1yIQcNVU82B22v5e1FmHl7g/ujeVkiyfxqwmJeMZsKY7c+cuOsfeMutV3KLjtP cq/OW6lVwzxDF1J+VdijBzT85AtSNYADNp0hgBPA0kH5eMycgIPQ/Zl4CRiSVpf0QZAr ecCY2pQvQF7iE5YKxvuv3i5i//zUIzEFj/ubeYKJXL/LfieAIspQdyIsiRTd7T7y5ajR Duog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHi2piBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id mu15-20020a17090b388f00b00286b45aef08si11925995pjb.163.2023.12.14.10.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:40:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHi2piBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id F0ABB887B77A; Thu, 14 Dec 2023 10:39:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444201AbjLNSjq (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Thu, 14 Dec 2023 13:39:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjLNSjp (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 14 Dec 2023 13:39:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52891111 for <linux-kernel@vger.kernel.org>; Thu, 14 Dec 2023 10:39:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10639C433C7; Thu, 14 Dec 2023 18:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702579190; bh=XAEh20qvBS23cKK2nPKEFW+2DroDAYtyZm3Y94vZ9+A=; h=From:To:Cc:Subject:Date:From; b=hHi2piBsqatjGYdPPgiGCbp9w7BBK/xwFrUQBb+rtgAaG/vETqeooAc1UZ7ee7QYJ W0rhDWFTPwqi3ub3MIb8B78W82lCga7J7j1wn0VWqT0I0BA7AL2/ibudanRXXUPmSv P1OJPlUgDyMnZRCQ8k39mWRI2SPPLDvyI+3P5zkcoDBWcALRe+XQtCwnQ1XRNAkIQ1 H+tVZjntfe7p2l8TsPXKyhPIzn7RkbKLo8k2CK5fA0xjeLgLnC43LLt1mnothqO40R TEXEgfYaveQEXLYOBE9ZsESdOUbuOduV/lgyO2fHD+Bg43wWlThiytcGng/fF5phUH 219PfYxpUVRqw== From: Arnd Bergmann <arnd@kernel.org> To: Tomas Winkler <tomas.winkler@intel.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Wentong Wu <wentong.wu@intel.com>, Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Alexander Usyskin <alexander.usyskin@intel.com>, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] [v2] mei: fix vsc dependency Date: Thu, 14 Dec 2023 18:39:31 +0000 Message-Id: <20231214183946.109124-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:39:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785283688998565465 X-GMAIL-MSGID: 1785283688998565465 |
Series |
[1/2,v2] mei: fix vsc dependency
|
|
Commit Message
Arnd Bergmann
Dec. 14, 2023, 6:39 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> CONFIG_INTEL_MEI_VSC_HW can be set to built-in even with CONFIG_MEI=m, but then the driver is not built because Kbuild never enters the drivers/misc/mei directory for built-in files, leading to a link failure: ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] undefined! Add an explicit dependency on CONFIG_MEI that was apparently missing, to ensure the VSC_HW driver cannot be built-in with MEI itself being a loadable module. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/misc/mei/Kconfig | 1 + 1 file changed, 1 insertion(+)
Comments
> From: Arnd Bergmann <arnd@arndb.de> > > CONFIG_INTEL_MEI_VSC_HW can be set to built-in even with CONFIG_MEI=m, > but then the driver is not built because Kbuild never enters the drivers/misc/mei > directory for built-in files, leading to a link > failure: > > ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] > undefined! > ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] > undefined! > ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] > undefined! > ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] > undefined! > > Add an explicit dependency on CONFIG_MEI that was apparently missing, to > ensure the VSC_HW driver cannot be built-in with MEI itself being a loadable > module. > > Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks Reviewed-by: Wentong Wu <wentong.wu@intel.com> > --- > drivers/misc/mei/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index > 858bd701d68c..1e28ca23a74a 100644 > --- a/drivers/misc/mei/Kconfig > +++ b/drivers/misc/mei/Kconfig > @@ -62,6 +62,7 @@ config INTEL_MEI_GSC > > config INTEL_MEI_VSC_HW > tristate "Intel visual sensing controller device transport driver" > + depends on INTEL_MEI > depends on ACPI && SPI > depends on GPIOLIB || COMPILE_TEST > help > -- > 2.39.2
Hi Arnd, On Thu, Dec 14, 2023 at 06:39:31PM +0000, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > CONFIG_INTEL_MEI_VSC_HW can be set to built-in even with CONFIG_MEI=m, > but then the driver is not built because Kbuild never enters the > drivers/misc/mei directory for built-in files, leading to a link > failure: > > ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] undefined! > > Add an explicit dependency on CONFIG_MEI that was apparently missing, > to ensure the VSC_HW driver cannot be built-in with MEI itself being > a loadable module. Well, I don't see why someone would build mei as a module can mei-vsc-hw as builtin but the actual dependencies don't wouldn't prevent it. How about instead changing the Makefile in the parent directory so mei directory is always traversed? Either way, feel free to add: Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index 858bd701d68c..1e28ca23a74a 100644 --- a/drivers/misc/mei/Kconfig +++ b/drivers/misc/mei/Kconfig @@ -62,6 +62,7 @@ config INTEL_MEI_GSC config INTEL_MEI_VSC_HW tristate "Intel visual sensing controller device transport driver" + depends on INTEL_MEI depends on ACPI && SPI depends on GPIOLIB || COMPILE_TEST help