From patchwork Thu Dec 14 17:36:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Stark X-Patchwork-Id: 178837 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8718981dys; Thu, 14 Dec 2023 09:36:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFR2jSRkruCXVFl1eE3eFu1RGUn1j6xiKR2Zr1gN5fLbEADQ/0xpixAxJsTgIctM6WS2Kp1 X-Received: by 2002:a05:6a00:2d83:b0:6ce:7ef2:40b2 with SMTP id fb3-20020a056a002d8300b006ce7ef240b2mr6758199pfb.24.1702575397014; Thu, 14 Dec 2023 09:36:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702575397; cv=none; d=google.com; s=arc-20160816; b=e5UkL8GQFqDUHL519Thjk9iZKIekqG/vQubyuXJ3s1c6Dfm0EST007KcS5abCJJzk4 51jN2W33OS+Fg6G1T8cm/C0AqFsE9MIWozMMS3lxodSofs0sBLg4UtXZJvcJIzlQofDF OLtK9/oWGAR5w9kNbeWAoAoANUPGc8oT3meUOw5yn0ttzLOYQbcjW4fm3ZVbZYKyTVfL zYStpEY8+humECjTsh/Lu3PzXZOY+scPi/uZfmHgFEU30iI/VPcBXTKsjoOAYjCtkczd t/uy7IqcqouVlW/WO5wchdIp0CUpJXzVGbT/X6s8GeFxWRhVZpnC1yk5Z4KN07btfoNO I6ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=XoyXME9o9D+O65UPeU/S5jya+2cUqz9UKPsZ2HnPzAg=; fh=VGV6ajQ72e9w8REvYqgUr7SYaKNgFpS3GtVmljO5VrE=; b=zyrdNymlTK2J2HPz43CHdtHD3lOUkrO1pRWZ44ug2lZMr8eaeGCetQNEki7hGY3bYx OyNKtj4pDGOPy00Efvc51L1wvvh7mVBe/5AL9ao7soyONLi4snOMFZsWFy+VRQQqjdHz KZDdeOC+Owni1TmJsRICU/6BWGmOK7cBDkrYaCDl8sTMLiOM38B/Kn1H3J5vxmh0bInH HZ7uLP/asVgNgR8LskS0p5jfmY2Mr5SVcts3Vm5aMjg8UV9Yfmk7ryiOGThUz8+nClO5 3XgVgVRCgNoLjxl079yLhtOWKWWyVzZIGV+TKQ6tRjHD7fCOYQrGOq+nZ6b584MbLdZ1 zYzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=vCi4bvZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id y9-20020a63e249000000b005b9377ee20csi11641156pgj.701.2023.12.14.09.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 09:36:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=vCi4bvZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 60B1087943B1; Thu, 14 Dec 2023 09:36:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229464AbjLNRgY (ORCPT + 99 others); Thu, 14 Dec 2023 12:36:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbjLNRgV (ORCPT ); Thu, 14 Dec 2023 12:36:21 -0500 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15E8C10A; Thu, 14 Dec 2023 09:36:26 -0800 (PST) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 95ED0120019; Thu, 14 Dec 2023 20:36:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 95ED0120019 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1702575384; bh=XoyXME9o9D+O65UPeU/S5jya+2cUqz9UKPsZ2HnPzAg=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=vCi4bvZErRg01jC4xd0W/QPeuBrD/SimUzflI8WLiQp1BlY8YmmVD4QKXLIepve4/ kCuMnWkHmp/Dtuw7Uxwh5dhnZnMi8lhrow5CS9hN7OiYgIpXyPLztLlvAXK2un6Yae bMVVOFoQKY+N3IVSatOh0V3F8gE0fzJgv/Zh15rci/f5va/0vcwoC/b2S6zkS9Lx/c tkd0qyFX+KtE43nttyiBCb6GRnEKFf71OPyky6Ekxuu2mcj3LzA6plBKzDpuDGyy1X CPArSuUcixpoRcT3Nyhqs/KWvMQd6CspMpGt4x0gMOk2cdSgWra8sUXLc1kN6iC2Tc 9JYLV54Ou8f3w== Received: from smtp.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Thu, 14 Dec 2023 20:36:24 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 14 Dec 2023 20:36:24 +0300 From: George Stark To: , , , , , , , , , , , , , , CC: , , , , George Stark Subject: [PATCH v4 01/10] leds: aw2013: unlock mutex before destroying it Date: Thu, 14 Dec 2023 20:36:05 +0300 Message-ID: <20231214173614.2820929-2-gnstark@salutedevices.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214173614.2820929-1-gnstark@salutedevices.com> References: <20231214173614.2820929-1-gnstark@salutedevices.com> MIME-Version: 1.0 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 182125 [Dec 14 2023] X-KSMG-AntiSpam-Version: 6.1.0.3 X-KSMG-AntiSpam-Envelope-From: gnstark@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;smtp.sberdevices.ru:5.0.1,7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;100.64.160.123:7.1.2;127.0.0.199:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/12/14 10:50:00 #22693095 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 09:36:33 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785279699811359977 X-GMAIL-MSGID: 1785279699811359977 In the probe() callback in case of error mutex is destroyed being locked which is not allowed so unlock the mutex before destroying. Fixes: 59ea3c9faf32 ("leds: add aw2013 driver") Signed-off-by: George Stark Reviewed-by: Andy Shevchenko --- drivers/leds/leds-aw2013.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c index 59765640b70f..c2bc0782c0cd 100644 --- a/drivers/leds/leds-aw2013.c +++ b/drivers/leds/leds-aw2013.c @@ -397,6 +397,7 @@ static int aw2013_probe(struct i2c_client *client) regulator_disable(chip->vcc_regulator); error: + mutex_unlock(&chip->mutex); mutex_destroy(&chip->mutex); return ret; }