From patchwork Thu Dec 14 17:36:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Stark X-Patchwork-Id: 178845 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8719582dys; Thu, 14 Dec 2023 09:37:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxB25Lje5ZZq5YEd1AtCjJkfvst4XLmkU4fgGmNrCRPmbxbKF12Qai1GnMIxgJajYN83wE X-Received: by 2002:a05:6358:91a4:b0:170:d105:e788 with SMTP id j36-20020a05635891a400b00170d105e788mr6061285rwa.23.1702575453855; Thu, 14 Dec 2023 09:37:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702575453; cv=none; d=google.com; s=arc-20160816; b=H1Ao8TO4HOJjDMNduY8J7mBeMhJjGFkPITqTQ9Jij6wsczbcXNnriHVQxJ243PahAq zoj5TT34fbQ2tOAIXMR7ZczS3eImD0UAacBBhpg9pUkIZjD1OSz+cyzTZHi7sMFLkuuA 5akeBRj5m9btt3BlAG/0QlhMjTjJEhZD6QZGful+6hdP1ZHzgiB8T4mWM0fA7TK8lBJ6 kX24c5Bb5ajaQDqk6naXcbd4YZsEWd4004SfUHpkhD1m4sIhBLGhXUryrvrvuEFW/KG8 ei+Ghay0JOeCLOdyddWTeeBJ5Jo8NwYMJ88ZC2JNe5D8KK6ip34O0R/ah/V/CJ1YhUL2 s0OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=xznPFmv1qOhKYzpKJQ6sCA6HIF+5JBU12dpwjRIA9xM=; fh=VGV6ajQ72e9w8REvYqgUr7SYaKNgFpS3GtVmljO5VrE=; b=W29oxY3C2CIROECZ+npkfK/oqXOwvnm09983pZELq+Wch92uocDuZh5oM5ggaDW7St +3jSHsQ7BY8CEnJTwJWt5yGZRRNVNk6Kg/9WmMosOQfkJim7aXN8VjXuDumnTyaI1YWX 6J9R3E3kKQLRCV707JVMG8VXMoKn/KhePgzDQ0DY7NExZerMgkGBpNIPANK5VEkg8IoU mhlX6YrnuoCTusVnlBMKQjf6oDf2hDMC0EPM4bICObsNBP4Zx+GcddvQ5MfsdPUh2Fcr 0FpSE/0joej3njetsuQcHiTQL7Uy7B5n/cQlduJiZK7L4kz69DDzX4zP3TZBoSN1QtuE q6fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=qfz3GIWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id c20-20020a056a000ad400b006d0b39dfc2bsi4169208pfl.195.2023.12.14.09.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 09:37:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=qfz3GIWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A3830826EE01; Thu, 14 Dec 2023 09:36:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1572888AbjLNRgn (ORCPT + 99 others); Thu, 14 Dec 2023 12:36:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231394AbjLNRgV (ORCPT ); Thu, 14 Dec 2023 12:36:21 -0500 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF302122; Thu, 14 Dec 2023 09:36:27 -0800 (PST) Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 6457510002D; Thu, 14 Dec 2023 20:36:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 6457510002D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1702575386; bh=xznPFmv1qOhKYzpKJQ6sCA6HIF+5JBU12dpwjRIA9xM=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=qfz3GIWDZjqRCdeQPfdv3Xf3RXqyZq/uez32t4h876S/yBIx0ZF5P1z2XPEJd0jQR aTmLQWmicsGeKZU2oGJjKqoECzXOhdQbYXAuFWXDSZ+D2NzMlRDasw2OkXkUhujOEb i4MVVHUVpmygjDBQy8KmgiYQ6i85UC8P5oMrVzJcBJ53z4Nk8BGkf6EtXryo6LV1tm JbTsWmS3I0EprtkK9G7ImPV5jZwHDT9f70U8f0aXGJBktLt8Jlc1pr47RJ41jlV5OA 4O9iNf5hLubIStbhzl/2w/7jPK6W9gktH+Wr62oRvLKfacYkL8eQemJaTBhPwTSwVh 7ed0Aj6rnd8KQ== Received: from smtp.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Thu, 14 Dec 2023 20:36:26 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 14 Dec 2023 20:36:25 +0300 From: George Stark To: , , , , , , , , , , , , , , CC: , , , , George Stark Subject: [PATCH v4 09/10] leds: an30259a: use devm_mutext_init for mutext initialization Date: Thu, 14 Dec 2023 20:36:13 +0300 Message-ID: <20231214173614.2820929-10-gnstark@salutedevices.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214173614.2820929-1-gnstark@salutedevices.com> References: <20231214173614.2820929-1-gnstark@salutedevices.com> MIME-Version: 1.0 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 182125 [Dec 14 2023] X-KSMG-AntiSpam-Version: 6.1.0.3 X-KSMG-AntiSpam-Envelope-From: gnstark@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, smtp.sberdevices.ru:5.0.1,7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;salutedevices.com:7.1.1;www.alliedelec.com:7.1.1;100.64.160.123:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2023/12/14 14:24:00 X-KSMG-LinksScanning: Clean, bases: 2023/12/14 14:25:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/12/14 10:50:00 #22693095 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 14 Dec 2023 09:36:57 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785279759201752555 X-GMAIL-MSGID: 1785279759201752555 In this driver LEDs are registered using devm_led_classdev_register() so they are automatically unregistered after module's remove() is done. led_classdev_unregister() calls module's led_set_brightness() to turn off the LEDs and that callback uses mutex which was destroyed already in module's remove() so use devm API instead. Signed-off-by: George Stark --- drivers/leds/leds-an30259a.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c index 24b1041213c2..8f62c012c81a 100644 --- a/drivers/leds/leds-an30259a.c +++ b/drivers/leds/leds-an30259a.c @@ -7,6 +7,7 @@ // Datasheet: // https://www.alliedelec.com/m/d/a9d2b3ee87c2d1a535a41dd747b1c247.pdf +#include #include #include #include @@ -283,7 +284,10 @@ static int an30259a_probe(struct i2c_client *client) if (err < 0) return err; - mutex_init(&chip->mutex); + err = devm_mutex_init(&client->dev, &chip->mutex); + if (err) + return err; + chip->client = client; i2c_set_clientdata(client, chip); @@ -317,17 +321,9 @@ static int an30259a_probe(struct i2c_client *client) return 0; exit: - mutex_destroy(&chip->mutex); return err; } -static void an30259a_remove(struct i2c_client *client) -{ - struct an30259a *chip = i2c_get_clientdata(client); - - mutex_destroy(&chip->mutex); -} - static const struct of_device_id an30259a_match_table[] = { { .compatible = "panasonic,an30259a", }, { /* sentinel */ }, @@ -347,7 +343,6 @@ static struct i2c_driver an30259a_driver = { .of_match_table = of_match_ptr(an30259a_match_table), }, .probe = an30259a_probe, - .remove = an30259a_remove, .id_table = an30259a_id, };