From patchwork Thu Dec 14 14:46:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liang, Kan" X-Patchwork-Id: 178761 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8596198dys; Thu, 14 Dec 2023 06:46:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IES2niFyC+w3xyMyC1TuX2Vu00/FMSg3FvPJKLpJHDRM6xAfeJumklJ4xYbsUqEQY9vAdLx X-Received: by 2002:a17:902:d50d:b0:1d0:bfb7:6700 with SMTP id b13-20020a170902d50d00b001d0bfb76700mr14156484plg.58.1702565216196; Thu, 14 Dec 2023 06:46:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702565216; cv=none; d=google.com; s=arc-20160816; b=fl3hAWAjCq8Fs4aBQSLae3Dp3taWhZK+SR1RXEWd0nnRCcCKnN2V4cEtaTUAJ6Llxj jhkcC3LjTDpevb7QTm5Lf3jW77/RYACwdz0Ghws58pxugp6J2Khe6f2JdwmWrV/W/10k oXp1lxAqx4Dfm2OfGwZfeVb6RNfoLEmnq2aNU6DsPZSQUvPUFelmjRg/HHEFRn83YDIY XMGGx6yx8yPdHLKGFtuNAFGt1Xr4US0k1yentiSsudKWRFz9orc/NVkokHcaFSTsLvTU fAZ0M+Yi7mlWhTlJf6/D1hFMYAPBvW7/mZDau4fNcPmFBO/Sho2cnD3p4gQ2Ap5WTYol /0TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GxdaydlV2w8uFrzLyNbldk+hmhHXRcRUFEb/Xk2YyXQ=; fh=V97FFFi5RmpdUikarEoLTJWoOplAC1MpM9MGOX1xMoI=; b=A+dYUycQTqn95/2ThEtH5euwXSRtqbqRYzU2a6xyMvWPiSGkgozll/h4q4o/vDypMw msjMYozk4yer/gWlUDMpzNwsijN0++RB9FUlqV0/hipSkt+SurDYB1K5lowEXVk61hIN 3Iv5mR6B6kdsNlwiUdUEHV0FazW7jc6DzD1dLqs6Mt8mhH51EI99dUc0VSDe4yZ6+QHP BTrhC+mdyy8jrOItwmGpALfSXu3OQgO5WDS90bKHonUjAuKJ+jA6Pqrof6gIlgcZWj1h u/XdbLf9Wq+Pus6AgtDWhkXiH0I7iZM1r9iW4FIIE0PgQuIt/P0YeAwWFuQ16qX4sNj/ CaPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="OTFX2+/k"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id y24-20020a634b18000000b005c6b4e190absi11033030pga.502.2023.12.14.06.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 06:46:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="OTFX2+/k"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id DD242801B396; Thu, 14 Dec 2023 06:46:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230105AbjLNOqo (ORCPT + 99 others); Thu, 14 Dec 2023 09:46:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjLNOqm (ORCPT ); Thu, 14 Dec 2023 09:46:42 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9415F11D; Thu, 14 Dec 2023 06:46:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702565209; x=1734101209; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yNDl1AIWfRrLV+Gwxh9D4+zILF9whC0/B0msILdny9c=; b=OTFX2+/kwNA7oLgae0X1dxrrhj+m8T4ihA04GYgpa2RoXpRK4jdMZBlq QYnwWZcd4cXiILjpUxtGe5al5z6704UKZ12D2nZL6so62yeVKol871F0Y 5hao1C3UWWb3MKyQjMGaBrfqoQUs7n1hK2Aid7JMZlWzoGfbpjDGfTA9F ywg15vvVWhvsfRx42V+WglYrrGGA2POa2iiW7aQpaM81MYyB67Hdzhbny PG2SPDY6q0pPWYkZtyF23qmIdRW6H74LvXLKh58ODKXASNmBUdZNORKZo 7cnf1NWrKt70FvUk2noLLTbkbhH0aileoMXB5bRIT+eBGn5udSq8KXiZy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="16676490" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="16676490" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 06:46:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="22434527" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa001.jf.intel.com with ESMTP; 14 Dec 2023 06:46:45 -0800 From: kan.liang@linux.intel.com To: acme@kernel.org, irogers@google.com Cc: namhyung@kernel.org, mark.rutland@arm.com, maz@kernel.org, marcan@marcan.st, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Kan Liang Subject: [PATCH V4 1/2] perf top: Use evsel's cpus to replace user_requested_cpus Date: Thu, 14 Dec 2023 06:46:11 -0800 Message-Id: <20231214144612.1092028-1-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 14 Dec 2023 06:46:53 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785269023884690723 X-GMAIL-MSGID: 1785269023884690723 From: Kan Liang perf top errors out on a hybrid machine $perf top Error: The cycles:P event is not supported. The perf top expects that the "cycles" is collected on all CPUs in the system. But for hybrid there is no single "cycles" event which can cover all CPUs. Perf has to split it into two cycles events, e.g., cpu_core/cycles/ and cpu_atom/cycles/. Each event has its own CPU mask. If a event is opened on the unsupported CPU. The open fails. That's the reason of the above error out. Perf should only open the cycles event on the corresponding CPU. The commit ef91871c960e ("perf evlist: Propagate user CPU maps intersecting core PMU maps") intersect the requested CPU map with the CPU map of the PMU. Use the evsel's cpus to replace user_requested_cpus. The evlist's threads are also propagated to the evsel's threads in __perf_evlist__propagate_maps(). For a system-wide event, perf appends a dummy event and assign it to the evsel's threads. For a per-thread event, the evlist's thread_map is assigned to the evsel's threads. The same as the other tools, e.g., perf record, using the evsel's threads when opening an event. Reported-by: Arnaldo Carvalho de Melo Closes: https://lore.kernel.org/linux-perf-users/ZXNnDrGKXbEELMXV@kernel.org/ Reviewed-by: Ian Rogers Signed-off-by: Kan Liang --- No changes since V2 tools/perf/builtin-top.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index ea8c7eca5eee..cce9350177e2 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1027,8 +1027,8 @@ static int perf_top__start_counters(struct perf_top *top) evlist__for_each_entry(evlist, counter) { try_again: - if (evsel__open(counter, top->evlist->core.user_requested_cpus, - top->evlist->core.threads) < 0) { + if (evsel__open(counter, counter->core.cpus, + counter->core.threads) < 0) { /* * Specially handle overwrite fall back.