diff mbox series

[01/11] crypto: qce - Add support for crypto address read

Message ID 20231214114239.2635325-2-quic_mdalam@quicinc.com
State New
Headers
Series Add cmd descriptor support |

Commit Message

Md Sadre Alam Dec. 14, 2023, 11:42 a.m. UTC 
  Get crypto base address from DT. This will use for
command descriptor support for crypto register r/w
via BAM/DMA

Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---
 drivers/crypto/qce/core.c | 9 +++++++++
 drivers/crypto/qce/core.h | 1 +
 2 files changed, 10 insertions(+)

Comments

Sricharan Ramabadhran Feb. 21, 2024, 6:02 p.m. UTC | #1 
On 12/14/2023 5:12 PM, Md Sadre Alam wrote:
> Get crypto base address from DT. This will use for
> command descriptor support for crypto register r/w
> via BAM/DMA
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
>   drivers/crypto/qce/core.c | 9 +++++++++
>   drivers/crypto/qce/core.h | 1 +
>   2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
> index 28b5fd823827..5af0dc40738a 100644
> --- a/drivers/crypto/qce/core.c
> +++ b/drivers/crypto/qce/core.c
> @@ -192,6 +192,7 @@ static int qce_crypto_probe(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
>   	struct qce_device *qce;
> +	struct resource *res;
>   	int ret;
>   
>   	qce = devm_kzalloc(dev, sizeof(*qce), GFP_KERNEL);
> @@ -205,6 +206,14 @@ static int qce_crypto_probe(struct platform_device *pdev)
>   	if (IS_ERR(qce->base))
>   		return PTR_ERR(qce->base);
>   
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

  Can this be combined with devm_platform_get_and_ioremap_resource ?
> +	if (!res)
> +		return -ENOMEM;
> +	qce->base_dma = dma_map_resource(dev, res->start, resource_size(res),
> +					 DMA_BIDIRECTIONAL, 0);

  unmap in remove and error cases ?

Regards,
  Sricharan
diff mbox series

Patch

diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
index 28b5fd823827..5af0dc40738a 100644
--- a/drivers/crypto/qce/core.c
+++ b/drivers/crypto/qce/core.c
@@ -192,6 +192,7 @@  static int qce_crypto_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct qce_device *qce;
+	struct resource *res;
 	int ret;
 
 	qce = devm_kzalloc(dev, sizeof(*qce), GFP_KERNEL);
@@ -205,6 +206,14 @@  static int qce_crypto_probe(struct platform_device *pdev)
 	if (IS_ERR(qce->base))
 		return PTR_ERR(qce->base);
 
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return -ENOMEM;
+	qce->base_dma = dma_map_resource(dev, res->start, resource_size(res),
+					 DMA_BIDIRECTIONAL, 0);
+	if (dma_mapping_error(dev, qce->base_dma))
+		return -ENXIO;
+
 	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
 	if (ret < 0)
 		return ret;
diff --git a/drivers/crypto/qce/core.h b/drivers/crypto/qce/core.h
index 228fcd69ec51..25e2af45c047 100644
--- a/drivers/crypto/qce/core.h
+++ b/drivers/crypto/qce/core.h
@@ -39,6 +39,7 @@  struct qce_device {
 	struct qce_dma_data dma;
 	int burst_size;
 	unsigned int pipe_pair_id;
+	dma_addr_t base_dma;
 	int (*async_req_enqueue)(struct qce_device *qce,
 				 struct crypto_async_request *req);
 	void (*async_req_done)(struct qce_device *qce, int ret);