From patchwork Thu Dec 14 05:58:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= X-Patchwork-Id: 178464 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8342532dys; Wed, 13 Dec 2023 22:00:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFphWq+7lUccBmmzKB/76dWJ/cS2xudXzr1eJptbqe9S4R4vI8eHBr4eanppb4OuuKmLqEJ X-Received: by 2002:a05:6808:3998:b0:3b5:6533:d2cb with SMTP id gq24-20020a056808399800b003b56533d2cbmr14409959oib.46.1702533649416; Wed, 13 Dec 2023 22:00:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702533649; cv=none; d=google.com; s=arc-20160816; b=vfGx5n4YB6FqrrBCCWY3+vE9XdQYDNzwQbxJOh23F+NemJDuMOU5OhZGqVTtoRN4UI BCnFnitqP0sLEUoiG1QTR3NfOiyw4PwSRj3y/zT9/FPc+Afkyc/NKsFO5/uh1dpS/deR +V2q3dCn8MVgqOkqaPNWNc85T1iQWr1jcfROr9a02hde8ObLL8t0Lo+yBAp3W2ZIIH/8 iNCiJvUn8ajLJA41PbTdifvQzw76ioxUftmA/khTZStuayUuJTc63woep+sIVWnYIhK5 263t3IZwlk16lmRUuX3iW5rvoj61Z84j+Pcq6TL44Ujgp1pR1Xt3SvAmWOkbe74tXK8b 0nHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=oJfBuNs5CQVV6xVH9uI2l5Zhh/Zkz+YUizumLpm/ecc=; fh=3sxgsd2Uw0IiS0u77AMxpPqPOsrCjkgXK0HsUFuBxjc=; b=aEFAUOHBwOec4GBYXOlM81J7jt2JwOwg6cVXg23bDKUYfJVjQ47H0+2qNMlXs1/hz/ lrn2L5Wk4LgaxBfnC0pejHxLkeoU9g7xs9bF6jEVFhDKs8Oxrt96kNnZlEIw8AuMIHXt HopztDnVD+/7AspaKQfa8KPK/ulgeB8d2bjKtjb1kWnn1QzM//xMxDJyOqq3aPTMyRK8 a1BCpOhQeUg9l71jgdd5VMZWigyAYdsGGNmxSFyIXVQejIdQ983ux14DvC5PM7kaU1/1 Bj/1VD6UrTTIawoZlvh/l9vbrmPaN6IBWHMReaBRFhuHuUnMDmEtcGnAW1hMT937YT+k sP0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=Qo8AmcdT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id c34-20020a634e22000000b005c6921c1cddsi10618992pgb.143.2023.12.13.22.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 22:00:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=Qo8AmcdT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0ECA5802A7CF; Wed, 13 Dec 2023 22:00:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbjLNGAb (ORCPT + 99 others); Thu, 14 Dec 2023 01:00:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231465AbjLNF7r (ORCPT ); Thu, 14 Dec 2023 00:59:47 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D6218C; Wed, 13 Dec 2023 21:59:01 -0800 (PST) X-UUID: dc0856a49a4511eeba30773df0976c77-20231214 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=oJfBuNs5CQVV6xVH9uI2l5Zhh/Zkz+YUizumLpm/ecc=; b=Qo8AmcdTxSb0FpBMqJSAu7j4ro+gERGGm0tVE9WvKugWIJzUYEKVGHfdzJ5k0XLFFN5DthdWZTbhx+LP3v0wvrDCKXZ1qY1x4e4i6mFVjiM3Pf7amLtFWLJaJKHgb2sHN8o1eSxka3DFOycDfs/UbMuwhwAawlfu6GyTdlCDhsc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:be3c8410-d9bc-4ccf-967c-ef2ae4404f3d,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:8f3c29bd-2ac7-4da2-9f94-677a477649d9,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR: NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: dc0856a49a4511eeba30773df0976c77-20231214 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1108900180; Thu, 14 Dec 2023 13:58:53 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 14 Dec 2023 13:58:51 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 14 Dec 2023 13:58:51 +0800 From: Hsiao Chien Sung To: AngeloGioacchino Del Regno , CK Hu CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Moudy Ho , Hsiao Chien Sung , Nathan Lu , "Nancy . Lin" , "Roy-CW . Yeh" , "Jason-JH . Lin" , xinlei lee , , , , , Subject: [PATCH v12 20/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock Date: Thu, 14 Dec 2023 13:58:44 +0800 Message-ID: <20231214055847.4936-21-shawn.sung@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20231214055847.4936-1-shawn.sung@mediatek.com> References: <20231214055847.4936-1-shawn.sung@mediatek.com> MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 22:00:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785235923484348586 X-GMAIL-MSGID: 1785235923484348586 Return the result of clk_prepare_enable() instead of always returns 0. Fixes: f8946e2b6bb2 ("drm/mediatek: Add display MDP RDMA support for MT8195") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c index dc7c9e991990..ee9ce9b6d078 100644 --- a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c +++ b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c @@ -262,8 +262,7 @@ int mtk_mdp_rdma_clk_enable(struct device *dev) { struct mtk_mdp_rdma *rdma = dev_get_drvdata(dev); - clk_prepare_enable(rdma->clk); - return 0; + return clk_prepare_enable(rdma->clk); } void mtk_mdp_rdma_clk_disable(struct device *dev)