From patchwork Thu Dec 14 18:13:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 178856 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8746213dys; Thu, 14 Dec 2023 10:14:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHIdxZ30IPJVKxHl5BSY1z9p9Yq/i30Um+W9fuuOJmM8BzgTPZFf2IBDURu3H7wTgAkI82F X-Received: by 2002:a17:90b:118d:b0:28a:2fd5:be04 with SMTP id gk13-20020a17090b118d00b0028a2fd5be04mr4744708pjb.96.1702577646113; Thu, 14 Dec 2023 10:14:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702577646; cv=none; d=google.com; s=arc-20160816; b=SoMLg8sgJ3onV93IHuETgPgDkr196GJEcJwHNi4bom9hsPErgg/cZMCwGjAY8hiwOB ybMHWnCTdhgWU3Wj82x4fVg+etQIAmRsnlK8vw5Z6/glPVddJ7uEMIytRyM73tf7+F95 sXJ5QO9Nl5F7l/31Kz0SO/iKKvrnsaHjqktwF0PzPvmW+LnwwKnxuVLgnHI5oZ54Euz7 iIZp0wFrHwIVyjJS1o2qY/ur2iY9yF+gk4/9AfdZcU91qXqyXnLZIeqqGUQG9nfScjhg BHmYFTqljruGgTCyOnEqMAh2OHsSR+qwqGHBEzkzZMBHdjw6YzV9eZMkZzDNmWb847XS FwrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=tC67f/rlpMpveywW17PnxYzUi/Glfsd8AP6R8y378/w=; fh=dfDqGbBeMZjUVur2fg1W1ZcaYM9WPbnvbDrAlyrs4+g=; b=xnWfnhtmLH9wFetV+L8Jpd7RLwpkrZfiSzYGA3kmFbrkg4GeC9/R45g96FqzShJV5x W0hITSQn3xr7OB89Gve3t60/qmBk3bmlBL1H9aD1er7KzRg2mf2/sB5EjUw1laufrf7s yjVpSc8zhmionaqVEdrr/Wk9MC1iMW5kUJfPoOsi+vD0fKVSKbAF8c7I8vZPLyPWKvG9 xJh91r3YB/0LA96Ly8Gf4VWn1OOFfowmV4UfFcMClJqODsNNzoCy7FJj/ovnvWQR0neo dDCHxNSnak3/EdL/kUijA04OEoIYFo0fpunrUaYTvehaiI1azpSJoaeNLUrcqa3q3JNG dRng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cln9RAwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id br12-20020a17090b0f0c00b00286b69fb2d3si11775620pjb.87.2023.12.14.10.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:14:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cln9RAwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 05B6580E06BB; Thu, 14 Dec 2023 10:14:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573037AbjLNSNw (ORCPT + 99 others); Thu, 14 Dec 2023 13:13:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1572979AbjLNSNs (ORCPT ); Thu, 14 Dec 2023 13:13:48 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D39A8116 for ; Thu, 14 Dec 2023 10:13:54 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c9f7fe6623so106465771fa.3 for ; Thu, 14 Dec 2023 10:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702577633; x=1703182433; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tC67f/rlpMpveywW17PnxYzUi/Glfsd8AP6R8y378/w=; b=cln9RAwOuYvElTMK4ZHTDkUWfsbWwFug/0gLM48BVqe9c6QtQL8d9P4JKqLe1hEtuc QJ2xdK7cQvgcQUO3KCZrlCH5oRQZwd/kNFtTWC+C7LozGH1a7Xh9qnvmAr4aJ9uEZbDR tcvvQsU+wQVr/Klc22LHK4bnrklt/RnBCWJkXF2CL3y6pQlkvkYz/xa016kcrsEi0gdp lxJaGiQAiy0FMZrlWpXBNW+8kI3Bs2Lh3UlUJYr8Joxp57ZdVTjLANCqiXt5/X1KrKCF WDXTWEMecEsbXerEop1GPTjDscfSl/YAQITgPRJVKRx3h2vC8fbpau5kFo8U3/eDW+7A vxJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702577633; x=1703182433; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tC67f/rlpMpveywW17PnxYzUi/Glfsd8AP6R8y378/w=; b=CjHseFWyzd0khPIxnbjatws5w2vncNX4rU+DZIA/CRw175g1wea5MDbDh8qwS79Vgz ymBvdB/KVIYoxcFW3kGeYxrxeQBLnrbKSvq0dUElEwG9xZbf/4S0XAw07zuUX5nIRULl NBbKTu66mqgjjYGnOk2ZRIc5BGyXGTLfaj5vnMSGsnwDvuJu9LyMzNlrmgx1ePAN1hCA X9X7JMup93eWMURaOx6UoI5wXDQ2FHBuFZrmaLknwSR4SNvlILwLR/SCrVhXmNBzulaL WZhWUzSHyKRtLD44q7bmQpdGkWYXddoMVB5TKQT/zf7jWmZKgHgnqTjFlhVMZDNgVy/V vR5w== X-Gm-Message-State: AOJu0YxFjulNxc6mwQFoK+RN6hiwWL0o8q3ntdPM8ubF3rqc2LuzZ5a+ WCvgoNcbX6Ueo5aZ1XjpcN4HtA== X-Received: by 2002:a19:8c1c:0:b0:50b:ef5a:d022 with SMTP id o28-20020a198c1c000000b0050bef5ad022mr2770578lfd.41.1702577633070; Thu, 14 Dec 2023 10:13:53 -0800 (PST) Received: from [127.0.1.1] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1928838lfu.48.2023.12.14.10.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:13:52 -0800 (PST) From: Konrad Dybcio Date: Thu, 14 Dec 2023 19:13:40 +0100 Subject: [PATCH 3/6] arm64: dts: qcom: sc8180x: Add missing MDP clocks MIME-Version: 1.0 Message-Id: <20231214-topic-sc8180_fixes-v1-3-421904863006@linaro.org> References: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> In-Reply-To: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maximilian Luz , Gustave Monce , Konrad Dybcio X-Mailer: b4 0.13-dev-0438c X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:14:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785282057992565100 X-GMAIL-MSGID: 1785282057992565100 The ROT clock is required for the MDP block to function (looks like some others depend on it), and whike the LUT clock's purpose is not clear, it's likely better to turn on all of MDP's dependencies rather than not doing so. Add these clocks under the MDP node. This also makes Primus work without clk_ignore_unused (as far as the dmesg-visible errors go, anyway). Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 09b4e66367bf..c970dfb11fe5 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -2702,11 +2702,15 @@ mdss_mdp: mdp@ae01000 { clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, <&gcc GCC_DISP_HF_AXI_CLK>, <&dispcc DISP_CC_MDSS_MDP_CLK>, - <&dispcc DISP_CC_MDSS_VSYNC_CLK>; + <&dispcc DISP_CC_MDSS_VSYNC_CLK>, + <&dispcc DISP_CC_MDSS_ROT_CLK>, + <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>; clock-names = "iface", "bus", "core", - "vsync"; + "vsync", + "rot", + "lut"; assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>, <&dispcc DISP_CC_MDSS_VSYNC_CLK>;