Message ID | 20231214-dipper-earshot-72eef3059961@spud |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8457961dys; Thu, 14 Dec 2023 03:01:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1KpD4/PvL6hSP63DISLdHDKgALAT0DSjrN4G/DgFT+3jD25dT2Orx5S11l2TTXmUJP+B9 X-Received: by 2002:a17:903:2442:b0:1d3:55ad:7609 with SMTP id l2-20020a170903244200b001d355ad7609mr1339653pls.76.1702551709383; Thu, 14 Dec 2023 03:01:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702551709; cv=none; d=google.com; s=arc-20160816; b=Uj14yW+EAjsp9ZHMH4Sv4CKfBLESj6KP/uOYm7JJXjFVSODzqsJWjbjErxkiy/Ucyz 7yH4EX9JnZCdmyH6+KRjLI0YEp3fklCEXi9J8TEN2F/sZoQKMHrp0GW05Ws8+1SarB7R Zv9BpU/R+KRxUBrCScJRdBoS+YhTrAYPY+l6mELornWGg/IrG9yMO6euK4zVhLz6jZIJ mBTaV/X1PgZ/5EwxpCHbOml56kibpKsgMUJD2nUxTx03S8Qz2865Fm8VzeSVuPAPOig/ T6GsAJ+UePFY9J22sNXHop0WjPEFwXq8PCLWOZ+9TbMvtZ5FWCtmbYAgwyc4mJa4FY+Y gNOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=09T1FhbHQr39VltUpuAp1yvPgXuLtzX0Yd51UFCcwt4=; fh=devg2Zpp7RD1xu+2L3lk/2fPMEAtt+HYz/Qp/3dl3yk=; b=SVZY2LrI6cboYd+SXIWNBXxWOAnko790GLgdkoYrWEzupHgfiKa1PWghwrwcPzitX9 iRWyJM+T5KSQt0uQL7w8zkZ0GaB1m9Hb0J4+C9IXNGvi/MKyk1fc2vf2i+RdRZXtr5/h 05E/EIROZ5S7yS2Wn5xL62NTGrPhomo4thSGF1mEWEADleqgbjK/7HiM8EgcGpV8eNEz 41X2/7aGe3xbW/reZFtLWokZbLFT62eo0JIWFW3Ci5ssvT/NVYNBxHoy6vdEyc5U/JEp EVFSERhzkBrzBbZp1myXelbH1qII+o+MsierzIRr7OCZcOTtW1SfswBFOZS3aeDJKHCa jTVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aymJVjGZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u9-20020a17090341c900b001cfd5a36b31si11338736ple.495.2023.12.14.03.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 03:01:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aymJVjGZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 158188339653; Thu, 14 Dec 2023 03:01:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443855AbjLNLBT (ORCPT <rfc822;dexuan.linux@gmail.com> + 99 others); Thu, 14 Dec 2023 06:01:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443836AbjLNLBQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 14 Dec 2023 06:01:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2095812C for <linux-kernel@vger.kernel.org>; Thu, 14 Dec 2023 03:01:22 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC7ECC433C7; Thu, 14 Dec 2023 11:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702551681; bh=yWvb1FzC/LQ0zIM53RNXJVNdCzBlRFmPP4IvR0lED6w=; h=From:To:Cc:Subject:Date:From; b=aymJVjGZ0c6Wz8Q/9vkMjqb9E9hqLcaMz4j481/++0UIev0aRRPySnWl/1j04B+mj Dq++vUTOx5NgqQ+ffd5uv3NhDYtpxjAvu6pb3tih8nN9YnnPI9gcXX1tlvq+HXorqc cjS9CP43GzjwxnU2uVBRMPBSz6CYXi5GHV0izKwBoOQeKW4GLgarZ7ORyX/1IHvehK OmvBzKO418z3dIrLO9+ExYGyAowAuJ5+Lhqbgfm/EGvvaiTqL/id3M0H9jhOuKWedO 7uWkY4B6rNwzNXXLiHtAmNfEeb52ZEDKALw6dVebwJ/v1FNpyjf1Hjkh0oWkB9dkAe AbIdtAqLOkVGA== From: Conor Dooley <conor@kernel.org> To: linux-riscv@lists.infradead.org Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>, Al Viro <viro@zeniv.linux.org.uk>, Daire McNamara <daire.mcnamara@microchip.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h Date: Thu, 14 Dec 2023 10:59:57 +0000 Message-Id: <20231214-dipper-earshot-72eef3059961@spud> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1199; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=uthDO4MEgzFI/RKi4V+giwgtXg1nFE5ZOPfmIqVEYHc=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDKlVD7Rr5ubMtU/Uc2Zf+bVZ/Njua47TKsLWcJsL2ueLb H96YsfpjlIWBjEOBlkxRZbE230tUuv/uOxw7nkLM4eVCWQIAxenAExEn5+R4XGtr+2aPxKuz3Jv nAl9wvZTm0nkoOCkpKv/PDrz1Z9WMjH8j/8bee3i9YX/8k/Ni9Pp5GQJKmSsNj4kwPbEIKGopOI oEwA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Dec 2023 03:01:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785254861384515793 X-GMAIL-MSGID: 1785254861384515793 |
Series |
[v1] clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h
|
|
Commit Message
Conor Dooley
Dec. 14, 2023, 10:59 a.m. UTC
From: Conor Dooley <conor.dooley@microchip.com> As evidenced by the fact that only 2 other drivers include this header, it is not a normal thing to do. Including the regular version of this header is far more conventional for drivers. CC: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> -- CC: Conor Dooley <conor.dooley@microchip.com> CC: Daire McNamara <daire.mcnamara@microchip.com> CC: Michael Turquette <mturquette@baylibre.com> CC: Stephen Boyd <sboyd@kernel.org> CC: linux-riscv@lists.infradead.org CC: linux-clk@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/clk/microchip/clk-mpfs-ccc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Dec 14, 2023 at 10:59:57AM +0000, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > As evidenced by the fact that only 2 other drivers include this header, > it is not a normal thing to do. Including the regular version of this > header is far more conventional for drivers. ACK. Includes of asm-generic/anything.h are fine in arch/*/include/* and (under some circumstances) in include/*; anywhere else they are very dubious, including outright bugs (io_uring/uring_cmd.h include of asm-generic/ioctls.h, for example).
Quoting Conor Dooley (2023-12-14 02:59:57) > From: Conor Dooley <conor.dooley@microchip.com> > > As evidenced by the fact that only 2 other drivers include this header, > it is not a normal thing to do. Including the regular version of this > header is far more conventional for drivers. > > CC: Al Viro <viro@zeniv.linux.org.uk> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > -- > CC: Conor Dooley <conor.dooley@microchip.com> > CC: Daire McNamara <daire.mcnamara@microchip.com> > CC: Michael Turquette <mturquette@baylibre.com> > CC: Stephen Boyd <sboyd@kernel.org> > CC: linux-riscv@lists.infradead.org > CC: linux-clk@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- Applied to clk-next
diff --git a/drivers/clk/microchip/clk-mpfs-ccc.c b/drivers/clk/microchip/clk-mpfs-ccc.c index bce61c45e967..3a3ea2d142f8 100644 --- a/drivers/clk/microchip/clk-mpfs-ccc.c +++ b/drivers/clk/microchip/clk-mpfs-ccc.c @@ -4,8 +4,8 @@ * * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries */ -#include "asm-generic/errno-base.h" #include <linux/clk-provider.h> +#include <linux/errno.h> #include <linux/io.h> #include <linux/module.h> #include <linux/platform_device.h>