From patchwork Wed Dec 13 22:42:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 178335 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8139400dys; Wed, 13 Dec 2023 14:43:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZkW55IEBOi3c14Vy4w0R6qRrk13yg8D1VvYiPw4qr0fRJLeudFuFUZObX2lqcK+Qsxlhk X-Received: by 2002:a05:6870:3d96:b0:203:1c21:75e7 with SMTP id lm22-20020a0568703d9600b002031c2175e7mr3069076oab.53.1702507402989; Wed, 13 Dec 2023 14:43:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702507402; cv=none; d=google.com; s=arc-20160816; b=0qy15dRUoiPqMPaDChMRPGRVEsYCWm1cjFj+HbcC8g1vTPrQtaXSPvGwyeb98SEsiv 2HPlrG3d0/xeUNl/Ha7gDMWfhnDLftVOmbyLhqn2YFibS0peCOBfLcYKpZe7dqXZPCkw A54TpYwEsGOhZd2WsXs5VwcfvbWvTYVxA7oo0vN2+tAmK/zZRlmkB2TbUD/kn918g9Ns wH49C9al5dqBKOaBmXXoRlPnyOJ/spjKmaoQyRuTvRxyzPZZcaXIbD1FsOMoRKPp/pl1 FWGYH0dPUTX37zXxglQo617QOIUrJeA0BSwbGf04EXdkRO9c/894XfNFy0hHJWhwLkUe X9zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FW/pmmw2V+DW6nT308vGzDaKBo2V/WiIuPZcl8Qc+Ug=; fh=6u4iCdsiL+O8kzgCbEy+6bE8fIO6yRYtBymUyiInndE=; b=uLPTSKdvUdbuPr8JVSxRqIJJSGEz5r/EjzLLM7N8zYOq4lz05VHb/cFSPD+j4Kq67X UIBwjFxYaotJfm7SRMIyq6hxstz72/OYtczKmqKmLvCHhtuQacN79E+GFzJ3t+g86X3B QHmYzc8N+4LOKpZ0k/3kCA9FAErrQ28CJrmBG35ORX3xJ4l8UKimEQMRc/FO64Fi+x0o 3kqbzFMF1zEQnF8VdorZC722oqXlkApXzvNXYzU5Rw5jXAdNYajKGPj/BYjS6738Fykn vXCRVxiK7MxHNmZ9zBJMvIG9S72RKLQGO1T5FX2UKz6fOIRb7kwudaPKUA2jYjGEsZPx JvGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bv9-20020a17090af18900b0028b0841c36fsi54391pjb.117.2023.12.13.14.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 14:43:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2F1C9802C7DB; Wed, 13 Dec 2023 14:43:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442841AbjLMWnK (ORCPT + 99 others); Wed, 13 Dec 2023 17:43:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442836AbjLMWnA (ORCPT ); Wed, 13 Dec 2023 17:43:00 -0500 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CAB0D5A; Wed, 13 Dec 2023 14:42:36 -0800 (PST) Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5913e3a9e05so1448353eaf.1; Wed, 13 Dec 2023 14:42:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702507356; x=1703112156; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FW/pmmw2V+DW6nT308vGzDaKBo2V/WiIuPZcl8Qc+Ug=; b=vUUA+SuwjoKWSZNJoPn2tjGdbjAES65/oCF4QfLYaMxUIWQKvHNeNJ6EHQ749XkiOd fKSnafTNHU5iUVE1VBsGKkRznGwCzbrCY45PeVp7SeRIokQGpnOhHMTSbFy7MX8YTCqD o0VcceyI9gZnGqxHQ3LnFxdcQa3My7wYjTPd2bvvm3TCe5F+8L/MFJRpx4aw54uo4WCc fhC8fz4eFPVpv81c0tIuwyWYipfBPnkpAxlVfSsZisjaxtDvyHNgTIWhEqkhTjoTi+Di bKoY/OywjzB7gR9Hs87VpeA1nKcqE35u/AvLkCqftkDLVT+MC56paUE/Qm3kbQk6HiXA 3EZw== X-Gm-Message-State: AOJu0YxZmN7opb2o27sMNkegmmT8UWYqvCaTnAQJnljiQJg7wMXTPVJ3 KiB8DgBYQjW/0Hdl+7ulig== X-Received: by 2002:a4a:245c:0:b0:590:9a90:16d with SMTP id v28-20020a4a245c000000b005909a90016dmr5562296oov.5.1702507355754; Wed, 13 Dec 2023 14:42:35 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j11-20020a4ad2cb000000b005907ad9f302sm3233886oos.37.2023.12.13.14.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 14:42:35 -0800 (PST) Received: (nullmailer pid 2192084 invoked by uid 1000); Wed, 13 Dec 2023 22:42:34 -0000 From: Rob Herring To: Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Marek Szyprowski , Aakarsh Jain Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: dt-bindings: samsung,s5p-mfc: Fix iommu properties schemas Date: Wed, 13 Dec 2023 16:42:26 -0600 Message-ID: <20231213224227.2191897-1-robh@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 14:43:22 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785208402378098009 X-GMAIL-MSGID: 1785208402378098009 The iommus and iommu-names property schemas have several issues. First, 'iommus-names' in the if/then schemas is the wrong name. As all the names are the same, they can be defined at the top level instead. Then the if/then schemas just need to define how many entries. The iommus if/then schemas are also redundant. Best I can tell, the desire was to require 2 entries for "samsung,exynos5433-mfc", "samsung,mfc-v5", "samsung,mfc-v6", and "samsung,mfc-v8". Signed-off-by: Rob Herring --- .../bindings/media/samsung,s5p-mfc.yaml | 29 +++++++------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml index 084b44582a43..a970d80692d3 100644 --- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml +++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml @@ -49,7 +49,9 @@ properties: iommu-names: minItems: 1 - maxItems: 2 + items: + - const: left + - const: right power-domains: maxItems: 1 @@ -84,7 +86,7 @@ allOf: - const: sclk_mfc iommus: maxItems: 1 - iommus-names: false + iommu-names: false - if: properties: @@ -102,11 +104,9 @@ allOf: - const: aclk - const: aclk_xiu iommus: - maxItems: 2 - iommus-names: - items: - - const: left - - const: right + minItems: 2 + iommu-names: + minItems: 2 - if: properties: @@ -123,11 +123,9 @@ allOf: - const: mfc - const: sclk_mfc iommus: - maxItems: 2 + minItems: 2 iommus-names: - items: - - const: left - - const: right + minItems: 2 - if: properties: @@ -144,11 +142,9 @@ allOf: items: - const: mfc iommus: - maxItems: 2 + minItems: 2 iommus-names: - items: - - const: left - - const: right + minItems: 2 - if: properties: @@ -161,9 +157,6 @@ allOf: clocks: minItems: 1 maxItems: 2 - iommus: - minItems: 1 - maxItems: 2 examples: - |