From patchwork Wed Dec 13 19:51:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Bee X-Patchwork-Id: 178277 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8030479dys; Wed, 13 Dec 2023 11:52:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrwjNN8aYK8j0m1Tv4T9DA4TynGqJitYM06VXNUdbEAtK4xdrIDfoiY2x8VRWplvZ56ph2 X-Received: by 2002:a05:6a20:728f:b0:18c:30:f408 with SMTP id o15-20020a056a20728f00b0018c0030f408mr11913266pzk.0.1702497125402; Wed, 13 Dec 2023 11:52:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702497125; cv=none; d=google.com; s=arc-20160816; b=Gpx2ZsylD42qxcX7mpgESWQa37V3GhQ2XpDO9b2Lrda8cvsQOFcPQR2ZPTF/Fop8w2 +/mWIdgjLGpqbJYs6jsyry6CQJNjMnS6g1BOCytU2Q3XSWiAXZTQBsN/YSoS1cnIMvvN JA+gl4NLgNkHbezudWs5NcnSBxbFxn6dmmRPhivTCxuw5JHBidQyMY4JlMwsS88nEp1b 3lOHk2v8SbUet/gwFCPMKJ6wA0K8ZNHE5seIoWzyVkxcgnoFoqVvjZa6nRjyy1uSCzPr JJ6vxqWNaokk2CW3SwA7w4kJN0btMLqR9nmsEdGRtojmORREg1DJXNOwzH7Zn8oW76Or Fv5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SDq2fLVuR6T1GPARTMOS6b3H20znzfoIBUzVKBtShU4=; fh=nzMX5Jolb3GculGR3f1Z1ReHOqdNjcdazDY5R3X+7M0=; b=LeDxmc0pJ94B2D2ghDArXxAvkl2fYgUQxvCVLFp9iU8HxmcKNJz0ptptEvm0qQG6JN OdYVD3ak1UvPS2/JQhEkIJmqD6N63zsN7/cpMQ+7CEj2HuzQ3UnMa8GjZLMRsseTjJtL xqKLLb3PHAS+jLJFuynAhgzbq6rTggHtffbW6i93wD/1UEgpCn50MEw4arLokFUkcU1k M+4z+70zouUmqq3jXkXHsy33LQGfU86Heb3CB0uwiMPrego9AdhVGVW1WD9MqCIhL1Ro gAt7xuk6TSIlya+7zfXabLNJnHhAUXSiUA8L4q/Eoehgwn+edcxWAloHucaAI5AUtZID aJfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cQcwtWuJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id s33-20020a056a0017a100b006cd8f0ed07csi9913851pfg.191.2023.12.13.11.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 11:52:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cQcwtWuJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8E8FE802FA24; Wed, 13 Dec 2023 11:52:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442273AbjLMTvs (ORCPT + 99 others); Wed, 13 Dec 2023 14:51:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379023AbjLMTv1 (ORCPT ); Wed, 13 Dec 2023 14:51:27 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4098CF; Wed, 13 Dec 2023 11:51:33 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40c48d7a7a7so32030335e9.3; Wed, 13 Dec 2023 11:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702497092; x=1703101892; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SDq2fLVuR6T1GPARTMOS6b3H20znzfoIBUzVKBtShU4=; b=cQcwtWuJFdo2AMU4ZfYJkUhL5dVKd0BHwpSqdbSMCcIObydfBqqMLJ73pTJaZ/7KKr W+hhEuVfwl/UO5jdNNaADlC4HiqOxUHErl9UuaQbZDr63sKlOtRv7RA2zcGbhpN+wyXJ TWUjGz5M+KdM5qY0p5kSbJZg/352o1q3BaB1vXItRXu3g6T9MWRiC8yJvqzgk1qVEnKy 0lbvQYFfRhrW77M6nB5um7zWK1lfzlKBGr7NZE/H5bpyVMsajXBGiXPiqVXFzd9yrApD 3NiqEogxBDpZBPo3KAlkgJJBRki5T0varE07TJlKJJkPFDX3UY8J33yFbnQ4N7g9DOKn 2tZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702497092; x=1703101892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SDq2fLVuR6T1GPARTMOS6b3H20znzfoIBUzVKBtShU4=; b=eB5HtKRYf/4D+lxujGESz7NlcqEcP1qInR8Jz4q9c7mYV/Uze1iSEmGo/bXs1H8xs+ B8+v0+pGiPea5TIA1dLBVYUbg66CMnq+VjzxdTMzcOo7gQ4Os5lhmHA0thoIXAW7nres wO6Z9fOYp59WVRmn+8Aw66qHyr00ZUvmp9+dX6n0jrtxSzYRxQz4P8p9cXhxysE+Q8/p JoGwqkipjNmuknIJlXYcCAZpOlSSJY8u5uapWVElFRgy8tPEJnhR0yrlz6ener7Mv9gJ 0Hn59lq8ew95drDii03SoLCFC0J7HU+DRqt5Luyz9wyKcsnfIaBzOwGHsnltEF0Zu92f qr5w== X-Gm-Message-State: AOJu0Ywm+g2B0bzQV1GwipnPejRy/m/qKDPnUYBEJzydZQKfoQCb+0HH GFixpKMtxAx4ukoL8AzrZA== X-Received: by 2002:a05:600c:4f48:b0:40c:426b:fd2d with SMTP id m8-20020a05600c4f4800b0040c426bfd2dmr3758370wmq.102.1702497092225; Wed, 13 Dec 2023 11:51:32 -0800 (PST) Received: from U4.lan ([2a02:810b:f40:4300:92dc:8b1c:e01c:b93c]) by smtp.gmail.com with ESMTPSA id fm14-20020a05600c0c0e00b00407b93d8085sm24050698wmb.27.2023.12.13.11.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 11:51:32 -0800 (PST) From: Alex Bee To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: David Airlie , Daniel Vetter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Alex Bee Subject: [PATCH 08/11] drm/rockchip: inno_hdmi: Drop custom fill_modes hook Date: Wed, 13 Dec 2023 20:51:22 +0100 Message-ID: <20231213195125.212923-9-knaerzche@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213195125.212923-1-knaerzche@gmail.com> References: <20231213195125.212923-1-knaerzche@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 11:52:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785197626223791558 X-GMAIL-MSGID: 1785197626223791558 Now that we have proper pixelclock-based validation we can drop the custom fill_modes hook. CRTC size validation for the display controller has been added with Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to hardware capabilities") Signed-off-by: Alex Bee --- drivers/gpu/drm/rockchip/inno_hdmi.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 2f839ff31c1c..84520da8c995 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -696,13 +696,6 @@ inno_hdmi_connector_mode_valid(struct drm_connector *connector, return inno_hdmi_mode_valid(hdmi, mode); } -static int -inno_hdmi_probe_single_connector_modes(struct drm_connector *connector, - uint32_t maxX, uint32_t maxY) -{ - return drm_helper_probe_single_connector_modes(connector, 1920, 1080); -} - static void inno_hdmi_connector_destroy(struct drm_connector *connector) { drm_connector_unregister(connector); @@ -710,7 +703,7 @@ static void inno_hdmi_connector_destroy(struct drm_connector *connector) } static const struct drm_connector_funcs inno_hdmi_connector_funcs = { - .fill_modes = inno_hdmi_probe_single_connector_modes, + .fill_modes = drm_helper_probe_single_connector_modes, .detect = inno_hdmi_connector_detect, .destroy = inno_hdmi_connector_destroy, .reset = drm_atomic_helper_connector_reset,