From patchwork Wed Dec 13 16:42:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 178168 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp7908574dys; Wed, 13 Dec 2023 08:43:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEXcAZfKi03D2VMYskVPkaDaN9kusbGPIww9p0eS26IOsfntmuTtR8ucvu9L7hzodvHkGq X-Received: by 2002:a17:90b:368e:b0:28a:f2c8:e168 with SMTP id mj14-20020a17090b368e00b0028af2c8e168mr372164pjb.98.1702485833622; Wed, 13 Dec 2023 08:43:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702485833; cv=none; d=google.com; s=arc-20160816; b=MrKwFVJipSfV4x4mQbL7qFaou6wNz/K753GDLdoElWpb9AO74D2n6Px81psoIA+rVT Y6v45vB9PAVpI6gHG01WQpIcp0rNK1Lo+vqH6+O2sbpf3x4wU6nyiKYDDKgBvcW9l17C UqgRQi0uOIzkQRVAoRJzX57XRP7D5c5Jx5BT258nISkkwaG4JaAyXxzK9KBxnxyUYR+W KymNvJ8dsenYSowvGqL8ejgkeKQvlwIxzIHkPjMoSfWo6lxhKBB4LAVs4R11L0ZH5bgT 1W+ETeQ3icSbDTBqrGbAovC1llJa5PfsCUwRdY0P53Ja51QjMOqYHkDGTO/SRPcGaqTd W95Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=x8+HyZZKUhCaR+dUapq41zUt5DHXynWO+h3nFdhN/kk=; fh=8RtVw6u65wL9VNsERayIPAWTSX1tJ+5NDBnBQAzRfeU=; b=e+iJmFACDaEwwEtZCyWs+10LbuGiuLfMy/bogNgFUGT/2KPwK7VHGrCmuEQjf8QkSB Xx7I8T6yB0Ay+qH+sCguF++k1L4jdVCtC5wtV/iRDzCPixiAOROlerD+WmI2/AZCi77B D34rUPOQ7Ton/PI+/SkoKCPyMjS1s3Z0j3f5/67ULvAm0YDHFFNpcIyr7Cc5r+CYSd9m xCmlhinRLR0gytl2huPDjvxvbRSTzZkXkqGoFiQ7I7Z0juvK4KANcS3Vrgtn+I/8bK2D I1vtyAmkJpbB6M/qlCirrIUwkV2QfKiEQYFGg36Nd6sfM1FXoH+7AgAFGcTaPiwYf99+ QcFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lR9U58Vg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id fv18-20020a17090b0e9200b0028ade62e22esi1570644pjb.51.2023.12.13.08.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:43:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lR9U58Vg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8937C802FD0B; Wed, 13 Dec 2023 08:43:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379412AbjLMQng (ORCPT + 99 others); Wed, 13 Dec 2023 11:43:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378871AbjLMQnM (ORCPT ); Wed, 13 Dec 2023 11:43:12 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00114189 for ; Wed, 13 Dec 2023 08:43:17 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F23DC433C8; Wed, 13 Dec 2023 16:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702485797; bh=Y4wityMNU6LBHUMAjlj0BBIjoaSI0QhZKsDFgQ7pmJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lR9U58Vg+LkVgGuHADI7IfXco/pwo/wpHAau0NJYGRG2oRSpP3tPb2jxX4DL4q9sP P7ad5N3mM4WSmMdUwRjTEroGTePdFnt/6Vr6Y1wP1UOWgCaA9pMWYvloiXL0W3hH6R LtddHquHWTb971SACHCbhVcjBduO7gjIxTU6ou3K/11BFCSMiPDeSyme577N5rULG9 prCubnu+81tc4+GC0WVGacIWCGsugatzjSzPO3ehNhm337cTEq+hdyhm4recK3g/TZ B2uuSsZDxHWl9VVmdUg4NO7eMJJus13D5ylcEvu6VOtYenfnj1rf6ifqV6mrLfY2rR sFVxedNg2aPqQ== From: Lee Jones To: lee@kernel.org, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Hema HK Subject: [PATCH 11/12] usb: phy: twl6030: Remove snprintf() from sysfs call-backs and replace with sysfs_emit() Date: Wed, 13 Dec 2023 16:42:40 +0000 Message-ID: <20231213164246.1021885-12-lee@kernel.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231213164246.1021885-1-lee@kernel.org> References: <20231213164246.1021885-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 08:43:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785185785372822531 X-GMAIL-MSGID: 1785185785372822531 Since snprintf() has the documented, but still rather strange trait of returning the length of the data that *would have been* written to the array if space were available, rather than the arguably more useful length of data *actually* written, it is usually considered wise to use something else instead in order to avoid confusion. In the case of sysfs call-backs, new wrappers exist that do just that. Link: https://lwn.net/Articles/69419/ Link: https://github.com/KSPP/linux/issues/105 Cc: Hema HK Signed-off-by: Lee Jones --- drivers/usb/phy/phy-twl6030-usb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c index c3ce6b1054f1c..da09cff55abce 100644 --- a/drivers/usb/phy/phy-twl6030-usb.c +++ b/drivers/usb/phy/phy-twl6030-usb.c @@ -179,16 +179,16 @@ static ssize_t vbus_show(struct device *dev, switch (twl->linkstat) { case MUSB_VBUS_VALID: - ret = snprintf(buf, PAGE_SIZE, "vbus\n"); + ret = sysfs_emit(buf, "vbus\n"); break; case MUSB_ID_GROUND: - ret = snprintf(buf, PAGE_SIZE, "id\n"); + ret = sysfs_emit(buf, "id\n"); break; case MUSB_VBUS_OFF: - ret = snprintf(buf, PAGE_SIZE, "none\n"); + ret = sysfs_emit(buf, "none\n"); break; default: - ret = snprintf(buf, PAGE_SIZE, "UNKNOWN\n"); + ret = sysfs_emit(buf, "UNKNOWN\n"); } spin_unlock_irqrestore(&twl->lock, flags);