From patchwork Wed Dec 13 13:49:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 178032 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp7789470dys; Wed, 13 Dec 2023 05:55:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IF38YFMRpzHMEALxJ6VuDoij4Jd0tUYlArfRe9MdE34adPMS6gfOytNtkSatAfSWWyI7BNR X-Received: by 2002:a05:6a21:18d:b0:190:8491:ac38 with SMTP id le13-20020a056a21018d00b001908491ac38mr11018420pzb.106.1702475713611; Wed, 13 Dec 2023 05:55:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702475713; cv=none; d=google.com; s=arc-20160816; b=zPUyeqF3NWaZkkMn+tRyPlvVunmGfLNngu4JfRfpJDgsyRoYkmlIFJ15tZ5sOMvif+ 1fosqccJ1v6jpRBCk83dlrA46YsFCERDPcKlQIqhX7FTOsUSdSKq1zAfCafGF6KeYxIV aUoIMqIaFv2D2x73K6UK4ixY1EMiBij1Qv/aUrizd163qOhrcHCVeQKxG/BuszTJt2cR QRTg51HR2JmDJmvg3CUqFoGokPfRR9zNDRhBVoBObVQ2gJmx04KILqLsb/+WzOSC7oyN xujPv3Es92pwj2HitouTiq9NO/uqTytkd5kcbQekmmYC2cFlZtLbWWbRrvZjqGZhy6Ih 9B8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Mrk0toX4iy+sa30+IfYuhvEvlz4UbttXs26cFwhG3jo=; fh=9hT4l0EMR1D2zdgUoRXiqFwsybSJyrmM/FC/blQlPsI=; b=u/sAY0RN0M39sUpxqSNJwVDkjZoAbhXV8f5AN7Cuum3x3+8q5B3fYV2bfkcuNPrDhG BU5Zlio1AyQU3btPn6JfCMBRQigxStMS8oedyXvCbtsyizx5vR2eedigsMspjcCMpvrI spXWpv99ehvvZLwtNOOFQLIodS3CrL6wRotVC7r9npTZ6M+e1tPu5nyKLQtmvXUWBLW5 Rpk19l4EZY6jMHBnDvqU1WXpUY8PK3pnsHx55SCT9BkJRS0I6c96fyPCpHUHPtyO0zfr obNY5z1/jHl8smelFW/RsQaR10v0/6SUe6vwaYC8Xe/JYJA4WmipD+2aDCRLQHFUvbgt ZlZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RRBSVNas; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ko19-20020a056a00461300b006cd92bdabfdsi9847511pfb.48.2023.12.13.05.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 05:55:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RRBSVNas; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 186A48041EA7; Wed, 13 Dec 2023 05:55:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379307AbjLMNxX (ORCPT + 99 others); Wed, 13 Dec 2023 08:53:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379366AbjLMNwW (ORCPT ); Wed, 13 Dec 2023 08:52:22 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39E6E1986 for ; Wed, 13 Dec 2023 05:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702475479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mrk0toX4iy+sa30+IfYuhvEvlz4UbttXs26cFwhG3jo=; b=RRBSVNas4VQS2xXAQYZFaK+7ccF7wjmBQMmLfG7IopwgbpOYsJF4iQrtWakM16/pks6+/+ /98zuqcSJdKMJipgJGI7fnnS5OgR1PYqLX2UZ/OD/mMQlHHl4+aR5eSCU5m6/Tf5kR1Xgn LjSfDoCujJ47k1WyAJgpJykBrgBKQRU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-mlXMGZtnM8ijtuYFgUI6Jw-1; Wed, 13 Dec 2023 08:51:16 -0500 X-MC-Unique: mlXMGZtnM8ijtuYFgUI6Jw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83EFE101CFB6; Wed, 13 Dec 2023 13:51:00 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9F73492BF0; Wed, 13 Dec 2023 13:50:59 +0000 (UTC) From: David Howells To: Marc Dionne Cc: David Howells , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 34/40] afs: Fix comment in afs_do_lookup() Date: Wed, 13 Dec 2023 13:49:56 +0000 Message-ID: <20231213135003.367397-35-dhowells@redhat.com> In-Reply-To: <20231213135003.367397-1-dhowells@redhat.com> References: <20231213135003.367397-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 05:55:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785175174282538150 X-GMAIL-MSGID: 1785175174282538150 Fix the comment in afs_do_lookup() that says that slot 0 is used for the fid being looked up and slot 1 is used for the directory. It's actually done the other way round. Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org --- fs/afs/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/afs/dir.c b/fs/afs/dir.c index ecb889a269fb..e232f713ece1 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -807,8 +807,8 @@ static struct inode *afs_do_lookup(struct inode *dir, struct dentry *dentry, cookie->fids[i].vid = dvnode->fid.vid; cookie->ctx.actor = afs_lookup_filldir; cookie->name = dentry->d_name; - cookie->nr_fids = 2; /* slot 0 is saved for the fid we actually want - * and slot 1 for the directory */ + cookie->nr_fids = 2; /* slot 1 is saved for the fid we actually want + * and slot 0 for the directory */ if (!afs_server_supports_ibulk(dvnode)) cookie->one_only = true;