diff mbox series

[4/5] net: ethernet: altera: sorting headers in alphabetical order

Message ID 20231213071112.18242-5-deepakx.nagaraju@intel.com
State New
Headers
Series Rename functions and their prototypes and move to common files. |

Commit Message

deepakx.nagaraju@intel.com Dec. 13, 2023, 7:11 a.m. UTC 
  From: Nagaraju DeepakX <deepakx.nagaraju@intel.com>

Re-arrange the headers in alphabetical order and add empty lines
in between of groups of headers for easier maintenance.

Signed-off-by: Nagaraju DeepakX <deepakx.nagaraju@intel.com>
Reviewed-by: Andy Schevchenko <andriy.schevchenko@linux.intel.com>
---
 drivers/net/ethernet/altera/altera_msgdma.c   | 7 ++++---
 drivers/net/ethernet/altera/altera_sgdma.c    | 7 ++++---
 drivers/net/ethernet/altera/altera_tse_main.c | 7 ++++---
 3 files changed, 12 insertions(+), 9 deletions(-)

--
2.26.2

Comments

Jakub Kicinski Dec. 14, 2023, 7:06 p.m. UTC | #1 
On Wed, 13 Dec 2023 15:11:11 +0800 deepakx.nagaraju@intel.com wrote:
> From: Nagaraju DeepakX <deepakx.nagaraju@intel.com>
> 
> Re-arrange the headers in alphabetical order and add empty lines
> in between of groups of headers for easier maintenance.

This breaks the build, please make sure allmodconfig build works.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/altera/altera_msgdma.c b/drivers/net/ethernet/altera/altera_msgdma.c
index ac1efd08267a..9581c05a5449 100644
--- a/drivers/net/ethernet/altera/altera_msgdma.c
+++ b/drivers/net/ethernet/altera/altera_msgdma.c
@@ -4,10 +4,11 @@ 
  */

 #include <linux/netdevice.h>
-#include "altera_utils.h"
-#include "altera_tse.h"
-#include "altera_msgdmahw.h"
+
 #include "altera_msgdma.h"
+#include "altera_msgdmahw.h"
+#include "altera_tse.h"
+#include "altera_utils.h"

 /* No initialization work to do for MSGDMA */
 int msgdma_initialize(struct altera_tse_private *priv)
diff --git a/drivers/net/ethernet/altera/altera_sgdma.c b/drivers/net/ethernet/altera/altera_sgdma.c
index d4edfb3e09e8..f6c9904c88d0 100644
--- a/drivers/net/ethernet/altera/altera_sgdma.c
+++ b/drivers/net/ethernet/altera/altera_sgdma.c
@@ -4,10 +4,11 @@ 
  */

 #include <linux/list.h>
-#include "altera_utils.h"
-#include "altera_tse.h"
-#include "altera_sgdmahw.h"
+
 #include "altera_sgdma.h"
+#include "altera_sgdmahw.h"
+#include "altera_tse.h"
+#include "altera_utils.h"

 static void sgdma_setup_descrip(struct sgdma_descrip __iomem *desc,
 				struct sgdma_descrip __iomem *ndesc,
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 6a1a004ea693..f98810eac44f 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -38,12 +38,13 @@ 
 #include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/skbuff.h>
+
 #include <asm/cacheflush.h>

-#include "altera_utils.h"
-#include "altera_tse.h"
-#include "altera_sgdma.h"
 #include "altera_msgdma.h"
+#include "altera_sgdma.h"
+#include "altera_tse.h"
+#include "altera_utils.h"

 static atomic_t instance_count = ATOMIC_INIT(~0);
 /* Module parameters */