diff mbox series

[V2,RESEND] arm64: dts: qcom: sc7280: add slimbus DT node

Message ID 20231212145026.20828-1-quic_vdadhani@quicinc.com
State New
Headers
Series [V2,RESEND] arm64: dts: qcom: sc7280: add slimbus DT node |

Commit Message

Viken Dadhaniya Dec. 12, 2023, 2:50 p.m. UTC 
  Populate the DTSI node for slimbus instance to be
used by BT FM client.

Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
---
v1 -> v2:
- change 0x0 -> 0 to reg property.
- reorder the DT property.
- change node tag slim_msm to slim.
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Comments

Viken Dadhaniya Jan. 30, 2024, 5:17 a.m. UTC | #1 
Gentle reminder for review.

Thanks
Viken

> -----Original Message-----
> From: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> Sent: Tuesday, December 12, 2023 8:20 PM
> To: andersson@kernel.org; konrad.dybcio@linaro.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; linux-arm-
> sm@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Vijaya Krishna Nivarthi (Temp) (QUIC) <quic_vnivarth@quicinc.com>; Mukesh
> Savaliya (QUIC) <quic_msavaliy@quicinc.com>; Visweswara Tanuku (QUIC)
> <quic_vtanuku@quicinc.com>; Chandana Kishori Chiluveru (QUIC)
> <quic_cchiluve@quicinc.com>; krzysztof.kozlowski@linaro.org; Viken Dadhaniya
> (QUIC) <quic_vdadhani@quicinc.com>
> Subject: [V2 RESEND] arm64: dts: qcom: sc7280: add slimbus DT node
> 
> Populate the DTSI node for slimbus instance to be used by BT FM client.
> 
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---
> v1 -> v2:
> - change 0x0 -> 0 to reg property.
> - reorder the DT property.
> - change node tag slim_msm to slim.
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 04bf85b0399a..9fec8743e19a 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2528,6 +2528,31 @@
>  			status = "disabled";
>  		};
> 
> +		slimbam: dma-controller@3a84000 {
> +			compatible = "qcom,bam-v1.7.0";
> +			reg = <0 0x03a84000 0 0x20000>;
> +			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> +			#dma-cells = <1>;
> +			qcom,controlled-remotely;
> +			num-channels  = <31>;
> +			qcom,ee = <1>;
> +			qcom,num-ees = <2>;
> +			iommus = <&apps_smmu 0x1826 0x0>;
> +			status = "disabled";
> +		};
> +
> +		slim: slim-ngd@3ac0000 {
> +			compatible = "qcom,slim-ngd-v1.5.0";
> +			reg = <0 0x03ac0000 0 0x2c000>;
> +			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> +			dmas = <&slimbam 3>, <&slimbam 4>;
> +			dma-names = "rx", "tx";
> +			iommus = <&apps_smmu 0x1826 0x0>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
>  		lpass_hm: clock-controller@3c00000 {
>  			compatible = "qcom,sc7280-lpasshm";
>  			reg = <0 0x03c00000 0 0x28>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
Mukesh Savaliya Feb. 6, 2024, 9:48 a.m. UTC | #2 
LGTM, Acked.

> -----Original Message-----
> From: Viken Dadhaniya
> Sent: Tuesday, January 30, 2024 10:48 AM
> To: Viken Dadhaniya (QUIC) <quic_vdadhani@quicinc.com>;
> andersson@kernel.org; konrad.dybcio@linaro.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; linux-arm-
> sm@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Mukesh Savaliya (QUIC) <quic_msavaliy@quicinc.com>; Visweswara
> Tanuku (QUIC) <quic_vtanuku@quicinc.com>; Chandana Kishori Chiluveru
> (QUIC) <quic_cchiluve@quicinc.com>; krzysztof.kozlowski@linaro.org; Viken
> Dadhaniya (QUIC) <quic_vdadhani@quicinc.com>
> Subject: RE: [V2 RESEND] arm64: dts: qcom: sc7280: add slimbus DT node
> 
> Gentle reminder for review.
> 
> Thanks
> Viken
> 
> > -----Original Message-----
> > From: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> > Sent: Tuesday, December 12, 2023 8:20 PM
> > To: andersson@kernel.org; konrad.dybcio@linaro.org;
> > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > conor+dt@kernel.org; linux-arm- sm@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> > Cc: Vijaya Krishna Nivarthi (Temp) (QUIC) <quic_vnivarth@quicinc.com>;
> > Mukesh Savaliya (QUIC) <quic_msavaliy@quicinc.com>; Visweswara
> Tanuku
> > (QUIC) <quic_vtanuku@quicinc.com>; Chandana Kishori Chiluveru (QUIC)
> > <quic_cchiluve@quicinc.com>; krzysztof.kozlowski@linaro.org; Viken
> > Dadhaniya
> > (QUIC) <quic_vdadhani@quicinc.com>
> > Subject: [V2 RESEND] arm64: dts: qcom: sc7280: add slimbus DT node
> >
> > Populate the DTSI node for slimbus instance to be used by BT FM client.
> >
> > Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
Acked-by: Mukesh Kumar Savaliya < quic_msavaliy@quicinc.com>
> > ---
> > v1 -> v2:
> > - change 0x0 -> 0 to reg property.
> > - reorder the DT property.
> > - change node tag slim_msm to slim.
> > ---
> >  arch/arm64/boot/dts/qcom/sc7280.dtsi | 25
> +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 04bf85b0399a..9fec8743e19a 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -2528,6 +2528,31 @@
> >  			status = "disabled";
> >  		};
> >
> > +		slimbam: dma-controller@3a84000 {
> > +			compatible = "qcom,bam-v1.7.0";
> > +			reg = <0 0x03a84000 0 0x20000>;
> > +			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> > +			#dma-cells = <1>;
> > +			qcom,controlled-remotely;
> > +			num-channels  = <31>;
> > +			qcom,ee = <1>;
> > +			qcom,num-ees = <2>;
> > +			iommus = <&apps_smmu 0x1826 0x0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		slim: slim-ngd@3ac0000 {
> > +			compatible = "qcom,slim-ngd-v1.5.0";
> > +			reg = <0 0x03ac0000 0 0x2c000>;
> > +			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> > +			dmas = <&slimbam 3>, <&slimbam 4>;
> > +			dma-names = "rx", "tx";
> > +			iommus = <&apps_smmu 0x1826 0x0>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			status = "disabled";
> > +		};
> > +
> >  		lpass_hm: clock-controller@3c00000 {
> >  			compatible = "qcom,sc7280-lpasshm";
> >  			reg = <0 0x03c00000 0 0x28>;
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> > member of Code Aurora Forum, hosted by The Linux Foundation
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 04bf85b0399a..9fec8743e19a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2528,6 +2528,31 @@ 
 			status = "disabled";
 		};
 
+		slimbam: dma-controller@3a84000 {
+			compatible = "qcom,bam-v1.7.0";
+			reg = <0 0x03a84000 0 0x20000>;
+			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			qcom,controlled-remotely;
+			num-channels  = <31>;
+			qcom,ee = <1>;
+			qcom,num-ees = <2>;
+			iommus = <&apps_smmu 0x1826 0x0>;
+			status = "disabled";
+		};
+
+		slim: slim-ngd@3ac0000 {
+			compatible = "qcom,slim-ngd-v1.5.0";
+			reg = <0 0x03ac0000 0 0x2c000>;
+			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
+			dmas = <&slimbam 3>, <&slimbam 4>;
+			dma-names = "rx", "tx";
+			iommus = <&apps_smmu 0x1826 0x0>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		lpass_hm: clock-controller@3c00000 {
 			compatible = "qcom,sc7280-lpasshm";
 			reg = <0 0x03c00000 0 0x28>;