Message ID | 20231212142730.998913-4-vincent.guittot@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7776647vqy; Tue, 12 Dec 2023 06:57:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHxqUMpi5z4wpjz8+t7IOyhKLyHvza58UZDmwbEHDvmHVVh50fWeoH0539W3gY7mAQXhAH X-Received: by 2002:a05:6a00:2286:b0:6ce:2731:e870 with SMTP id f6-20020a056a00228600b006ce2731e870mr7918791pfe.55.1702393050968; Tue, 12 Dec 2023 06:57:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702393050; cv=none; d=google.com; s=arc-20160816; b=tUAAAKvE6XlPFKQzH3EWXrHopMU1zI6aVwU+ExUGW0lCmkkAeKqgOwqscZ30oEaLM8 ZUAOgsKq8YPB2zWOaOIQINYFVF9lTpy9QBt01dYBNOXDkztVlv04rZIWOQfCgDxzVRHm y43ZLzRHoLUkqeieKkui7MaKxUweQtl8+3Z/d5M2uuZpnATUJk0CZz514pYLjPFxErr0 buGnztYo0irv1CXzCds8B30y9vTYScIi5W2fGKddSgS9tA0GarTgVqv4+VG2OTThLf6K +sHIqU8EwFcK0/adXeBUEPZkZNhhUeFWlqvanbnL3E5k6lWvLRqEZ0rxqoPUG9jCSETO BUug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2Srtyc9L2FmnDVigDPLvZ20bwEGcznbGsIksRkAyk9I=; fh=m44bl7Dn/6LyVcN6ZxXNJfGz2WSSS2UdgaE6v6q8lwM=; b=HWxTokDWQCCbUH0CVFA5LdMmkwoDIxPpjUrvqXnxjT067MFESt0UJyxkdhp7q8/1a5 YXl7Q/3S8u9n04JgOR3rf0lTw2HfCDRuiNcUXKoNiNZjd/zgHBj/XmiIwkv8PBQvYiAl nyyw16Uj/Syv/9OhS8h5P37V1hnRmz6iiUUKp68rCyhvcMKXNgIQEceUugmDq1GYtjUx obdo8QSEQ8vYBhTFKe/t/VPKxkV24YbEtxD2Es3xkkLQBwXlS+HglYfsA3wl3Mw/j7ni 2bviJrYn6F+3di3uETiPL6K5p/SOHzBDuDy3e2LP/HGdQ8gWqlju1umfI/FUt7xO6x0p ymCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mrcNinP4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id y184-20020a638ac1000000b005c6c9524f93si7862392pgd.766.2023.12.12.06.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 06:57:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mrcNinP4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 90EF88043EF8; Tue, 12 Dec 2023 06:57:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346667AbjLLO4y (ORCPT <rfc822;dexuan.linux@gmail.com> + 99 others); Tue, 12 Dec 2023 09:56:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376778AbjLLO1f (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 12 Dec 2023 09:27:35 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0E36CD for <linux-kernel@vger.kernel.org>; Tue, 12 Dec 2023 06:27:41 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40c3f68b69aso30622825e9.1 for <linux-kernel@vger.kernel.org>; Tue, 12 Dec 2023 06:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702391260; x=1702996060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2Srtyc9L2FmnDVigDPLvZ20bwEGcznbGsIksRkAyk9I=; b=mrcNinP4g6TPzc5Rati0xcIGMBZD3RAmYJAoOe/+AK39SMa2YraBCcHfUFfqbP5/d6 DXBUbbZ0VuYxJo3FdCZ3SMODId/PJw5iPu/jb+KYIQgslErmFtmOfZy8q8vrBBOze9s2 keR8NHfcgO7PQAKMZP0t4xp+4UAXiN43Glx2nknNA14ThmAJ+pxVr0JDqAdtgAf8eZes 89uwulqLupoUqPLWDYi6b/M7kcuA9Kz7J+OoAdZDfycLg1BVJjGwAGAmogBJC3/8XjqT OC2dfiCsd7Sd87/J43Szv/qEfe7UiVAHuo76+mQW8GUyIhkWox62tpRAHdQ0xIW57il3 LhPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702391260; x=1702996060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Srtyc9L2FmnDVigDPLvZ20bwEGcznbGsIksRkAyk9I=; b=qL2e7cMshfvFJMEeRIAdeXB51yocqYCZH4fe+I8ImLhnm/sWb2lorbHqXmUziAz9hO m5LyIgTwnQxjmRUnPGNtJoSgsIfe/ozgmRZuQ6ekn+DV5MB/xn5IQWW7gRjzc3nhhCxP TmHC/xX/vFgqQQzIZNi2LkdjSdx5jOYQZ69pfWPmXFWbBx/ojYd/WRAzEbGyLUcj10ow YHt3JNNM5y7puc5TSCekYQ4qleBtemfZRteUYWOrk1gMsROpMtysOniyjbG8sgqQuq3O +YV6o5EZbbW7RJBxCNtJWHlccsyOb+IW0C+izteMd0GwUrqstZ2CccvdRic7w0umSi9V eAFQ== X-Gm-Message-State: AOJu0Yyv7bvP8mcPCxl8/WC2AIdJTTDX1MNw7TFcDtL6No3AdGuNFkbF j7URzL7OPds0qkPH3E5KVcwZIw== X-Received: by 2002:a05:600c:1c09:b0:40b:3645:4671 with SMTP id j9-20020a05600c1c0900b0040b36454671mr3704773wms.10.1702391260249; Tue, 12 Dec 2023 06:27:40 -0800 (PST) Received: from vingu-book.. ([2a01:e0a:f:6020:a004:6e24:43ee:dd81]) by smtp.gmail.com with ESMTPSA id fc7-20020a05600c524700b0040c44cb251dsm9078291wmb.46.2023.12.12.06.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 06:27:39 -0800 (PST) From: Vincent Guittot <vincent.guittot@linaro.org> To: catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Vincent Guittot <vincent.guittot@linaro.org> Subject: [PATCH 3/4] thermal/cpufreq: Remove arch_update_thermal_pressure() Date: Tue, 12 Dec 2023 15:27:29 +0100 Message-Id: <20231212142730.998913-4-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231212142730.998913-1-vincent.guittot@linaro.org> References: <20231212142730.998913-1-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 06:57:28 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785088495518685258 X-GMAIL-MSGID: 1785088495518685258 |
Series |
Rework system pressure interface to the scheduler
|
|
Commit Message
Vincent Guittot
Dec. 12, 2023, 2:27 p.m. UTC
arch_update_thermal_pressure() aims to update fast changing signal which
should be averaged using PELT filtering before being provided to the
scheduler which can't make smart use of fast changing signal.
cpufreq now provides the maximum freq_qos pressure on the capacity to the
scheduler, which includes cpufreq cooling device. Remove the call to
arch_update_thermal_pressure() in cpufreq cooling device as this is
handled by cpufreq_get_pressure().
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
drivers/thermal/cpufreq_cooling.c | 3 ---
1 file changed, 3 deletions(-)
Comments
On 12/12/23 14:27, Vincent Guittot wrote: > arch_update_thermal_pressure() aims to update fast changing signal which > should be averaged using PELT filtering before being provided to the > scheduler which can't make smart use of fast changing signal. > cpufreq now provides the maximum freq_qos pressure on the capacity to the > scheduler, which includes cpufreq cooling device. Remove the call to > arch_update_thermal_pressure() in cpufreq cooling device as this is > handled by cpufreq_get_pressure(). > > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> > --- > drivers/thermal/cpufreq_cooling.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c > index e2cc7bd30862..e77d3b44903e 100644 > --- a/drivers/thermal/cpufreq_cooling.c > +++ b/drivers/thermal/cpufreq_cooling.c > @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, > unsigned long state) > { > struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; > - struct cpumask *cpus; > unsigned int frequency; > int ret; > > @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, > ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); > if (ret >= 0) { > cpufreq_cdev->cpufreq_state = state; > - cpus = cpufreq_cdev->policy->related_cpus; > - arch_update_thermal_pressure(cpus, frequency); > ret = 0; > } > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index e2cc7bd30862..e77d3b44903e 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) { struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; - struct cpumask *cpus; unsigned int frequency; int ret; @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); if (ret >= 0) { cpufreq_cdev->cpufreq_state = state; - cpus = cpufreq_cdev->policy->related_cpus; - arch_update_thermal_pressure(cpus, frequency); ret = 0; }