Message ID | 20231211215842.134823-9-Frank.Li@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7362427vqy; Mon, 11 Dec 2023 14:00:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFt61k+SY6/WY9AEzqwpBK5QYAceCDD/mB4AN1c4WGzC8qg/jnUDogLxXBrH8JJBjDOenyU X-Received: by 2002:a17:902:e812:b0:1cf:fb96:9692 with SMTP id u18-20020a170902e81200b001cffb969692mr6794913plg.12.1702332050734; Mon, 11 Dec 2023 14:00:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702332050; cv=pass; d=google.com; s=arc-20160816; b=XSR5ZLehUnG6G3O+xRjVaoZPh9GzBFAlB01ug3ChBDD9KODxGBd6vMeOYXgb7bIk9t m+/nKAq3yBnoW0WnXfMs15QfMtVJWscItauZ3WE756tb4KLjImVyqG4xtloCYAIfJRdT dVocGWa+ess+vLK757XPFYJnhP/45dTfWkXGZdoMXM89sz/JUVRw5bjQd9zSOyo5/qQS EtF0SeK/WmmeJaJ8t7mJk1ZeWGcAKTTcMC8d/1nmrIrrzm3Ejumt1z4XwOIKI2ySGbUR hCLqV9WrtVOaO+holbCJPVa/38SpQWiTgKxGNlEECZLwqkdC6CO8u/lr4Ez4Jsb8j2Hi gezA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AoJCY3ZktTtXPzBt4oTAViK8W4q/hfs4cgWcegnnSzY=; fh=OXs80AbofzOAJ8/C1czTmpWqHLzJWxQApbYGN1XYMR4=; b=kzcDSls7HQ99h0AB7I04Y/8Ri0M2mUhAkVcNc+kz0qApjRf7/4YHbkY427/SYpZEgl 8USami4BfjG/jqiQ0wIMB4ipuRP4ApLpoBJRDtyBxK941eP6ZLttQIOIUNy6soVe3wah EJttpEy5K6kKjYteRpXkgQJnL/L2A3CFnGtm9CSE4z35rOxBOprBc0jEdaCiDiX2msAq 1R6nNA3zZxLykFsJUu9urlddwWH5g/rZiozLIYRzQnR3QIucEflLDE0LrzSMCQqQUFK4 KJhoim0tDZq7/qIX2M6dAv2jXI5jSjmMQz0yKrKgrD2/Fb+4pHgPMROZzXoipeDD4d4y IVmA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=hLtZG2JI; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id s15-20020a63214f000000b005c66af62bacsi6680213pgm.174.2023.12.11.14.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 14:00:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=hLtZG2JI; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 3A0DB809C43B; Mon, 11 Dec 2023 14:00:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345551AbjLKWAP (ORCPT <rfc822;dexuan.linux@gmail.com> + 99 others); Mon, 11 Dec 2023 17:00:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345500AbjLKWAH (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 11 Dec 2023 17:00:07 -0500 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2083.outbound.protection.outlook.com [40.107.241.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E46A184; Mon, 11 Dec 2023 14:00:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJUi+L3I4a1GvTbiAIYeqZxRSz2ltP53nI5YVZC5iPpFgEIlgmL2oenPimtOT2YdJIYZRnEPnA65W4U0shxatTvgNJWqxdAwWJefybtrWaTsWl89Y9xzR91eJDLEYAqLAI7UefbTXvXe3kZg1s2sSPZifa+PwxY34Y2irr/6w/KD5cfEFULLwMOHtmzrvcP5qUpnnJ6xW/soJSokK2Zhzn8rMb7M+4qYJTnSVLP9NhXAe2D3nYO8/5v7/xhA5O8g8Lttg2gCBb0mNZL0UaOhcCoaWRL/r5sTRIs4NDY49G7/r+8JRnwkRGXwhbvFY2T1IwOPrilB0V0bUH697YjtTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AoJCY3ZktTtXPzBt4oTAViK8W4q/hfs4cgWcegnnSzY=; b=IN1TJZ0hTFrWXMPAM+lbnBLkgVHVwbeu+EYVgH6lPCJcTOiR2xzuLVqGU42uN6idD0oLunumVKjwSXqQQiOtu6DlhmUDPEeZB7k69ZwU3YQoPUr7yBH0IJHbV/V8xsoyyxjTvA7fw5PIBU6zyi4QSrekDueLiND89S3r+T/xvvJRAySChbKrXnjjM8wciraSHnx+PlCbaQQ721MJEUTvtx/mopfUcR4zxGECN7r3VAEfPd07Pd76U96JpDCautXHgQ4yGqqPJy5Ha7ptNOShN2CEfZ5AYz2FaERsbxziX3W/3w/W5q5LZQDaZQB78A7FOC05DVmaF13TpC3qLKT9VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AoJCY3ZktTtXPzBt4oTAViK8W4q/hfs4cgWcegnnSzY=; b=hLtZG2JIIXfj4AZ/6ePXDaYo5W0S0PDoj1JjdKzK9xVu7NQUr6EWXEXLmvfJGjjZayzjD67n10LzhCNQiZRMgCheDe24hS4MO82it4OxcD1NjZLiyEvGPbD4iE2yshcDUhXZDgJQaUuBT57dsODuer4dEcZzsCYmTlAgCV27qL4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30) by AM9PR04MB7569.eurprd04.prod.outlook.com (2603:10a6:20b:2d8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Mon, 11 Dec 2023 22:00:05 +0000 Received: from VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::dfaa:e869:45eb:76e5]) by VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::dfaa:e869:45eb:76e5%6]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023 22:00:03 +0000 From: Frank Li <Frank.Li@nxp.com> To: frank.li@nxp.com Cc: bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: [PATCH v3 08/13] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string Date: Mon, 11 Dec 2023 16:58:37 -0500 Message-Id: <20231211215842.134823-9-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231211215842.134823-1-Frank.Li@nxp.com> References: <20231211215842.134823-1-Frank.Li@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR03CA0009.namprd03.prod.outlook.com (2603:10b6:a03:33a::14) To VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB4845:EE_|AM9PR04MB7569:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e4b017f-5cb9-438d-aa2b-08dbfa94873a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /jg2M8uaehfApD8XACL8yWo2Z0gh3RD7NAaaZnPODfHjLuYoQFVezvxOHCBvqhT2ZusLRCBcyByI0xLGpWnvRH9XHvBslCPG8arPZayHQ+hdrsQUdKlIkSf5t9ntP1bd88cuECoudIRpC09QZ41KEhRv1q5qA/TCffvXx7ZcQsaoIHEvMsnYRkzfjAJ8vXm25ukKbr1iMFP0Uo4iwChx8MA+b9Zi96y9sjQ3LeGjW3Z4E9wzunQa4SNb68BOQU3tCbMce656rIlpnhrFEsodJS60fKztowjMKiXRRgjvc/6rCEvK+9RaLY7tq7xx2YFeouGnSvbpLQHPELcG8IRv1GQYUC1kY1vGMWv5IsZ+M+AS6txl11EncoSC/5PkeOaezcndQovxjZlKPp11pTkH2FVk5F8z9hRQEfThigBYlQdx9dAUsDoUoKURcj/SjL4PKwiemPV9Ta3l40MoZu4jCZt5VkxLvF4kxVSStY7f4nk/uus1ZYLuHHDe18aa0dRbip8Jb3RM0A9FR6GH0t9hQBuc34Tnv1PqRvmJ2aTFX4c6c+kYlcOG8nu3IuaPeIPg7yVTtaR7b1ddCWCkGP78JdqnEkJbcBZooebNcdIpqGZN4gVRE3gztou65Nz+Pf2H9BagGdGDlc3FpFDIM3zVsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4845.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(396003)(346002)(366004)(376002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(1076003)(26005)(2616005)(6666004)(6506007)(6512007)(52116002)(83380400001)(5660300002)(7416002)(41300700001)(2906002)(478600001)(6486002)(8676002)(8936002)(4326008)(66946007)(66556008)(316002)(34206002)(37006003)(66476007)(86362001)(38100700002)(36756003)(38350700005)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7HY82mVhLBj3fCSbUy0wtwhGAghOIIrLeY1/bQymzwAMynojsKs94N66Abk02O9sPLUoZIjTFq5H3ARpgQgEh5QdEgaFbTApQuFeOgUJTyVKfJS9PL0go7o3Zl92Xchg+HaSATnhU9fU1MW5zyZng5r+Mz3wFDa0NmAj3kYe7RFDXsWhAElYlby6WbMKeVCNCgkSPWwbEaTUyIdGLLc3XYcixEQrxXWrHQHD6axrpm/3iHpjEzwrF8pogO80qwfKCCbTjXHhamRvUl6+A4GFspYwMhV8qCVKXrMa4lglPil7KreJJCnDl52pB00eNTcl0FaLv5pCLVO+mn+XRmR1m9n5Fy5YdRQ3uyKkVfJY6im1BNdzvxI4oG3jZ8nbwSq/Hf9nbVJcMaKp2S9hyUlD4fgCVkSXBL4bzXUsxoENUfMpLZMIqXISxTqFPsI0pS++eD787EL4+qfgXiux8RIZQw7WPqtoonIasPj52ksf8511u+F9858/VI0GLzKLxgnvvzUKX2WKLOsoBe1J4qqS/DyixOaAu2Fwe5e8Xq9LhIKpsL1DwhEuxfd7aMa5wbr5HSz3zwX7ZDfqaeKJtqMwNOO1MqrGtclSnToYt1uT27/WRgq14dz1oSHD2II0U7q0eRoRz2YF8LNALHujOjcbuy/r7fVvtaHCKjILvq/JMuz1nTH3fJijy5h5PkvlnLER1Vwd6VRekigXtos5WM7GAA0C/Me0ikjXtTTCuhSOn5lbvjlkrhK9r3+AoAcA9nw//wW2CKRQ0eeQlqFi+scGUEElEemCP7F8v1c9EiXopMkhmB3G1J6GS48tw1JTfrl1cT0j2b89uHSXfpsfIwLe9bAvoYFbeB2DGV+2ou89RAVoMVJKFtFNrY00fxlH6co6Qt2LPYfVlyMt8mxR3DBtFeTIFgmogSfUDPt6oy9xLShI9Pj6arNwP/xk6m3qN7h4YxgqQ0PM7IkFPu0A0Hbkf4gxKyQGsR5JzbqB4yeQVrHQGc5QA8J8JMg3qmHCnT2Bi8KADVz84XjJQLknmqkSBmYa9NUftl3vBrWHJPoefflawjzh7cDQBAVHpkA+huWsqKWUl0k4HxfNlebq56aVXM7upDH+NvJVKwNPhs/+0GxFLTvROFzyYcrjHpeAHBX8/DzdtBFzvDxmfkgXAIq1VZrBZsL0HCos2WWdIMY2TlyWLpfYjKLeLXYEEznXAvaTfaOSJgTbpWlNxdgSof3WsSJhOfyyEIqq5PhtTsRe2KKYZYKeL39+qLkTxqGoDk0uu4uj0WDT/0zev7kQ3646bscJVeHY+2Z26ysOXUXGvA+LZRTdBMBVYIS0L8+93yeXnPhqwHTYpJ+Pb4WUrgPkDmP2tJsT03FzH1ESrDSATqIPgxPmnGB3pxmii4h9ByIDgv+XsVB/CkfYMm4Eis8nQAC+MbdL+Nw9t5bYH5hGcTkTuvsGDIvbOc3Wc406E3O9lhdq7vjivHNpgPGF2Yesher9lgop3L7s61UnT2UrJfr7cbGsR5YqgjzBryO2MkAe/QNTunZChlwUbiMkAMDiYujtUbkziTxwrOENBhan39R701WGU7r5OlgnoXBfZfxl X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e4b017f-5cb9-438d-aa2b-08dbfa94873a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4845.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 22:00:03.5976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yvrQwmFnQoH7ocQ8rGu5qjUyhBCLCJpX0KguezTdHA9iRw7W7JUYMp/lNndVjzH0+XEsTcsBCWt2MzKIJmhcfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7569 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 11 Dec 2023 14:00:42 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785024532426934870 X-GMAIL-MSGID: 1785024532426934870 |
Series |
PCI: imx6: Clean up and add imx95 pci support
|
|
Commit Message
Frank Li
Dec. 11, 2023, 9:58 p.m. UTC
From: Richard Zhu <hongxing.zhu@nxp.com> Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. Add "atu" and "serdes" to reg-names. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> --- Notes: Change from v2 to v3 - Remove krzy's ACK tag - Add condition check for imx95, which required more reg-names then old platform, so need Krzy review again, Change from v1 to v2 - add Krzy's ACK tag .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
Comments
On Mon, Dec 11, 2023 at 04:58:37PM -0500, Frank Li wrote: > From: Richard Zhu <hongxing.zhu@nxp.com> > > Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. > Add "atu" and "serdes" to reg-names. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > > Notes: > Change from v2 to v3 > - Remove krzy's ACK tag > - Add condition check for imx95, which required more reg-names then old > platform, so need Krzy review again, > > Change from v1 to v2 > - add Krzy's ACK tag > > .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > index 81bbb8728f0f9..b8fcf8258f031 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -29,6 +29,7 @@ properties: > - fsl,imx8mq-pcie > - fsl,imx8mm-pcie > - fsl,imx8mp-pcie > + - fsl,imx95-pcie > > reg: > items: > @@ -90,6 +91,22 @@ required: > allOf: > - $ref: /schemas/pci/snps,dw-pcie.yaml# > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx95-pcie > + then: > + properties: > + reg: > + minItems: 4 > + reg-names: > + items: > + - const: dbi > + - const: serdes Did you test this? It should fail because 'serdes' would need to be added to snps,dw-pcie.yaml. Is this really not a separate phy block? A separate node would be ideal. If not, there's already a 'phy' name you can use here. We don't want more random names. Rob
On Tue, Dec 12, 2023 at 04:44:26PM -0600, Rob Herring wrote: > On Mon, Dec 11, 2023 at 04:58:37PM -0500, Frank Li wrote: > > From: Richard Zhu <hongxing.zhu@nxp.com> > > > > Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. > > Add "atu" and "serdes" to reg-names. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > > > Notes: > > Change from v2 to v3 > > - Remove krzy's ACK tag > > - Add condition check for imx95, which required more reg-names then old > > platform, so need Krzy review again, > > > > Change from v1 to v2 > > - add Krzy's ACK tag > > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > index 81bbb8728f0f9..b8fcf8258f031 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > @@ -29,6 +29,7 @@ properties: > > - fsl,imx8mq-pcie > > - fsl,imx8mm-pcie > > - fsl,imx8mp-pcie > > + - fsl,imx95-pcie > > > > reg: > > items: > > @@ -90,6 +91,22 @@ required: > > allOf: > > - $ref: /schemas/pci/snps,dw-pcie.yaml# > > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > > + - if: > > + properties: > > + compatible: > > + enum: > > + - fsl,imx95-pcie > > + then: > > + properties: > > + reg: > > + minItems: 4 > > + reg-names: > > + items: > > + - const: dbi > > + - const: serdes > > Did you test this? It should fail because 'serdes' would need to be > added to snps,dw-pcie.yaml. I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report. And PCIe function can work. > > Is this really not a separate phy block? This is misc block, which included phy and also include some registers about SID for each PCI devices. I plan do it later. > A separate node would be > ideal. If not, there's already a 'phy' name you can use here. We don't > want more random names. Chip reference manual call it as 'serdes'. If there are already similar name, I can reuse it. > > Rob
On 13/12/2023 00:28, Frank Li wrote: >>> items: >>> @@ -90,6 +91,22 @@ required: >>> allOf: >>> - $ref: /schemas/pci/snps,dw-pcie.yaml# >>> - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - fsl,imx95-pcie >>> + then: >>> + properties: >>> + reg: >>> + minItems: 4 >>> + reg-names: >>> + items: >>> + - const: dbi >>> + - const: serdes >> >> Did you test this? It should fail because 'serdes' would need to be >> added to snps,dw-pcie.yaml. > > I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report. > And PCIe function can work. Did you test your DTS. The answer is, like Rob suspected: no, you did not test it. This fails. Best regards, Krzysztof
On Tue, Dec 12, 2023 at 06:28:43PM -0500, Frank Li wrote: > On Tue, Dec 12, 2023 at 04:44:26PM -0600, Rob Herring wrote: > > On Mon, Dec 11, 2023 at 04:58:37PM -0500, Frank Li wrote: > > > From: Richard Zhu <hongxing.zhu@nxp.com> > > > > > > Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. > > > Add "atu" and "serdes" to reg-names. > > > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > > --- > > > > > > Notes: > > > Change from v2 to v3 > > > - Remove krzy's ACK tag > > > - Add condition check for imx95, which required more reg-names then old > > > platform, so need Krzy review again, > > > > > > Change from v1 to v2 > > > - add Krzy's ACK tag > > > > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > index 81bbb8728f0f9..b8fcf8258f031 100644 > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > @@ -29,6 +29,7 @@ properties: > > > - fsl,imx8mq-pcie > > > - fsl,imx8mm-pcie > > > - fsl,imx8mp-pcie > > > + - fsl,imx95-pcie > > > > > > reg: > > > items: > > > @@ -90,6 +91,22 @@ required: > > > allOf: > > > - $ref: /schemas/pci/snps,dw-pcie.yaml# > > > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > > > + - if: > > > + properties: > > > + compatible: > > > + enum: > > > + - fsl,imx95-pcie > > > + then: > > > + properties: > > > + reg: > > > + minItems: 4 > > > + reg-names: > > > + items: > > > + - const: dbi > > > + - const: serdes > > > > Did you test this? It should fail because 'serdes' would need to be > > added to snps,dw-pcie.yaml. > > I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report. Only because you have no example. What about your actual .dts? > And PCIe function can work. > > > > > Is this really not a separate phy block? > > This is misc block, which included phy and also include some registers > about SID for each PCI devices. I plan do it later. Sounds like it should be a separate node and use the phy binding. Do it correctly from the start, not later. Later is an ABI break. What is SID? Rob
On Wed, Dec 13, 2023 at 08:36:15AM -0600, Rob Herring wrote: > On Tue, Dec 12, 2023 at 06:28:43PM -0500, Frank Li wrote: > > On Tue, Dec 12, 2023 at 04:44:26PM -0600, Rob Herring wrote: > > > On Mon, Dec 11, 2023 at 04:58:37PM -0500, Frank Li wrote: > > > > From: Richard Zhu <hongxing.zhu@nxp.com> > > > > > > > > Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. > > > > Add "atu" and "serdes" to reg-names. > > > > > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > > > --- > > > > > > > > Notes: > > > > Change from v2 to v3 > > > > - Remove krzy's ACK tag > > > > - Add condition check for imx95, which required more reg-names then old > > > > platform, so need Krzy review again, > > > > > > > > Change from v1 to v2 > > > > - add Krzy's ACK tag > > > > > > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ > > > > 1 file changed, 18 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > > index 81bbb8728f0f9..b8fcf8258f031 100644 > > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > > @@ -29,6 +29,7 @@ properties: > > > > - fsl,imx8mq-pcie > > > > - fsl,imx8mm-pcie > > > > - fsl,imx8mp-pcie > > > > + - fsl,imx95-pcie > > > > > > > > reg: > > > > items: > > > > @@ -90,6 +91,22 @@ required: > > > > allOf: > > > > - $ref: /schemas/pci/snps,dw-pcie.yaml# > > > > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + enum: > > > > + - fsl,imx95-pcie > > > > + then: > > > > + properties: > > > > + reg: > > > > + minItems: 4 > > > > + reg-names: > > > > + items: > > > > + - const: dbi > > > > + - const: serdes > > > > > > Did you test this? It should fail because 'serdes' would need to be > > > added to snps,dw-pcie.yaml. > > > > I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report. > > Only because you have no example. What about your actual .dts? I see. 95 is quite new. Still have not good base yet. I may just take take care this session. > > > And PCIe function can work. > > > > > > > > Is this really not a separate phy block? > > > > This is misc block, which included phy and also include some registers > > about SID for each PCI devices. I plan do it later. > > Sounds like it should be a separate node and use the phy binding. Do it > correctly from the start, not later. Later is an ABI break. Actually, I considerred phy binding. The major problem is LUT (look up table) for MSI and SMMU. LUT need be config according to some PCI device information. I have not find good hook for that at PHY driver. > > What is SID? Stream ID, each device master have SID, which pass to IOMMU and GIC ITS. Frank > > Rob
On Wed, Dec 13, 2023 at 10:39:20AM -0500, Frank Li wrote: > On Wed, Dec 13, 2023 at 08:36:15AM -0600, Rob Herring wrote: > > On Tue, Dec 12, 2023 at 06:28:43PM -0500, Frank Li wrote: > > > On Tue, Dec 12, 2023 at 04:44:26PM -0600, Rob Herring wrote: > > > > On Mon, Dec 11, 2023 at 04:58:37PM -0500, Frank Li wrote: > > > > > From: Richard Zhu <hongxing.zhu@nxp.com> > > > > > > > > > > Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. > > > > > Add "atu" and "serdes" to reg-names. > > > > > > > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > > > > --- > > > > > > > > > > Notes: > > > > > Change from v2 to v3 > > > > > - Remove krzy's ACK tag > > > > > - Add condition check for imx95, which required more reg-names then old > > > > > platform, so need Krzy review again, > > > > > > > > > > Change from v1 to v2 > > > > > - add Krzy's ACK tag > > > > > > > > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ > > > > > 1 file changed, 18 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > > > index 81bbb8728f0f9..b8fcf8258f031 100644 > > > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > > > @@ -29,6 +29,7 @@ properties: > > > > > - fsl,imx8mq-pcie > > > > > - fsl,imx8mm-pcie > > > > > - fsl,imx8mp-pcie > > > > > + - fsl,imx95-pcie > > > > > > > > > > reg: > > > > > items: > > > > > @@ -90,6 +91,22 @@ required: > > > > > allOf: > > > > > - $ref: /schemas/pci/snps,dw-pcie.yaml# > > > > > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > > > > > + - if: > > > > > + properties: > > > > > + compatible: > > > > > + enum: > > > > > + - fsl,imx95-pcie > > > > > + then: > > > > > + properties: > > > > > + reg: > > > > > + minItems: 4 > > > > > + reg-names: > > > > > + items: > > > > > + - const: dbi > > > > > + - const: serdes > > > > > > > > Did you test this? It should fail because 'serdes' would need to be > > > > added to snps,dw-pcie.yaml. > > > > > > I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report. > > > > Only because you have no example. What about your actual .dts? > > I see. 95 is quite new. Still have not good base yet. > I may just take take care this session. > > > > > > And PCIe function can work. > > > > > > > > > > > Is this really not a separate phy block? > > > > > > This is misc block, which included phy and also include some registers > > > about SID for each PCI devices. I plan do it later. > > > > Sounds like it should be a separate node and use the phy binding. Do it > > correctly from the start, not later. Later is an ABI break. > > Actually, I considerred phy binding. The major problem is LUT (look up > table) for MSI and SMMU. LUT need be config according to some PCI device > information. I have not find good hook for that at PHY driver. > > > > > What is SID? > > Stream ID, each device master have SID, which pass to IOMMU and GIC ITS. > > Frank Similar case at commit c6523c4a301d3adff7ddcf57515b9c847beb7566 Author: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Date: Fri May 6 18:21:02 2022 +0300 dt-bindings: PCI: qcom: Specify reg-names explicitly Instead of specifying the enum of possible reg-names, specify them explicitly. This allows us to specify which chipsets need the "atu" regions and which do not. Also it clearly describes which platforms enumerate PCIe cores using the dbi region and which use parf region for that. Link: https://lore.kernel.org/r/20220506152107.1527552-4-dmitry.baryshkov@linaro.org Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Rob Herring <robh@kernel.org> + - const: dbi # DesignWare PCIe registers + - const: elbi # External local bus interface registers + - const: parf # Qualcomm specific registers ^^^^ + - const: config # PCIe configuration space Qualcomm called "part", nxp call "serdes" Frank > > > > > Rob
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 81bbb8728f0f9..b8fcf8258f031 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -29,6 +29,7 @@ properties: - fsl,imx8mq-pcie - fsl,imx8mm-pcie - fsl,imx8mp-pcie + - fsl,imx95-pcie reg: items: @@ -90,6 +91,22 @@ required: allOf: - $ref: /schemas/pci/snps,dw-pcie.yaml# - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# + - if: + properties: + compatible: + enum: + - fsl,imx95-pcie + then: + properties: + reg: + minItems: 4 + reg-names: + items: + - const: dbi + - const: serdes + - const: atu + - const: config + - if: properties: compatible: @@ -111,6 +128,7 @@ allOf: compatible: enum: - fsl,imx8mq-pcie + - fsl,imx95-pcie then: properties: clocks: