diff mbox series

[02/19] media: i2c: ov4689: Fix typo in a comment

Message ID	20231211175023.1680247-3-mike.rudenko@gmail.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; From: Mikhail Rudenko <mike.rudenko@gmail.com> To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Jacopo Mondi <jacopo@jmondi.org>, Tommaso Merciai <tommaso.merciai@amarulasolutions.com>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Mikhail Rudenko <mike.rudenko@gmail.com> Subject: [PATCH 02/19] media: i2c: ov4689: Fix typo in a comment Date: Mon, 11 Dec 2023 20:50:05 +0300 Message-ID: <20231211175023.1680247-3-mike.rudenko@gmail.com> In-Reply-To: <20231211175023.1680247-1-mike.rudenko@gmail.com> References: <20231211175023.1680247-1-mike.rudenko@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Omnivision OV4689 refactoring and improvements \| [00/19] Omnivision OV4689 refactoring and improvements [01/19] media: i2c: ov4689: Clean up and annotate the register table [02/19] media: i2c: ov4689: Fix typo in a comment [03/19] media: i2c: ov4689: CCI conversion [04/19] media: i2c: ov4689: Remove i2c_client from ov4689 struct [05/19] media: i2c: ov4689: Refactor ov4689_set_ctrl [06/19] media: i2c: ov4689: Set gain in one 16 bit write [07/19] media: i2c: ov4689: Use sub-device active state [08/19] media: i2c: ov4689: Enable runtime PM before registering sub-device [09/19] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode [10/19] media: i2c: ov4689: Make horizontal blanking configurable [11/19] media: i2c: ov4689: Implement vflip/hflip controls [12/19] media: i2c: ov4689: Implement digital gain control [13/19] media: i2c: ov4689: Implement manual color balance controls [14/19] media: i2c: ov4689: Move pixel array size out of struct ov4689_mode [15/19] media: i2c: ov4689: Set timing registers programmatically [16/19] media: i2c: ov4689: Configurable analogue crop [17/19] media: i2c: ov4689: Eliminate struct ov4689_mode [18/19] media: i2c: ov4689: Refactor ov4689_s_stream [19/19] media: i2c: ov4689: Implement 2x2 binning

Commit Message

Mikhail Rudenko Dec. 11, 2023, 5:50 p.m. UTC

  Fix a spelling error in a comment.

Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
---
 drivers/media/i2c/ov4689.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Dec. 11, 2023, 6:01 p.m. UTC | #1

On Mon, Dec 11, 2023 at 08:50:05PM +0300, Mikhail Rudenko wrote:
> Fix a spelling error in a comment.
> 
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>

Starting with the easy one,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/ov4689.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
> index ff5213862974..53dcfc8685d4 100644
> --- a/drivers/media/i2c/ov4689.c
> +++ b/drivers/media/i2c/ov4689.c
> @@ -692,7 +692,7 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl)
>  
>  	switch (ctrl->id) {
>  	case V4L2_CID_EXPOSURE:
> -		/* 4 least significant bits of expsoure are fractional part */
> +		/* 4 least significant bits of exposure are fractional part */
>  		ret = ov4689_write_reg(ov4689->client, OV4689_REG_EXPOSURE,
>  				       OV4689_REG_VALUE_24BIT, ctrl->val << 4);
>  		break;

Mikhail Rudenko Dec. 12, 2023, 12:22 p.m. UTC | #2

On 2023-12-11 at 20:01 +02, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> On Mon, Dec 11, 2023 at 08:50:05PM +0300, Mikhail Rudenko wrote:
>> Fix a spelling error in a comment.
>>
>> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
>
> Starting with the easy one,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Hi Laurent,

and thanks for the review!

>> ---
>>  drivers/media/i2c/ov4689.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
>> index ff5213862974..53dcfc8685d4 100644
>> --- a/drivers/media/i2c/ov4689.c
>> +++ b/drivers/media/i2c/ov4689.c
>> @@ -692,7 +692,7 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl)
>>
>>  	switch (ctrl->id) {
>>  	case V4L2_CID_EXPOSURE:
>> -		/* 4 least significant bits of expsoure are fractional part */
>> +		/* 4 least significant bits of exposure are fractional part */
>>  		ret = ov4689_write_reg(ov4689->client, OV4689_REG_EXPOSURE,
>>  				       OV4689_REG_VALUE_24BIT, ctrl->val << 4);
>>  		break;


--
Best regards,
Mikhail Rudenko

diff mbox series

Patch

diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
index ff5213862974..53dcfc8685d4 100644
--- a/drivers/media/i2c/ov4689.c
+++ b/drivers/media/i2c/ov4689.c
@@ -692,7 +692,7 @@  static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl)
 
 	switch (ctrl->id) {
 	case V4L2_CID_EXPOSURE:
-		/* 4 least significant bits of expsoure are fractional part */
+		/* 4 least significant bits of exposure are fractional part */
 		ret = ov4689_write_reg(ov4689->client, OV4689_REG_EXPOSURE,
 				       OV4689_REG_VALUE_24BIT, ctrl->val << 4);
 		break;