From patchwork Fri Dec 8 00:05:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 175471 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5143847vqy; Thu, 7 Dec 2023 16:06:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGp4bLNj0xVQSmkiY1QFYAL/d6uzGCS+5+ZvlCYmBECH8pKUtsl/+czKYizryJ/Iln7H7gA X-Received: by 2002:a05:6a20:4308:b0:188:20e0:2bca with SMTP id h8-20020a056a20430800b0018820e02bcamr3441331pzk.13.1701994004859; Thu, 07 Dec 2023 16:06:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701994004; cv=none; d=google.com; s=arc-20160816; b=gOZyFacG1K5ANpCArXQgojNHllPVRqjK5gNmNCjGwaVHmaPg7BFatXZu7hxIFTGueG DXIV1oU/iwN1KCVEcJdVDXhpjIkGAhYFP46UYMosOmnYjoibTZw4mIzxrs5tIAS2o6st DxLbhJpzlhxtU5om31rXKra5of4+3PQn2P0CGEgGQhs9ruomtPefRvnsCLRV7saI9C3s YYl0svgkczom/9Cl8MSLM6NRxz5GJ/FyGLqXXkS2BnpVuswEmiGXMx7/HU/SxSk+NbPp SrovvR7SJ9ME9RwLRceQjyySrgpBeFhwmHmjhynnDHJnTU9zE3Aqi0ataCf5VlxrDIzB QpYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=jgzdmxyD187mlNLpFJ4WQcDthQqtT591zShxv4oxXeo=; fh=TIE+Q456lum2w6CNS8hGW8/qeLzq5fdQr2L1Nx0bPN4=; b=iKyCfVI4nN4T/D87VOFSyhA/2ggkqM5nU8QU/996by4VtG8noOo9bnOf6RAXTtqUCg +FVWRIyO4hrOklBRwhVKQ34vzrlif0hqu+78RLj5nXNc3fhgvjmTcsAGyFygv9Q63aIt uOMYzR3l8sM3NNhQi9o1/QiO0Oq/gbUuJd83VWLqsMbfmWQjiMOFAQXBiMEQn72Fap+5 6OLrUtEEvLd4Ip952avc4Ds1kVNs3ACUj1GdNyhHDHF3FpNWKrfByoY/+uCYt39CVUM7 iV29nYVDVitjMF7tBRWOGbjoWoFuQBRuGSPE5CgW28oWZ5FklyYdwOsGK2C9VxK9QHvE a+2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=mMbnETiZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id p12-20020a170902e74c00b001cc33933e45si565180plf.42.2023.12.07.16.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 16:06:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=mMbnETiZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 212178068E2E; Thu, 7 Dec 2023 16:06:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444138AbjLHAFd (ORCPT + 99 others); Thu, 7 Dec 2023 19:05:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbjLHAFY (ORCPT ); Thu, 7 Dec 2023 19:05:24 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A8131716 for ; Thu, 7 Dec 2023 16:05:30 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5d7e7e10231so9720297b3.1 for ; Thu, 07 Dec 2023 16:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701993929; x=1702598729; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=jgzdmxyD187mlNLpFJ4WQcDthQqtT591zShxv4oxXeo=; b=mMbnETiZ+g50JfUFRBSzXe0iTlPVlEtdQH9KjOBgOe2a8MDht5H2v5Bb87/ynA61uC TjBkNVLQIy3S8s5SfK+izTfVZXDHU2npS2K5ftbIAVDyVgOln2nt8lEuNe8p35SDfjRe n116DEtsfGUBxKLIkLDWpQLaix10XVKIu+5PO0xeCW7F5YH1u1kWJyVgGRZGHQEyfkaf 8fqWP5OuGhpkYuSF7ZELFJJvUIw12xezt8xJVFe+VBhpED9IT/Wt62HVY4vmdFWLoAkv edVDk/cvu5b/NCsW5msCzd4vdkz9d7MMJEMyvVQ1XW+cGBT6Lb5uIPjBIv6iKNV+3uj1 gJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701993929; x=1702598729; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jgzdmxyD187mlNLpFJ4WQcDthQqtT591zShxv4oxXeo=; b=kuqTofA4oKwFTQknrKJSq5tJUI1E1sseJ8tHrz+MK1rVPXcVujVGOlViLOv3uq6Bo6 YGWVwhYWnjAmUqPaLHU5vHM7bjhFAK9vBMp/htIRU/JuIAQX0v8zDFeprBmbwoggv9No eQDs8vBuczjzj5DBSoP8cevIyDXPkQ2FHou8ghZ1UG6Up4Pv71SUrQ12FFAPwbaGV8km X/NSXKZmI93wVMegZdPj9N4FybUTpslcRsWFSU5ZvrwQPo3kUsVrI3dU+cRj7ZrcuKHl G5XEYihP5Bdujx275/BYEfLFrMrbNMC0XSy9Exnr+0Asray/UlqCXHXnxS29DCyov9nG GvLg== X-Gm-Message-State: AOJu0YyaN6G1Y3/8hD5r6rlQ5mNvI8f8KBe5/3NvFiLQMgW89SsI2VP2 XzlIUheBqfngdv9+Y6WjXOKBN4OhWhWG X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:aa27:6848:76cc:141c]) (user=irogers job=sendgmr) by 2002:a05:690c:2882:b0:5d3:985c:800c with SMTP id ee2-20020a05690c288200b005d3985c800cmr869ywb.3.1701993929362; Thu, 07 Dec 2023 16:05:29 -0800 (PST) Date: Thu, 7 Dec 2023 16:05:15 -0800 In-Reply-To: <20231208000515.1693746-1-irogers@google.com> Message-Id: <20231208000515.1693746-3-irogers@google.com> Mime-Version: 1.0 References: <20231208000515.1693746-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Subject: [PATCH v1 3/3] perf help: Lower levenshtein penality for deleting character From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Chenyuan Mi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 07 Dec 2023 16:06:09 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784670065645924462 X-GMAIL-MSGID: 1784670065645924462 The levenshtein penalty for deleting a character was far higher than subsituting or inserting a character. Lower the penalty to match that of inserting a character. Before: ``` $ perf recccord perf: 'recccord' is not a perf-command. See 'perf --help'. ``` After: ``` $ perf recccord perf: 'recccord' is not a perf-command. See 'perf --help'. Did you mean this? record ``` Signed-off-by: Ian Rogers --- tools/perf/util/help-unknown-cmd.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/help-unknown-cmd.c b/tools/perf/util/help-unknown-cmd.c index 2ba3369f1620..a0a46e34f8d1 100644 --- a/tools/perf/util/help-unknown-cmd.c +++ b/tools/perf/util/help-unknown-cmd.c @@ -73,10 +73,14 @@ const char *help_unknown_cmd(const char *cmd, struct cmdnames *main_cmds) if (main_cmds->cnt) { /* This reuses cmdname->len for similarity index */ - for (i = 0; i < main_cmds->cnt; ++i) + for (i = 0; i < main_cmds->cnt; ++i) { main_cmds->names[i]->len = - levenshtein(cmd, main_cmds->names[i]->name, 0, 2, 1, 4); - + levenshtein(cmd, main_cmds->names[i]->name, + /*swap_penalty=*/0, + /*substition_penality=*/2, + /*insertion_penality=*/1, + /*deletion_penalty=*/1); + } qsort(main_cmds->names, main_cmds->cnt, sizeof(*main_cmds->names), levenshtein_compare);