Message ID | 20231208-palpitate-passable-c79bacf2036c@spud |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5595244vqy; Fri, 8 Dec 2023 09:13:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0lmMreRm5sKJfdX1VcMnmTnGbTXYpRag0BjHMHWW/9c0tqnWKBu/9+SGWFO1Yl+lSJgNE X-Received: by 2002:a05:6e02:156c:b0:35d:537d:5eba with SMTP id k12-20020a056e02156c00b0035d537d5ebamr514264ilu.24.1702055599477; Fri, 08 Dec 2023 09:13:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702055599; cv=none; d=google.com; s=arc-20160816; b=I3bA3pOq2Mtb7JfhIilD3qzihXkvyo7FiMZL7yy7mKwz3j5be0dHipnO+p28SeNmoQ P1chQHH9/8Dk4SlB6LP1n+AIjLPejKip2WBQwiLrTETDlcdUgiCEWeaGqjKwK9XHq89u hJI0tmiv/I76KKxy23t8tR8UU9hHB3KBsRWXlVz7tNdLC3JRQjBGs8sAN1H4zmiR/VDe DYC/2ZtpwlnVzmKiuRs+ThEBFJ8dElxBLS4WYzWuHH01WmxhxHlWkaVFWfuavcwNYcqT Wstp+DKX2gdafixHwTO+ZaIqsAJfIkXDFpgr5krzFznwOLb5Z3CDCfuj+8eD0haYSZaO GowA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=n0xpphROQh2WFIIqgKH5mAUKfdiR29B0A5L73ge8T1I=; fh=7owW42T6ZLRf2RzLwZvq8R8LNTe7zgMt8CKJpj74120=; b=rFPRltgfppiWTT20u0rrzSs2RVeLTpr4+ni0bc/CVzQaoibTlGI9Wnjplfgjur8Vue IsaPliF/TXuJi5+aQtChkczFDhCzMH7+U3n6oTYRAmx4jyXRgc0xoG0ktKV8ga48EK7F 8mHlj3Wo7fkka7TBQy04mLd75b0GkajFLlKTjHByo4JDsz4jZQGZ/lUsWBir5ifUd7br 8jKqWAwY4C8BeWhx62BU0rxWImuendgD+w8vgl6sglafPCPVmdKu/dnhMe4QH+hExWiq 6tRwWHxZdn/PPnFhNg9LRr599OX8ibNUJAEzLS1SpYywVrBWKoR/4AlR8I3J00V7b0aq 6XoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KHk8a5tZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id q16-20020a656850000000b005c671034479si1829194pgt.490.2023.12.08.09.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:13:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KHk8a5tZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id F129C837A4E3; Fri, 8 Dec 2023 09:13:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233780AbjLHRM6 (ORCPT <rfc822;ezelljr.billy@gmail.com> + 99 others); Fri, 8 Dec 2023 12:12:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233784AbjLHRMz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 8 Dec 2023 12:12:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7C041989 for <linux-kernel@vger.kernel.org>; Fri, 8 Dec 2023 09:13:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56995C433B9; Fri, 8 Dec 2023 17:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702055581; bh=eOwkSq/WwMGsBDJxIoKyyiwasgmQQYpNauvY4yRRwsE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KHk8a5tZwx6HzsT8T5BnndKAcsPltUq64Ek4Pr5fovixj2Aq/i9OEQXYhY+w6CuIB iQ713l1de5Asz5Ax4hK6RGHX7DC9QEYGeaWRNgbiDq3hDTLN7j1D5mgaj0jjqzZ7Xu 1aB87nlMv7p+TlIYR4E4rcHY/JiUJpxGIg++fsAWcK87pRUKQYMBgZHsDiDJ5g+U8/ GtwCtIK7kY0TJZE4KCj4b6NFP89gICI5qYZkGl0Ja20tWFXDy8Y3/wQVROVliaZjzC KkeyJScyQ+CQ8bkVKg1sPQwblR2SFrf4hHKg9DAsw6n0GcGtDVGerkBdQMiMAiG08l NfWbBDmM8zYqQ== From: Conor Dooley <conor@kernel.org> To: linux-riscv@lists.infradead.org Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>, Daire McNamara <daire.mcnamara@microchip.com>, Wolfgang Grandegger <wg@grandegger.com>, Marc Kleine-Budde <mkl@pengutronix.de>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH RESEND v1 2/7] dt-bindings: can: mpfs: add missing required clock Date: Fri, 8 Dec 2023 17:12:24 +0000 Message-Id: <20231208-palpitate-passable-c79bacf2036c@spud> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231208-reenter-ajar-b6223e5134b3@spud> References: <20231208-reenter-ajar-b6223e5134b3@spud> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1442; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=t/lsdJsWux+0djN2ESjLKlgMF40rkcl8R8FM1XRhzgA=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDKnFfuUPWvbyRO6Tbtj3XqD4/x2h2j8HPA3+TjArX7qZR 3nqsvs/O0pZGMQ4GGTFFFkSb/e1SK3/47LDuectzBxWJpAhDFycAjCR9GaGP9yJsZf/zW2rSddd 9SykPKmwPsXIv9vR85b+VLVjN0PVQxn++zcH+hXx6GgvW2xp8sDt9Pna46/0LFtPtVv3PxGL+zW bAQA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 08 Dec 2023 09:13:16 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784734652359330022 X-GMAIL-MSGID: 1784734652359330022 |
Series |
MPFS clock fixes required for correct CAN clock modeling
|
|
Commit Message
Conor Dooley
Dec. 8, 2023, 5:12 p.m. UTC
From: Conor Dooley <conor.dooley@microchip.com> The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a CAN bus clock. The bus clock was omitted when the binding was written, but is required for operation. Make up for lost time and add it. Cautionary tale in adding bindings without having implemented a real user for them perhaps. Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Comments
On Fri, 08 Dec 2023 17:12:24 +0000, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > CAN bus clock. The bus clock was omitted when the binding was written, > but is required for operation. Make up for lost time and add it. > > Cautionary tale in adding bindings without having implemented a real > user for them perhaps. > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml: properties:clocks: {'maxItems': 2, 'items': [{'description': 'AHB peripheral clock'}, {'description': 'CAN bus clock'}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231208-palpitate-passable-c79bacf2036c@spud The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Dec 08, 2023 at 12:31:00PM -0600, Rob Herring wrote: > > On Fri, 08 Dec 2023 17:12:24 +0000, Conor Dooley wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > CAN bus clock. The bus clock was omitted when the binding was written, > > but is required for operation. Make up for lost time and add it. > > > > Cautionary tale in adding bindings without having implemented a real > > user for them perhaps. > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml: properties:clocks: {'maxItems': 2, 'items': [{'description': 'AHB peripheral clock'}, {'description': 'CAN bus clock'}]} should not be valid under {'required': ['maxItems']} > hint: "maxItems" is not needed with an "items" list > from schema $id: http://devicetree.org/meta-schemas/items.yaml# Oh dear, me of all people.
On Fri, Dec 08, 2023 at 07:25:39PM +0000, Conor Dooley wrote: > On Fri, Dec 08, 2023 at 12:31:00PM -0600, Rob Herring wrote: > > > > On Fri, 08 Dec 2023 17:12:24 +0000, Conor Dooley wrote: > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > > CAN bus clock. The bus clock was omitted when the binding was written, > > > but is required for operation. Make up for lost time and add it. > > > > > > Cautionary tale in adding bindings without having implemented a real > > > user for them perhaps. > > > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > > --- > > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml: properties:clocks: {'maxItems': 2, 'items': [{'description': 'AHB peripheral clock'}, {'description': 'CAN bus clock'}]} should not be valid under {'required': ['maxItems']} > > hint: "maxItems" is not needed with an "items" list > > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > > Oh dear, me of all people. Happens to the best of us. :)
On 08.12.2023 17:12:24, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > CAN bus clock. The bus clock was omitted when the binding was written, > but is required for operation. Make up for lost time and add it. > > Cautionary tale in adding bindings without having implemented a real > user for them perhaps. > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > index 45aa3de7cf01..05f680f15b17 100644 > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > @@ -24,7 +24,10 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 1 > + maxItems: 2 > + items: > + - description: AHB peripheral clock > + - description: CAN bus clock Do we we want to have a "clock-names" property, as we need the clock rate of the CAN bus clock. Marc > > required: > - compatible > @@ -39,7 +42,7 @@ examples: > can@2010c000 { > compatible = "microchip,mpfs-can"; > reg = <0x2010c000 0x1000>; > - clocks = <&clkcfg 17>; > + clocks = <&clkcfg 17>, <&clkcfg 37>; > interrupt-parent = <&plic>; > interrupts = <56>; > }; Marc
On Tue, Dec 12, 2023 at 09:49:41PM +0100, Marc Kleine-Budde wrote: > On 08.12.2023 17:12:24, Conor Dooley wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > CAN bus clock. The bus clock was omitted when the binding was written, > > but is required for operation. Make up for lost time and add it. > > > > Cautionary tale in adding bindings without having implemented a real > > user for them perhaps. > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > index 45aa3de7cf01..05f680f15b17 100644 > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > @@ -24,7 +24,10 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 1 > > + maxItems: 2 > > + items: > > + - description: AHB peripheral clock > > + - description: CAN bus clock > > Do we we want to have a "clock-names" property, as we need the clock > rate of the CAN bus clock. We should not need the clock-names property to be able to get both of the clocks. clk_bulk_get_all() for example should be usable here. Cheers, Conor.
On 13.12.2023 13:02:49, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 09:49:41PM +0100, Marc Kleine-Budde wrote: > > On 08.12.2023 17:12:24, Conor Dooley wrote: > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > > CAN bus clock. The bus clock was omitted when the binding was written, > > > but is required for operation. Make up for lost time and add it. > > > > > > Cautionary tale in adding bindings without having implemented a real > > > user for them perhaps. > > > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > > --- > > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > index 45aa3de7cf01..05f680f15b17 100644 > > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > @@ -24,7 +24,10 @@ properties: > > > maxItems: 1 > > > > > > clocks: > > > - maxItems: 1 > > > + maxItems: 2 > > > + items: > > > + - description: AHB peripheral clock > > > + - description: CAN bus clock > > > > Do we we want to have a "clock-names" property, as we need the clock > > rate of the CAN bus clock. > > We should not need the clock-names property to be able to get both of > the clocks. clk_bulk_get_all() for example should be usable here. ACK, but we need the clock rate of CAN clock. Does this binding check that the CAN clock rate is the 2nd one? regards, Marc
On Thu, Dec 14, 2023 at 12:31:04PM +0100, Marc Kleine-Budde wrote: > On 13.12.2023 13:02:49, Conor Dooley wrote: > > On Tue, Dec 12, 2023 at 09:49:41PM +0100, Marc Kleine-Budde wrote: > > > On 08.12.2023 17:12:24, Conor Dooley wrote: > > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > > > > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > > > CAN bus clock. The bus clock was omitted when the binding was written, > > > > but is required for operation. Make up for lost time and add it. > > > > > > > > Cautionary tale in adding bindings without having implemented a real > > > > user for them perhaps. > > > > > > > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > > > --- > > > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > index 45aa3de7cf01..05f680f15b17 100644 > > > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > @@ -24,7 +24,10 @@ properties: > > > > maxItems: 1 > > > > > > > > clocks: > > > > - maxItems: 1 > > > > + maxItems: 2 > > > > + items: > > > > + - description: AHB peripheral clock > > > > + - description: CAN bus clock > > > > > > Do we we want to have a "clock-names" property, as we need the clock > > > rate of the CAN bus clock. > > > > We should not need the clock-names property to be able to get both of > > the clocks. clk_bulk_get_all() for example should be usable here. > > ACK, but we need the clock rate of CAN clock. Does this binding check > that the CAN clock rate is the 2nd one? The items list requires that the can clock be the second one, so drivers etc can rely on that ordering.
On 14.12.2023 13:16:55, Conor Dooley wrote: > > > > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > > > > @@ -24,7 +24,10 @@ properties: > > > > > maxItems: 1 > > > > > > > > > > clocks: > > > > > - maxItems: 1 > > > > > + maxItems: 2 > > > > > + items: > > > > > + - description: AHB peripheral clock > > > > > + - description: CAN bus clock > > > > > > > > Do we we want to have a "clock-names" property, as we need the clock > > > > rate of the CAN bus clock. > > > > > > We should not need the clock-names property to be able to get both of > > > the clocks. clk_bulk_get_all() for example should be usable here. > > > > ACK, but we need the clock rate of CAN clock. Does this binding check > > that the CAN clock rate is the 2nd one? > > The items list requires that the can clock be the second one, so drivers > etc can rely on that ordering. Thanks for the clarification, Marc
diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml index 45aa3de7cf01..05f680f15b17 100644 --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml @@ -24,7 +24,10 @@ properties: maxItems: 1 clocks: - maxItems: 1 + maxItems: 2 + items: + - description: AHB peripheral clock + - description: CAN bus clock required: - compatible @@ -39,7 +42,7 @@ examples: can@2010c000 { compatible = "microchip,mpfs-can"; reg = <0x2010c000 0x1000>; - clocks = <&clkcfg 17>; + clocks = <&clkcfg 17>, <&clkcfg 37>; interrupt-parent = <&plic>; interrupts = <56>; };