From patchwork Thu Dec 7 16:34:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Huey X-Patchwork-Id: 175283 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4906785vqy; Thu, 7 Dec 2023 08:35:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEA38v1A4dwrvxvm8bQrR/twxTDQfhHTHmnADVcAEvRSklrXXXC/olBR2oL04uvfqlk4x4Y X-Received: by 2002:a17:90a:e7c2:b0:286:e2bb:26a4 with SMTP id kb2-20020a17090ae7c200b00286e2bb26a4mr2194029pjb.40.1701966958883; Thu, 07 Dec 2023 08:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701966958; cv=none; d=google.com; s=arc-20160816; b=JY2EskB/ynGZLY1IoUslLKjcDUHmw4qz91s7ugFYJw+kUXivvLCwwQ0JTx+5Q6g1IX HxLRcqJdxQ/aekhzAKMgw9UNG9w/U9bvZSRVYBamMLd35DYZXHm2EKtA1dPBcCBoWU2r 8SRBXLuYTVS607ZWIANzpDZDtR7OlhCQ/yNRzVGIMu/2gsyHAJS0P/rkFEN2A+QbPCKa kOvJZE+ZDGIYx4pzuqQzBOE6PSAmHlgc6ws6xccQn9BJUWgpV+m4KWCOlv/wlTTs7Qwn P8N6R2WZ9ID6eHb5nYeOSVK6Js5Ng9l4+CdmiRvvtxcDO0X+yh6WF3GBtwnnorcEM76g 6hTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9osTTHotszQKXwqlQLd/oaMNF9NAZxsSosoDc6zgOuE=; fh=egt9JzErx/09xKZ01e8H7iMpAphoCk+NidsT8VHXf94=; b=WzUOm5tYtLUrZwbuKgKxvxwNrS4ZrRA0QLNMRcHynUv5F+9S4+vO065g3bDRpsTCUg p+WPEH1OGVlAMiNjbvGVB+pj/oFgagw9C06Ms8bJQOwc/Dm6D2H0nEjvPml5vBCLjmH3 mwtfOP+CyoBJ+4Ex0I3gcxdpPhDdVszlE5p1kN9sQjfmR+70MI1j1vZapdZqLNJNKgiA igot/n1E7JqsRs1ZO6SSVDkH6Z3rCdYUuUZGgBQmDrQn+fFq40tOEgS6GsklQEoTRAdn lueIjwdtiew/ddTbPAQIZmcuXGg8R/tuQBB3u2kGBxOV+bf0pf7gPV7Wd0SjlFqoBjDY T0Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kylehuey.com header.s=google header.b=guqiquCD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id a9-20020a17090a740900b00286acacd596si88207pjg.136.2023.12.07.08.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 08:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kylehuey.com header.s=google header.b=guqiquCD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B42CB80320EE; Thu, 7 Dec 2023 08:35:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233026AbjLGQfW (ORCPT + 99 others); Thu, 7 Dec 2023 11:35:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233041AbjLGQfT (ORCPT ); Thu, 7 Dec 2023 11:35:19 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10B2E132 for ; Thu, 7 Dec 2023 08:35:22 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1d0c94397c0so8141955ad.2 for ; Thu, 07 Dec 2023 08:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kylehuey.com; s=google; t=1701966921; x=1702571721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9osTTHotszQKXwqlQLd/oaMNF9NAZxsSosoDc6zgOuE=; b=guqiquCDDbMLYq3eH2n38T7sPBx426J4mjZcL0wNaAjrTabqZGy+S1ks8lcxs3Xfp1 C36Sj6oXju/pQDECYrk2GH5SpsWqyMLo+gNhg3ypC73rxWjOQiuGv7MENNOWMfXeZAoD eqXPCZuJFwP2l+cyIFu65Rf2pj1pg5YB+RJPDQ4X88rMro10dKJtNjzawZOwkMSsCMNb Pr8Le3ZtQGoNLImBwmSZM8tE8WSa8rPVR9SBOpRQJUdFdgqXd1Q3hwiIZFL1VbYQWetT B4ap62AEHiQ3sp0Ex3zQsgpZcQJJBQyOhwl6suuToU70J1R7hmw0UdJsumPgJXTaWmml ZEAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701966921; x=1702571721; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9osTTHotszQKXwqlQLd/oaMNF9NAZxsSosoDc6zgOuE=; b=dDli/Xw4Oy11hA9JdwHazv/Jp9/sHmLCVN9E0Rkne1IYolDoJNiEL9gnL5c4KRWdqJ MvS6C9aywQMDVguw4UCW5c3aIyBKE3ZCq/UO0Jd9GvRrToVaLlz052IvV7SJn6WsZwXy HqIB2F6ey5w76OhZAXZxdV9aNH98IrQ+ajrfsdCICC2odbyXDn5vxRmEh7geogxco2em Sv4gNcCtdwfI319irTwmdnp5K8YtzaIRCA3NEys+ok4cKRnxbY1QHCxdgxiLbihIt1rK tJiJASiBowPZ3Q6m1lcgME1GgpYRj/2celnnsuuMCkdYmcOFO+1cllhKjKqL8FcG3QV4 zMxA== X-Gm-Message-State: AOJu0YxnpQk23Zb4VSVhO7ZZJxBSqEo6qOmXFFl6HMQdsRbJr8hGKSp7 2Pfn4UD5GcWOTihKg3bWDMCHJg== X-Received: by 2002:a17:902:7c17:b0:1d0:b033:4a98 with SMTP id x23-20020a1709027c1700b001d0b0334a98mr2630388pll.17.1701966921325; Thu, 07 Dec 2023 08:35:21 -0800 (PST) Received: from zhadum.home.kylehuey.com (c-76-126-33-191.hsd1.ca.comcast.net. [76.126.33.191]) by smtp.gmail.com with ESMTPSA id iw15-20020a170903044f00b001d1cd7e4acfsm6143plb.201.2023.12.07.08.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 08:35:20 -0800 (PST) From: Kyle Huey X-Google-Original-From: Kyle Huey To: Kyle Huey , linux-kernel@vger.kernel.org, Andrii Nakryiko , Jiri Olsa , Namhyung Kim , Marco Elver , Yonghong Song Cc: Robert O'Callahan , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Mykola Lysenko , Shuah Khan , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH v2 3/3] selftest/bpf: Test a perf bpf program that suppresses side effects. Date: Thu, 7 Dec 2023 08:34:58 -0800 Message-Id: <20231207163458.5554-4-khuey@kylehuey.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231207163458.5554-1-khuey@kylehuey.com> References: <20231207163458.5554-1-khuey@kylehuey.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 08:35:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784641706004809151 X-GMAIL-MSGID: 1784641706004809151 The test sets a hardware breakpoint and uses a bpf program to suppress the side effects of a perf event sample, including I/O availability signals, SIGTRAPs, and decrementing the event counter limit, if the ip matches the expected value. Then the function with the breakpoint is executed multiple times to test that all effects behave as expected. Signed-off-by: Kyle Huey --- .../selftests/bpf/prog_tests/perf_skip.c | 145 ++++++++++++++++++ .../selftests/bpf/progs/test_perf_skip.c | 15 ++ 2 files changed, 160 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/perf_skip.c create mode 100644 tools/testing/selftests/bpf/progs/test_perf_skip.c diff --git a/tools/testing/selftests/bpf/prog_tests/perf_skip.c b/tools/testing/selftests/bpf/prog_tests/perf_skip.c new file mode 100644 index 000000000000..f6fa9bfd9efa --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/perf_skip.c @@ -0,0 +1,145 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE + +/* We need the latest siginfo from the kernel repo. */ +#include +#define __have_siginfo_t 1 +#define __have_sigval_t 1 +#define __have_sigevent_t 1 +#define __siginfo_t_defined +#define __sigval_t_defined +#define __sigevent_t_defined +#define _BITS_SIGINFO_CONSTS_H 1 +#define _BITS_SIGEVENT_CONSTS_H 1 + +#include +#include "test_perf_skip.skel.h" +#include +#include +#include + +int signals_unexpected = 1; +int sigio_count, sigtrap_count; + +static void handle_sigio(int sig __always_unused) +{ + ASSERT_OK(signals_unexpected, "perf event not skipped"); + ++sigio_count; +} + +static void handle_sigtrap(int signum __always_unused, + siginfo_t *info, + void *ucontext __always_unused) +{ + ASSERT_OK(signals_unexpected, "perf event not skipped"); + ASSERT_EQ(info->si_code, TRAP_PERF, "wrong si_code"); + ++sigtrap_count; +} + +static noinline int test_function(void) +{ + asm volatile (""); + return 0; +} + +void serial_test_perf_skip(void) +{ + struct sigaction action = {}; + struct sigaction previous_sigtrap; + sighandler_t previous_sigio; + struct test_perf_skip *skel = NULL; + struct perf_event_attr attr = {}; + int perf_fd = -1; + int err; + struct f_owner_ex owner; + struct bpf_link *prog_link = NULL; + + action.sa_flags = SA_SIGINFO | SA_NODEFER; + action.sa_sigaction = handle_sigtrap; + sigemptyset(&action.sa_mask); + if (!ASSERT_OK(sigaction(SIGTRAP, &action, &previous_sigtrap), "sigaction")) + return; + + previous_sigio = signal(SIGIO, handle_sigio); + + skel = test_perf_skip__open_and_load(); + if (!ASSERT_OK_PTR(skel, "skel_load")) + goto cleanup; + + attr.type = PERF_TYPE_BREAKPOINT; + attr.size = sizeof(attr); + attr.bp_type = HW_BREAKPOINT_X; + attr.bp_addr = (uintptr_t)test_function; + attr.bp_len = sizeof(long); + attr.sample_period = 1; + attr.sample_type = PERF_SAMPLE_IP; + attr.pinned = 1; + attr.exclude_kernel = 1; + attr.exclude_hv = 1; + attr.precise_ip = 3; + attr.sigtrap = 1; + attr.remove_on_exec = 1; + + perf_fd = syscall(__NR_perf_event_open, &attr, 0, -1, -1, 0); + if (perf_fd < 0 && (errno == ENOENT || errno == EOPNOTSUPP)) { + printf("SKIP:no PERF_TYPE_BREAKPOINT/HW_BREAKPOINT_X\n"); + test__skip(); + goto cleanup; + } + if (!ASSERT_OK(perf_fd < 0, "perf_event_open")) + goto cleanup; + + // Configure the perf event to signal on sample. + err = fcntl(perf_fd, F_SETFL, O_ASYNC); + if (!ASSERT_OK(err, "fcntl(F_SETFL, O_ASYNC)")) + goto cleanup; + + owner.type = F_OWNER_TID; + owner.pid = syscall(__NR_gettid); + err = fcntl(perf_fd, F_SETOWN_EX, &owner); + if (!ASSERT_OK(err, "fcntl(F_SETOWN_EX)")) + goto cleanup; + + // Allow at most one sample. A sample rejected by bpf should + // not count against this. + err = ioctl(perf_fd, PERF_EVENT_IOC_REFRESH, 1); + if (!ASSERT_OK(err, "ioctl(PERF_EVENT_IOC_REFRESH)")) + goto cleanup; + + prog_link = bpf_program__attach_perf_event(skel->progs.handler, perf_fd); + if (!ASSERT_OK_PTR(prog_link, "bpf_program__attach_perf_event")) + goto cleanup; + + // Configure the bpf program to suppress the sample. + skel->bss->ip = (uintptr_t)test_function; + test_function(); + + ASSERT_EQ(sigio_count, 0, "sigio_count"); + ASSERT_EQ(sigtrap_count, 0, "sigtrap_count"); + + // Configure the bpf program to allow the sample. + skel->bss->ip = 0; + signals_unexpected = 0; + test_function(); + + ASSERT_EQ(sigio_count, 1, "sigio_count"); + ASSERT_EQ(sigtrap_count, 1, "sigtrap_count"); + + // Test that the sample above is the only one allowed (by perf, not + // by bpf) + test_function(); + + ASSERT_EQ(sigio_count, 1, "sigio_count"); + ASSERT_EQ(sigtrap_count, 1, "sigtrap_count"); + +cleanup: + if (prog_link) + bpf_link__destroy(prog_link); + if (perf_fd >= 0) + close(perf_fd); + if (skel) + test_perf_skip__destroy(skel); + + signal(SIGIO, previous_sigio); + sigaction(SIGTRAP, &previous_sigtrap, NULL); +} diff --git a/tools/testing/selftests/bpf/progs/test_perf_skip.c b/tools/testing/selftests/bpf/progs/test_perf_skip.c new file mode 100644 index 000000000000..417a9db3b770 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/test_perf_skip.c @@ -0,0 +1,15 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "vmlinux.h" +#include +#include + +uintptr_t ip; + +SEC("perf_event") +int handler(struct bpf_perf_event_data *data) +{ + // Skip events that have the correct ip. + return ip != PT_REGS_IP(&data->regs); +} + +char _license[] SEC("license") = "GPL";